On 11/04/2014 11:56 AM, David Holmes wrote:
On 4/11/2014 7:49 PM, Jaroslav Bachorik wrote:
On 11/04/2014 07:50 AM, David Holmes wrote:
On 3/11/2014 10:37 PM, Jaroslav Bachorik wrote:
May I have a (R)eviewer to take a look at this, please?
http://cr.openjdk.java.net/~jbachorik/8058506/webrev.0
On 4/11/2014 7:49 PM, Jaroslav Bachorik wrote:
On 11/04/2014 07:50 AM, David Holmes wrote:
On 3/11/2014 10:37 PM, Jaroslav Bachorik wrote:
May I have a (R)eviewer to take a look at this, please?
http://cr.openjdk.java.net/~jbachorik/8058506/webrev.01
I don't understand the need for the semap
On 11/04/2014 07:50 AM, David Holmes wrote:
On 3/11/2014 10:37 PM, Jaroslav Bachorik wrote:
May I have a (R)eviewer to take a look at this, please?
http://cr.openjdk.java.net/~jbachorik/8058506/webrev.01
I don't understand the need for the semaphore given you do:
116 thread.joi
On 3/11/2014 10:37 PM, Jaroslav Bachorik wrote:
May I have a (R)eviewer to take a look at this, please?
http://cr.openjdk.java.net/~jbachorik/8058506/webrev.01
I don't understand the need for the semaphore given you do:
116 thread.join();
117 System.out.println(threa
May I have a (R)eviewer to take a look at this, please?
http://cr.openjdk.java.net/~jbachorik/8058506/webrev.01
-JB-
On 10/23/2014 03:31 PM, Erik Gahlin wrote:
Looks good!
Erik
Jaroslav Bachorik skrev 2014-10-23 11:45:
On 10/21/2014 07:47 PM, Jaroslav Bachorik wrote:
On 10/21/2014 03:27 PM
Looks good!
Erik
Jaroslav Bachorik skrev 2014-10-23 11:45:
On 10/21/2014 07:47 PM, Jaroslav Bachorik wrote:
On 10/21/2014 03:27 PM, Erik Gahlin wrote:
Have you considered creating a LogMessage class that keeps the logCntr
value and the log message, instead of putting the counter into the log
On 10/21/2014 07:47 PM, Jaroslav Bachorik wrote:
On 10/21/2014 03:27 PM, Erik Gahlin wrote:
Have you considered creating a LogMessage class that keeps the logCntr
value and the log message, instead of putting the counter into the log
string and parsing it.
Yes. And didn't go that way in order
On 10/21/2014 03:27 PM, Erik Gahlin wrote:
Have you considered creating a LogMessage class that keeps the logCntr
value and the log message, instead of putting the counter into the log
string and parsing it.
Yes. And didn't go that way in order to prevent creating a lot of
throwaway stringbuil
Have you considered creating a LogMessage class that keeps the logCntr
value and the log message, instead of putting the counter into the log
string and parsing it.
Seems simpler and easier to understand.
Erik
Jaroslav Bachorik skrev 2014-10-20 13:12:
Please, review the following test change
