Looks good!
Thanks,
/Staffan
> On 28 nov 2014, at 16:11, Jaroslav Bachorik
> wrote:
>
> Thanks Frederic, Erik!
>
> The update webrev is here:
> http://cr.openjdk.java.net/~jbachorik/8065783/webrev.01
>
> May I have (R)eviewer taking a stab at this?
>
> Thanks,
>
> -JB-
>
> On 11/28/2014
Thanks Frederic, Erik!
The update webrev is here:
http://cr.openjdk.java.net/~jbachorik/8065783/webrev.01
May I have (R)eviewer taking a stab at this?
Thanks,
-JB-
On 11/28/2014 02:04 PM, frederic parain wrote:
Thank you for fixing this.
Looks good to me.
+1 on Erik's comments.
Fred
On
Thank you for fixing this.
Looks good to me.
+1 on Erik's comments.
Fred
On 27/11/2014 15:25, Erik Gahlin wrote:
Looks ok,
Things that could be fixed, but not necessary.
src/share/vm/services/diagnosticFramework.cpp : 63 // skipping spaces
could be changed to "skipping delimiters"
src/sha
Looks ok,
Things that could be fixed, but not necessary.
src/share/vm/services/diagnosticFramework.cpp : 63 // skipping spaces
could be changed to "skipping delimiters"
src/share/vm/services/diagnosticFramework.cpp : 66 _cursor = _len - 1;
Could be removed, since it must be true to enter if cl
