RE: Remove unused import proposal: in JdpController.java

2018-02-22 Thread Andrew Leonard
viceability-dev@openjdk.java.net" Date: 22/02/2018 08:26 Subject: RE: Remove unused import proposal: in JdpController.java Hi Andrew, I'll take this on as I have a similar include cleanup change in my queue for java/util/jar/Attributes.java. Will post a separate review request... Best

RE: Remove unused import proposal: in JdpController.java

2018-02-22 Thread Langer, Christoph
enjdk.java.net] On Behalf Of David Holmes > Sent: Donnerstag, 22. Februar 2018 05:12 > To: Andrew Leonard ; serviceability- > d...@openjdk.java.net > Subject: Re: Remove unused import proposal: in JdpController.java > > Hi Andrew, > > I've filed: > > https://bugs.

Re: Remove unused import proposal: in JdpController.java

2018-02-21 Thread David Holmes
Hi Andrew, I've filed: https://bugs.openjdk.java.net/browse/JDK-8198539 to clean up your leftover import from JDK-8183123 :) (which was fixed in 10 not 9). If someone from serviceability doesn't pick this up I may be able to. David On 22/02/2018 1:29 AM, Andrew Leonard wrote: Hi, I would

Re: Remove unused import proposal: in JdpController.java

2018-02-21 Thread Martin Buchholz
I've done my fair share of import cleanup, but friction is high enough that it should be done in bulk. If you can succeed in loading jdk sources into intellij, then you can get intellij to find all the unused imports for you, e.g. in the jdk core libraries. On Wed, Feb 21, 2018 at 7:29 AM, Andrew

Remove unused import proposal: in JdpController.java

2018-02-21 Thread Andrew Leonard
Hi, I would like to find a sponsor please for this simple tidy up of JdpController.java ? It contains an unused "import sun.management.VMManagement;" which is for a sun specific java.management class which this class used to use prior to jdk9. Thanks Andrew diff --git a/src/jdk.management.agen