Re: Request for review:8023477: Invalid CP index when reading ConstantPool

2013-08-26 Thread Staffan Larsen
Looks good. Thanks, /Staffan On 23 aug 2013, at 23:49, Jiangli Zhou jiangli.z...@oracle.com wrote: Hi, Please review the fix for 8023477: http://cr.openjdk.java.net/~jiangli/8023477/webrev.00/ Both tests reported by the bug failed due to the same problem. They both are passing now.

Re: Request for review:8023477: Invalid CP index when reading ConstantPool

2013-08-26 Thread Jiangli Zhou
Thanks, Staffan! Jiangli On 08/26/2013 01:13 AM, Staffan Larsen wrote: Looks good. Thanks, /Staffan On 23 aug 2013, at 23:49, Jiangli Zhou jiangli.z...@oracle.com wrote: Hi, Please review the fix for 8023477: http://cr.openjdk.java.net/~jiangli/8023477/webrev.00/ Both tests reported

Request for review:8023477: Invalid CP index when reading ConstantPool

2013-08-23 Thread Jiangli Zhou
Hi, Please review the fix for 8023477: http://cr.openjdk.java.net/~jiangli/8023477/webrev.00/ Both tests reported by the bug failed due to the same problem. They both are passing now. The original memory reduction change for 8021948 turned out to be a little trickier than I expected.

Re: Request for review:8023477: Invalid CP index when reading ConstantPool

2013-08-23 Thread serguei.spit...@oracle.com
Hi Jiangli, The fix looks good and safe. Thanks, Serguei On 8/23/13 2:49 PM, Jiangli Zhou wrote: Hi, Please review the fix for 8023477: http://cr.openjdk.java.net/~jiangli/8023477/webrev.00/ Both tests reported by the bug failed due to the same problem. They both are passing now. The

Re: Request for review:8023477: Invalid CP index when reading ConstantPool

2013-08-23 Thread Jiangli Zhou
Thanks again, Serguei! Jiangli On 08/23/2013 03:27 PM, serguei.spit...@oracle.com wrote: Hi Jiangli, The fix looks good and safe. Thanks, Serguei On 8/23/13 2:49 PM, Jiangli Zhou wrote: Hi, Please review the fix for 8023477: http://cr.openjdk.java.net/~jiangli/8023477/webrev.00/ Both