Ship it.
Thanks,
Serguei
On 1/31/13 11:50 PM, Stefan Karlsson wrote:
On 2013-02-01 00:15, Coleen Phillimore wrote:
Stefan,
I just read through this test and it looks like a good test to me
(but I'm not an expert and it took a while to figure out how it
worked). I had two questions.
On 2013-02-01 09:50, serguei.spit...@oracle.com wrote:
Ship it.
Thanks!
StefanK
Thanks,
Serguei
On 1/31/13 11:50 PM, Stefan Karlsson wrote:
On 2013-02-01 00:15, Coleen Phillimore wrote:
Stefan,
I just read through this test and it looks like a good test to me
(but I'm not an expert
Stefan,
I just read through this test and it looks like a good test to me (but
I'm not an expert and it took a while to figure out how it worked). I
had two questions. Why does the same definition for @interface
ParameterAnnotation {} appear in both
Stefan,
Looks good.
Agreed with Coleen: do_redefine = doRedefine.
I guess, this name was taken from one of old tests. :)
I'm Ok with two definitions of the interface ParameterAnnotation.
Thanks,
Setguei
On 1/31/13 3:15 PM, Coleen Phillimore wrote:
Stefan,
I just read through this test and
On 2013-02-01 00:15, Coleen Phillimore wrote:
Stefan,
I just read through this test and it looks like a good test to me (but
I'm not an expert and it took a while to figure out how it worked).
I had two questions. Why does the same definition for @interface
ParameterAnnotation {} appear
On 2013-02-01 01:34, serguei.spit...@oracle.com wrote:
Stefan,
Looks good.
Agreed with Coleen: do_redefine = doRedefine.
I guess, this name was taken from one of old tests. :)
I'm Ok with two definitions of the interface ParameterAnnotation.
Thanks for the review,
StefanK
Thanks,
Setguei
http://cr.openjdk.java.net/~stefank/7140852/webrev.00/
This test provoked the bug in:
7022100: Method annotations are incorrectly set when redefining classes
thanks,
StefanK