Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-02-01 Thread Stefan Karlsson
http://cr.openjdk.java.net/~stefank/8006506/webrev.03/ 1) Reverted the ProblemList change, since the fix has already propagaged to jdk8/tl 2) Renamed do_redefine - doRedefine 3) Updated the .sh file with the bug number of the original CR instead of the test CR. thanks, StefanK On

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-02-01 Thread Stefan Karlsson
On 2013-02-01 10:22, serguei.spit...@oracle.com wrote: Nice test! It looks good. Thanks for reviewing! As the original bug and the test are non-trivial, it'd make sense to add a comment to the class RedefineMethodInBacktraceApp and explain a little bit what the test is doing, and what

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-02-01 Thread serguei.spit...@oracle.com
On 2/1/13 1:57 AM, Stefan Karlsson wrote: On 2013-02-01 10:22, serguei.spit...@oracle.com wrote: Nice test! It looks good. Thanks for reviewing! As the original bug and the test are non-trivial, it'd make sense to add a comment to the class RedefineMethodInBacktraceApp and explain a little

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-02-01 Thread Stefan Karlsson
On 2013-02-01 12:11, serguei.spit...@oracle.com wrote: On 2/1/13 1:57 AM, Stefan Karlsson wrote: On 2013-02-01 10:22, serguei.spit...@oracle.com wrote: Nice test! It looks good. Thanks for reviewing! As the original bug and the test are non-trivial, it'd make sense to add a comment to the

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-02-01 Thread Stefan Karlsson
On 2013-02-01 12:17, Stefan Karlsson wrote: On 2013-02-01 12:11, serguei.spit...@oracle.com wrote: On 2/1/13 1:57 AM, Stefan Karlsson wrote: On 2013-02-01 10:22, serguei.spit...@oracle.com wrote: Nice test! It looks good. Thanks for reviewing! As the original bug and the test are

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-02-01 Thread David Holmes
Hi Stefan, This part of the test: 86 private static void doClassUnloading() { 87 // This will clean out old, unused redefined methods. 88 System.gc(); 89 } seems to make assumptions about System.gc() and class unloading. Are we relying on knowledge of hotspot

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-02-01 Thread Stefan Karlsson
On 2013-02-01 12:48, David Holmes wrote: Hi Stefan, This part of the test: 86 private static void doClassUnloading() { 87 // This will clean out old, unused redefined methods. 88 System.gc(); 89 } seems to make assumptions about System.gc() and class unloading.

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-01-28 Thread Stefan Karlsson
On 01/25/2013 04:40 PM, Coleen Phillimore wrote: I think if you wait a week, you won't need to have it in the problem list. This test passes with my backtrace changes which were pushed to hotspot-main this week. The test looks great and was really helpful! OK. I'll wait for your fix to

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-01-25 Thread Coleen Phillimore
I think if you wait a week, you won't need to have it in the problem list.This test passes with my backtrace changes which were pushed to hotspot-main this week. The test looks great and was really helpful! Thanks!! Coleen On 1/22/2013 8:11 AM, Stefan Karlsson wrote:

Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-01-22 Thread Stefan Karlsson
http://cr.openjdk.java.net/~stefank/8006506/webrev.00/ This test provokes the JVM crash described in bug: JDK-7174978. I intend to push this to: http://hg.openjdk.java.net/jdk8/tl/jdk thanks, StefanK

Re: Review Request: 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests

2013-01-22 Thread Stefan Karlsson
http://cr.openjdk.java.net/~stefank/8006506/webrev.02 After some feedback from Alan Bateman, I've updated to how the java classes are compiled, to match the behavior of similar jtreg tests. thanks, StefanK On 01/22/2013 02:11 PM, Stefan Karlsson wrote: