Re: Review Request: JDK-8049881: jstack not working on core files

2014-07-21 Thread Poonam Bajaj
Hi David, On 7/21/2014 5:52 PM, David Holmes wrote: Hi Poonam, On 21/07/2014 7:29 PM, Poonam Bajaj wrote: The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 : jstack not working on

Re: Review Request: JDK-8049881: jstack not working on core files

2014-07-21 Thread David Holmes
dev@openjdk.java.net Subject: Re: Review Request: JDK-8049881: jstack not working on core files Hi Poonam, On 21/07/2014 7:29 PM, Poonam Bajaj wrote: The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 <https://bugs.op

Re: Review Request: JDK-8049881: jstack not working on core files

2014-07-21 Thread Dmitry Samersoff
Poonam, Looks good for me. I prefer to always put brackets after if (l. 117), but it's not required. -Dmitry On 2014-07-21 13:29, Poonam Bajaj wrote: > The changes for "8046282: SA update" introduced this bug. The following > changes fix the failure. > > Bug: JDK-8049881

RE: Review Request: JDK-8049881: jstack not working on core files

2014-07-21 Thread Markus Grönlund
this moving forward. In the meantime, I think this kludge is ok to fix the pressing problem. Cheers Markus -Original Message- From: David Holmes Sent: den 21 juli 2014 14:23 To: Poonam Bajaj; serviceability-dev@openjdk.java.net Subject: Re: Review Request: JDK-8049881: jstack not w

RE: Review Request: JDK-8049881: jstack not working on core files

2014-07-21 Thread Markus Grönlund
Hi Poonam,   I think this looks good.   Thanks for fixing it.   Cheers Markus   From: Poonam Bajaj Sent: den 21 juli 2014 11:30 To: serviceability-dev@openjdk.java.net Subject: Review Request: JDK-8049881: jstack not working on core files   The changes for "8046282: SA u

Re: Review Request: JDK-8049881: jstack not working on core files

2014-07-21 Thread David Holmes
Hi Poonam, On 21/07/2014 7:29 PM, Poonam Bajaj wrote: The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 : jstack not working on core files Webrev: http://cr.openjdk.java.net/~poonam

Review Request: JDK-8049881: jstack not working on core files

2014-07-21 Thread Poonam Bajaj
The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 : jstack not working on core files Webrev: http://cr.openjdk.java.net/~poonam/8049881/webrev.00/ With these changes jstack works