Re: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

2013-04-19 Thread Peter Allwin
Great, thanks a lot guys! /peter On 4/19/2013 7:02 AM, Rickard Bäckman wrote: Peter, it looks good to me. /R On Apr 19, 2013, at 4:19 AM, David Holmes wrote: Hi Peter, On 19/04/2013 12:10 AM, Peter Allwin wrote: Hi all, I'm still looking for reviews for this change... Sounds like a perfe

Re: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

2013-04-18 Thread Rickard Bäckman
Peter, it looks good to me. /R On Apr 19, 2013, at 4:19 AM, David Holmes wrote: > Hi Peter, > > On 19/04/2013 12:10 AM, Peter Allwin wrote: >> Hi all, I'm still looking for reviews for this change... > > Sounds like a perfectly reasonable change. > > Reviewed. > > Thanks, > David > >> Than

Re: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

2013-04-18 Thread David Holmes
Hi Peter, On 19/04/2013 12:10 AM, Peter Allwin wrote: Hi all, I'm still looking for reviews for this change... Sounds like a perfectly reasonable change. Reviewed. Thanks, David Thanks! /peter On 4/3/2013 6:16 PM, Peter Allwin wrote: Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/

Re: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

2013-04-18 Thread Peter Allwin
Hi all, I'm still looking for reviews for this change... Thanks! /peter On 4/3/2013 6:16 PM, Peter Allwin wrote: Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=67

Re: Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

2013-04-04 Thread Peter Allwin
Hi, I'm still looking for reviewers for this change. Thanks! /peter On 4/3/2013 6:16 PM, Peter Allwin wrote: Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=672992

Review request: 6729929 I18N - Taking Heap Dump failed if project path contains multibyte characters

2013-04-03 Thread Peter Allwin
Webrev: http://cr.openjdk.java.net/~mgronlun/6729929/webrev01/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6729929 Summary: When dumpHeap in the HotSpotDiagnostic JMX MBean is called, the filename parameter must be converted