Re: Review request for 8029378: com/sun/jdi/BadHandshakeTest.java failed with java.util.concurrent.TimeoutException

2014-01-16 Thread shanliang
David Holmes wrote: On 16/01/2014 9:01 PM, shanliang wrote: Jaroslav Bachorik wrote: On 16.1.2014 11:48, shanliang wrote: David Holmes wrote: On 16/01/2014 5:37 PM, shanliang wrote: Hi, Please review this simple fix, the test needs more time to wait Phaser.awaitAdvanceInterruptibly(...).

Re: Review request for 8029378: com/sun/jdi/BadHandshakeTest.java failed with java.util.concurrent.TimeoutException

2014-01-16 Thread David Holmes
On 16/01/2014 9:01 PM, shanliang wrote: Jaroslav Bachorik wrote: On 16.1.2014 11:48, shanliang wrote: David Holmes wrote: On 16/01/2014 5:37 PM, shanliang wrote: Hi, Please review this simple fix, the test needs more time to wait Phaser.awaitAdvanceInterruptibly(...). Integer.MAX_VALUE? T

Re: Review request for 8029378: com/sun/jdi/BadHandshakeTest.java failed with java.util.concurrent.TimeoutException

2014-01-16 Thread shanliang
Jaroslav Bachorik wrote: On 16.1.2014 11:48, shanliang wrote: David Holmes wrote: On 16/01/2014 5:37 PM, shanliang wrote: Hi, Please review this simple fix, the test needs more time to wait Phaser.awaitAdvanceInterruptibly(...). Integer.MAX_VALUE? There's no point using a timed form at all

Re: Review request for 8029378: com/sun/jdi/BadHandshakeTest.java failed with java.util.concurrent.TimeoutException

2014-01-16 Thread Jaroslav Bachorik
On 16.1.2014 11:48, shanliang wrote: David Holmes wrote: On 16/01/2014 5:37 PM, shanliang wrote: Hi, Please review this simple fix, the test needs more time to wait Phaser.awaitAdvanceInterruptibly(...). Integer.MAX_VALUE? There's no point using a timed form at all. David Yes Phaser.await

Re: Review request for 8029378: com/sun/jdi/BadHandshakeTest.java failed with java.util.concurrent.TimeoutException

2014-01-16 Thread shanliang
David Holmes wrote: On 16/01/2014 5:37 PM, shanliang wrote: Hi, Please review this simple fix, the test needs more time to wait Phaser.awaitAdvanceInterruptibly(...). Integer.MAX_VALUE? There's no point using a timed form at all. David Yes Phaser.awaitAdvanceInterruptibly(int phase) could b

Re: Review request for 8029378: com/sun/jdi/BadHandshakeTest.java failed with java.util.concurrent.TimeoutException

2014-01-16 Thread David Holmes
On 16/01/2014 5:37 PM, shanliang wrote: Hi, Please review this simple fix, the test needs more time to wait Phaser.awaitAdvanceInterruptibly(...). Integer.MAX_VALUE? There's no point using a timed form at all. David webrev: http://cr.openjdk.java.net/~sjiang/JDK-8029378/00/ bug: https://bu

Review request for 8029378: com/sun/jdi/BadHandshakeTest.java failed with java.util.concurrent.TimeoutException

2014-01-15 Thread shanliang
Hi, Please review this simple fix, the test needs more time to wait Phaser.awaitAdvanceInterruptibly(...). webrev: http://cr.openjdk.java.net/~sjiang/JDK-8029378/00/ bug: https://bugs.openjdk.java.net/browse/JDK-8029378 Thanks, Shanliang