Hi, thanks for reviewing. I have made the changes you suggested and also
tidied up the constructors a bit (there was already a 4x Address
constructor), hope that's ok.
Cheers,
David
On Fri, 30 Nov 2018 at 17:06, JC Beyler wrote:
> Hi both,
>
> The webrev looks good to me but I could see gains
Ok great, I will submit new patch then. Thanks for reviewing!
Cheers,
David
On Fri, 30 Nov 2018 at 17:06, JC Beyler wrote:
> Hi both,
>
> The webrev looks good to me but I could see gains of just adding a new
> constructor instead of doing a new + set.
>
> LinuxAMD64JavaThreadPDAccess.java wou
Your patch looks good to me, David. I can sponsor this for you if we get
one more review.
Thanks,
Jini.
On 11/22/2018 5:42 PM, David Griffiths wrote:
Thanks Jini, please find patch for Java 9 attached (I don't have author
access to the bug itself).
Cheers,
David
On Thu, 22 Nov 2018 at 09:0
Thanks Jini, please find patch for Java 9 attached (I don't have author
access to the bug itself).
Cheers,
David
On Thu, 22 Nov 2018 at 09:02, Jini George wrote:
> Thank you very much for working on the fix for this issue, David. It
> would be great if you can send in a complete patch for the
Thank you very much for working on the fix for this issue, David. It
would be great if you can send in a complete patch for the review (With
a first cut look, there seems to be missing pieces).
I have created a bug for this:
https://bugs.openjdk.java.net/browse/JDK-8214226
Thank you,
Jini
On
PS: should have added a new X86Frame constructor really, may have just been
put off because there is already a four address constructor so would have
had to add dummy argument or something.
On Wed, 21 Nov 2018 at 19:15, David Griffiths
wrote:
> Hi, thanks, apart from adding a setter for R13 in X
Hi, thanks, apart from adding a setter for R13 in X86Frame, the other half
of the fix is this:
publicFrame getCurrentFrameGuess(JavaThread thread, Address addr) {
ThreadProxy t = getThreadProxy(addr);
AMD64ThreadContext context = (AMD64ThreadContext) t.getContext();
AMD64CurrentF
Hi, I'm new to this mailing list and working on a project that makes use of
the SA classes to get stack traces from a paused in flight JVM (we can't
use JDWP). I have observed that if the top frame is in the interpreter it
reports the BCI and line number incorrectly. This is because
X86Frame.getInt
