On 10/15/13 8:50 AM, Daniel D. Daugherty wrote:
On 10/15/13 6:21 AM, Magnus Ihse Bursie wrote:
On 2013-10-11 22:27, Daniel D. Daugherty wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot
changes.
Below is the original code review round 0 invite (slightly edite
On 10/15/13 6:21 AM, Magnus Ihse Bursie wrote:
On 2013-10-11 22:27, Daniel D. Daugherty wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pulling a thr
Thanks!
Dan
On 10/15/13 3:33 AM, Erik Joelsson wrote:
Daniel,
Looks good to me.
/Erik
On 2013-10-14 17:52, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that correspond
Nothing like a willing victim^H^H^H^H^H^Htest user of your changes!
Thanks!
Dan
On 10/15/13 12:30 AM, Staffan Larsen wrote:
I've been using this patch while debugging other issues and I now get full
symbols in the debugger without a lot of manual work. So it's a go!
Thanks,
/Staffan
On 11
On 10/15/13 12:07 AM, David Holmes wrote:
On 15/10/2013 1:18 AM, Daniel D. Daugherty wrote:
Thanks for the re-review!
On 10/13/13 7:57 PM, David Holmes wrote:
Hi Dan,
Only further comment I have, and it may well be deferred for future
work, is that we should be able to abstract away the actu
On 10/15/13 12:05 AM, David Holmes wrote:
On 15/10/2013 1:52 AM, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes!
On 2013-10-11 22:27, Daniel D. Daugherty wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pulling a thread on a sweater... so
there are four additional
Daniel,
Looks good to me.
/Erik
On 2013-10-14 17:52, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes! I'll check
I've been using this patch while debugging other issues and I now get full
symbols in the debugger without a lot of manual work. So it's a go!
Thanks,
/Staffan
On 11 okt 2013, at 22:27, Daniel D. Daugherty
wrote:
> Greetings,
>
> I'm ready for code review round 1 of the FDS on MacOS X hotspo
On 15/10/2013 1:18 AM, Daniel D. Daugherty wrote:
Thanks for the re-review!
On 10/13/13 7:57 PM, David Holmes wrote:
Hi Dan,
Only further comment I have, and it may well be deferred for future
work, is that we should be able to abstract away the actual
"extension" used for the "debuginfo" fil
On 15/10/2013 1:52 AM, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes! I'll check into that shortly. Not sure wha
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes! I'll check into that shortly. Not sure what happened here.
I somehow missed/lost two 1-line
Thanks for the re-review!
On 10/13/13 7:57 PM, David Holmes wrote:
Hi Dan,
Only further comment I have, and it may well be deferred for future
work, is that we should be able to abstract away the actual
"extension" used for the "debuginfo" file so that we don't need macosx
conditionals as m
Hi Dan,
Only further comment I have, and it may well be deferred for future
work, is that we should be able to abstract away the actual "extension"
used for the "debuginfo" file so that we don't need macosx conditionals
as much eg one:
if macosx
DEBUGINFO_EXTENSION=dSYM
else
DEBUGINFO_EXTE
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pulling a thread on a sweater... so
there are four additional changed files along with more changes to
many of
15 matches
Mail list logo
