Re: jmx-dev RFR: 8065213 Specify and implement PlatformMBeanProvider for looking for all platform MBeans

2015-02-03 Thread Daniel Fuchs
Looks good to me Shanliang. -- daniel On 03/02/15 14:16, shanliang wrote: Hi, Hope this is last time :) http://cr.openjdk.java.net/~sjiang/JDK-8065213/02/ 1) Mandy Chung wrote: You may want to consider using limited doPrivileged (that can be done in the second phase). Done as in Managem

Re: jmx-dev RFR: 8065213 Specify and implement PlatformMBeanProvider for looking for all platform MBeans

2015-01-28 Thread Daniel Fuchs
Hi Shanliang, This looks good. ManagementFactory.java: line 871: there's a stray debug trace that you probably forgot to remove: 871 System.out.println("\n\n= jsl adding: "+provider); lines 877-885: I believe it would improved readability if the content of the forEachOrd