Re: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

On Mon, 2012-05-21 at 20:28 -0700, [email protected] wrote: > Mark, > > I've created new RFE: > 7170638: enable support for dtrace compatible sdt probes on GNU/Linux > > The patches look good. Thanks. > But I think, it is better to be reviewed by Keith McGuigan, who > originally added

Re: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

On Tue, 2012-05-22 at 14:27 +1000, David Holmes wrote: > Is systemTap part of regular distros these days - in particular in our > build environment? > > I'm just wondering who is going to ensure that these probe entries > compile and run correctly? Note that SDT markers are just that, markers.

Re: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

On Mon, 2012-05-21 at 23:42 -0700, [email protected] wrote: > On 5/21/12 9:27 PM, David Holmes wrote: > It depends on the availability or possible setup of linux machines > with the systemTap. > Some test is needed as well. IcedTea contains a tapset to use them with systemtap and a tests

Re: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

On 22/05/2012 9:11 PM, Mark Wielaard wrote: On Mon, 2012-05-21 at 23:42 -0700, [email protected] wrote: On 5/21/12 9:27 PM, David Holmes wrote: It depends on the availability or possible setup of linux machines with the systemTap. Some test is needed as well. IcedTea contains a tapset

Re: request for codereview, bug 7149528: easy usage of serviceability agent

Yumin, Thanks for doing this! I still wonder if we should support -startsvr in the new launcher, given that we already have a jsadebugd launcher that does exactly that. I don't like having two ways of doing the same thing that we have to support. Either we have jsadebugd or we have "jsa -start

Re: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

On Tue, 2012-05-22 at 21:25 +1000, David Holmes wrote: > On 22/05/2012 9:11 PM, Mark Wielaard wrote: > >But really the SDT markers themselves > > are independent from any program that consumes them (on Solaris you > > would use dtrace, on GNU/Linux you can also use GDB or just list them > > with re

Re: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

On 22/05/2012 9:45 PM, Mark Wielaard wrote: On Tue, 2012-05-22 at 21:25 +1000, David Holmes wrote: On 22/05/2012 9:11 PM, Mark Wielaard wrote: But really the SDT markers themselves are independent from any program that consumes them (on Solaris you would use dtrace, on GNU/Linux you can also us

Re: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux

On Tue, 2012-05-22 at 22:25 +1000, David Holmes wrote: > Do you know what the effect of this is on the static size of libjvm.so? On my system the .note.stapsdt section is d29c bytes. So ~50K. That is for 522 probes (yes, hotspot does define that many) expanded to 547 unique locations. > I think w

Re: request for codereview, bug 7149528: easy usage of serviceability agent

Staffan, Thanks. Will change per your concern. Will remove -startsvr option. CCC not approved yet, it may take long time waiting. Thanks Yumin On 2012/5/22 4:39, Staffan Larsen wrote: Yumin, Thanks for doing this! I still wonder if we should support -startsvr in the new launcher, given t

Re: request for codereview, bug 7149528: easy usage of serviceability agent

Yumin, For the last two years, the average latency to get a finalized ccc request approved has been less than three days. Over 10% of request are approved the same day they come in. The ccc request for 7149528 is in "draft" state. In other words, it has not yet been submitted to the ccc fo

Re: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team

Mandy Chung skrev 2012-05-21 23:13: Erik, I like your idea of trying to define the string constants for the keys to benefit from the compiler checking and catch any issue due to typos at compile time. My review comments below. Your webrev includes other cleanup. While it's good to do the simp

Re: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team

Thanks Erik. I have already downloaded the raw message.properties file from the webrev on 5/16 to proceed with the 7u6 translation. I performed a diff with current webrev, and it consists of mostly deleted resources and 1 renamed key CONNECTION_LOST1 => CONNECTION_LOST. I am fine with the ch

Re: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team

Erik, I approve what you have - please go through and fix the formatting nits. I inlined my comment below and you can follow up them later if needed. On 5/22/2012 12:40 PM, Erik Gahlin wrote: Thanks for reviewing, I got a lot of unused import warnings from the IDE when I changed the Resour

Re: request for codereview, bug 7149528: easy usage of serviceability agent

HI, Second version based on suggestion by Staffan L. http://cr.openjdk.java.net/~minqi/7149528/webrev.1 Thanks Yumin On 2012/5/22 4:39, Staffan Larsen wrote: Yumin, Thanks for doing this! I still wonder if we should support -startsvr