Re: Review Request: 7193339 Prepare system classes be defined by a non-null module loader

On Aug 25, 2012, at 12:57 AM, Mandy Chung wrote: > On 8/24/2012 3:44 PM, David Holmes wrote: >> My other query with these changes is whether we are certain that using the >> specified loader rather than the boot loader will always be correct. > > Yes I'm to my best knowledge but I'm looking t

Re: [PATCH FOR REVIEW] 7194035: update tests for upcoming changes for jtreg

Jon - does ${TESTCLASSPATH:-${TESTCLASSES}} need to use $PS so that the path separate is correct on Windows? -Alan. Alan, The expression as written does not need $PS because the syntax being used is ${A:-${B}} where the :- is shell syntax for providing a default if not set. If I had sugges

Re: [PATCH FOR REVIEW] 7194035: update tests for upcoming changes for jtreg

On 27/08/2012 14:33, Jonathan Gibbons wrote: Alan, The expression as written does not need $PS because the syntax being used is ${A:-${B}} where the :- is shell syntax for providing a default if not set. If I had suggested ${A}:${B} then $PS would be more appropriate. Okay, I was mis-readi

hg: jdk8/tl/langtools: 7192068: (javac) provide a way for IDEs to produce Enclosing Method attributes.

Changeset: c9749226cdde Author:ksrini Date: 2012-08-27 07:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c9749226cdde 7192068: (javac) provide a way for IDEs to produce Enclosing Method attributes. Reviewed-by: jjg Contributed-by: [email protected] ! src/share/c

com.sun.management.VMOption.toString()

Hi, Just found little misprint in com.sun.management.VMOption.toString() It returns "...(read-only)" if writable is true and "...(read-write)" otherwise. Here is a patch: diff -r 156ab3c38556 src/share/classes/com/sun/management/VMOption.java --- a/src/share/classes/com/sun/management/VMOption.j

Re: com.sun.management.VMOption.toString()

Dmytro, Thank you fro catching it. Yes, we need a CR. I'll file it tomorrow and sponsor the commit. -Dmitry On 2012-08-27 19:59, Dmytro Sheyko wrote: > Hi, > > Just found little misprint in com.sun.management.VMOption.toString() > It returns "...(read-only)" if writable is true and "...(read-wr

hg: hsx/hotspot-rt/hotspot: 22 new changesets

Changeset: aaf61e68b255 Author:johnc Date: 2012-08-06 12:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/aaf61e68b255 6818524: G1: use ergonomic resizing of PLABs Summary: Employ PLABStats instances to record information about survivor and old PLABs, and use the

Re: [PATCH FOR REVIEW] 7194035: update tests for upcoming changes for jtreg

Jon, The fix looks fine. Thanks, Serguei On 8/24/12 4:51 PM, Jonathan Gibbons wrote: Currently, jtreg incorrectly confuses the concept of the /directory/ in which the test's class will be written with the /classpath/ used to locate all of the test's classes, including any library classes. It

hg: jdk8/tl/corba: 3 new changesets

Changeset: 63aeb7a2472f Author:katleman Date: 2012-08-16 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/63aeb7a2472f Added tag jdk8-b52 for changeset 80689ff9cb49 ! .hgtags Changeset: 16c82fc74695 Author:katleman Date: 2012-08-23 12:27 -0700 URL: http

hg: jdk8/tl/langtools: 3 new changesets

Changeset: d3d0b9cd76e0 Author:katleman Date: 2012-08-16 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d3d0b9cd76e0 Added tag jdk8-b52 for changeset 1d2db0e5eabc ! .hgtags Changeset: 9cf72631baf5 Author:katleman Date: 2012-08-23 12:27 -0700 URL:

hg: jdk8/tl/jaxws: 2 new changesets

Changeset: 8a35fd644d3c Author:katleman Date: 2012-08-16 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8a35fd644d3c Added tag jdk8-b52 for changeset f62bc618122e ! .hgtags Changeset: 91970935926a Author:katleman Date: 2012-08-23 12:27 -0700 URL: http

hg: jdk8/tl/jaxp: 3 new changesets

Changeset: 2c566f25c39f Author:katleman Date: 2012-08-16 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2c566f25c39f Added tag jdk8-b52 for changeset bd3c00d57614 ! .hgtags Changeset: 7dd81ccb7c11 Author:katleman Date: 2012-08-23 12:27 -0700 URL: http:

hg: jdk8/tl/hotspot: 12 new changesets

Changeset: ef437ea56651 Author:amurillo Date: 2012-08-03 13:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ef437ea56651 7189086: new hotspot build - hs24-b20 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1d7922586cf6 Author:twisti Date: 2012-07-24 1

hg: jdk8/tl/jdk: 14 new changesets

Changeset: 05e5ce861a58 Author:jrose Date: 2012-07-12 00:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05e5ce861a58 7153157: ClassValue.get does not return if computeValue calls remove Summary: Track intermediate states more precisely, according to spec. Reviewed-by: twis

RFR: 6879063: SA should use hsdis for disassembly

Hi, all Can I have you code review of 6879063: SA should use hsdis for disassembly http://cr.openjdk.java.net/~minqi/6879063 The SA has Java based disassemblers for x86 and sparc but amd64. Instead of porting to amd64 we should switch ove

Re: RFR: 6879063: SA should use hsdis for disassembly

On Aug 27, 2012, at 2:07 PM, Yumin Qi wrote: > Hi, all > > Can I have you code review of > 6879063: SA should use hsdis for disassembly > > http://cr.openjdk.java.net/~minqi/6879063 > > The SA has Java based disassemblers for x86 and sparc but amd64. Instead > of porting to amd64

Re: RFR: 6879063: SA should use hsdis for disassembly

Thanks. I will modify like that. By the way, missed one file, will add and resend out the modified version. make/solaris/makefiles/sa.make Thanks Yumin On 2012/8/27 14:43, Christian Thalinger wrote: On Aug 27, 2012, at 2:07 PM, Yumin Qi wrote: Hi, all Can I have you code review of 68