Re: RFR: 6879063: SA should use hsdis for disassembly

2012-09-19 Thread Staffan Larsen
Looks good! /Staffan On 18 sep 2012, at 19:19, [email protected] wrote: > Again, it is OK now. > > Thanks > Yumin > > On 9/18/2012 9:27 AM, [email protected] wrote: >> Sorry, please ignore this one, since the make files not listed. Will send >> again. >> >> Thanks >> Yumin >> >> On 9/18

Re: Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-19 Thread Alan Bateman
On 18/09/2012 23:05, Mandy Chung wrote: Eamonn, I filed a RFE that the serviceability team can follow up your suggestion: 7199353: Allow ConstructorProperties annotation from any package Alan - I modified the fix to throw InternalError instead of AssertionError. It's great to have this stat

Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently

2012-09-19 Thread Jaroslav Bachorik
The ExecutorTest.java fails in cca. 30-40% of runs with NPE in the part testing IIOP connection. The failure is caused by the JMX notification processing - ideally, once the RMIConnector is closed the client JMX notification processing should quit as well and should not try to fetch any more notif

Re: Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently

2012-09-19 Thread Alan Bateman
On 19/09/2012 13:39, Jaroslav Bachorik wrote: The ExecutorTest.java fails in cca. 30-40% of runs with NPE in the part testing IIOP connection. The failure is caused by the JMX notification processing - ideally, once the RMIConnector is closed the client JMX notification processing should quit as

Re: Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently

2012-09-19 Thread Jaroslav Bachorik
On Wed 19 Sep 2012 03:06:05 PM CEST, Alan Bateman wrote: > On 19/09/2012 13:39, Jaroslav Bachorik wrote: >> The ExecutorTest.java fails in cca. 30-40% of runs with NPE in the part >> testing IIOP connection. >> >> The failure is caused by the JMX notification processing - ideally, once >> the RMICo

Re: Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently

2012-09-19 Thread Alan Bateman
On 19/09/2012 14:16, Jaroslav Bachorik wrote: : Not really - the NPE is thrown within the IIOP generated TIE class. I really don't feel like sticking my fingers into the CORBA code. The application code just receives the NPE. For the record I think it would be better to address the real issue

hg: jdk8/tl/jdk: 4722265: (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable

2012-09-19 Thread chris . hegarty
Changeset: 5d064862376d Author:jgish Date: 2012-09-19 08:52 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d064862376d 4722265: (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable Summary: add usage note to AbstractStringBuilder ensureCapacity()

hg: jdk8/tl/jdk: 7199500: Minor typo in AbstractStringBuilder.java header

2012-09-19 Thread chris . hegarty
Changeset: 27182d84a244 Author:chegar Date: 2012-09-19 14:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27182d84a244 7199500: Minor typo in AbstractStringBuilder.java header Reviewed-by: coffeys ! src/share/classes/java/lang/AbstractStringBuilder.java

Re: Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-19 Thread Mandy Chung
On 9/19/2012 2:01 AM, Alan Bateman wrote: On 18/09/2012 23:05, Mandy Chung wrote: Eamonn, I filed a RFE that the serviceability team can follow up your suggestion: 7199353: Allow ConstructorProperties annotation from any package Alan - I modified the fix to throw InternalError instead of

Re: RFR: 6879063: SA should use hsdis for disassembly

2012-09-19 Thread Yumin Qi
Thanks. Now after updated with new changes with metadata, it is not compilable, need to do some revision. --Yumin On 9/19/2012 12:49 AM, Staffan Larsen wrote: Looks good! /Staffan On 18 sep 2012, at 19:19, [email protected] wrote: Again, it is OK now. Thanks Yumin On 9/18/2012 9:27

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-09-19 Thread yumin . qi
Changeset: 1cb8583c3da8 Author:minqi Date: 2012-09-18 10:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1cb8583c3da8 7191786: retransformClasses() does not pass in LocalVariableTypeTable of a method Summary: JVMTI REtruncformClasses must support LocalVariableTy

hg: hsx/hotspot-rt/hotspot: 5 new changesets

2012-09-19 Thread john . coomes
Changeset: 989cf02ca531 Author:ihse Date: 2012-09-17 11:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/989cf02ca531 7172012: Make test-in-build an option (Queens) Reviewed-by: ohair, dholmes ! make/bsd/Makefile ! make/defs.make ! make/linux/Makefile ! make/sola