Changeset: 775b0050144a
Author:chegar
Date: 2012-12-13 09:55 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/775b0050144a
8004925: java/net/Socks/SocksV4Test.java failing on all platforms
Reviewed-by: alanb, dsamersoff
! test/java/net/Socks/SocksV4Test.java
Changeset: 682d2d3ccff5
Author:chegar
Date: 2012-12-13 14:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/682d2d3ccff5
8004675: Inet6Address.getHostAddress should use string scope identifier where
available
Summary: ...and some minor stylistic cleanup
Reviewed-by: khazra,
Changeset: c97618a3c8c2
Author:juh
Date: 2012-12-13 09:35 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c97618a3c8c2
7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently
Reviewed-by: vinnie, wetmore
! test/ProblemList.txt
! test/sun/security/pkcs11/ec/TestE
Changeset: ae5d04dbacd6
Author:chegar
Date: 2012-12-13 14:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae5d04dbacd6
8003890: corelibs test scripts should pass TESTVMOPTS
Reviewed-by: chegar, alanb
Contributed-by: Mark Sheppard
! test/com/oracle/net/sanity.sh
! test/com
Greetings,
I'm sponsoring this code review request from Ron Durbin. This change
is targeted at JDK8/HSX-25 in the RT_Baseline repo. Please make sure
you include Ron on any e-mail replies since he is not yet on the
OpenJDK aliases.
Dan
Intro:
This set of changes removes the makefile support fo
Dan,
It is nice fix and simplified many places.
Just one minor comment:
make/bsd/makefiles/dtrace.make
41 #LIBJVM_DB = libjvm_db.dylib
42 LIBJVM_DB = libjvm_db.dylib
45 #LIBJVM_DTRACE = libjvm_dtrace.dylib
46 LIBJVM_DTRACE = libjvm_dtrace.dylib
The lines #41 and #45 can be removed
Forgot to mention the testing:
These changes were tested with a full JPRT-hotspotwest job.
Verified that the JPRT bundles no longer contain _g files:
$ pwd
/net/prt-archiver.us.oracle.com/data/jprt/archive/2012/12/2012-12-13-030336.ddaugher.7153050_exp/bundles
$ for zfile in *.zip; do
> echo "
Serguei,
Thanks for the fast review!
I could swear that Ron had removed lines 41 and 45 in an earlier
version. Sigh... Will be fixed.
Dan
On 12/13/12 1:22 PM, [email protected] wrote:
Dan,
It is nice fix and simplified many places.
Just one minor comment:
make/bsd/makefiles/dtrac
Thx again
-Original Message-
From: Daniel D. Daugherty
Sent: Thursday, December 13, 2012 1:51 PM
To: build-dev; [email protected];
[email protected]; Ron Durbin
Subject: Re: code review request for 7153050 remove crufty '_g' support
Serguei,
Thanks
You are correct
Thx Ron
From: Serguei Spitsyn
Sent: Thursday, December 13, 2012 1:23 PM
To: Daniel Daugherty
Cc: build-dev; [email protected];
[email protected]; Ron Durbin
Subject: Re: code review request for 7153050 remove crufty '_g' support
Just for the record: I have reviewed all of Ron's changes and I approve
them.
Dan
On 12/13/12 11:53 AM, Daniel D. Daugherty wrote:
Greetings,
I'm sponsoring this code review request from Ron Durbin. This change
is targeted at JDK8/HSX-25 in the RT_Baseline repo. Please make sure
you include
Trivial update of max classfile version to 52.
http://cr.openjdk.java.net/~dholmes/8003632/webrev/
Pushing through tl/jdk
Thanks,
David
Adding back in the other OpenJDK aliases...
Ron's e-mail has gone off-line (no e-mail for him since 1440 MT)...
Coleen,
Thanks for the review!
This bug (7153050) is just for the Makefile changes so that the
reviews are more focused. Ron has separate bugs for the other parts
of the hotspot repo
Trying again... now my e-mail client is complaining...
Adding back in the other OpenJDK aliases...
Ron's e-mail has gone off-line (no e-mail for him since 1440 MT)...
Coleen,
Thanks for the review!
This bug (7153050) is just for the Makefile changes so that the
reviews are more focused. Ron h
+1
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
Sent from my iPhone
On Dec 13, 2012, at 6:30 PM, David Holmes wrote:
> Trivial update of max classfile version to 52.
>
> http:/
I am back and Dan has It correct (JDK-8005044)
-Original Message-
From: Daniel D. Daugherty
Sent: Thursday, December 13, 2012 4:32 PM
To: [email protected]; build-dev;
[email protected]
Subject: Re: code review request for 7153050 remove crufty '_g' s
Changeset: 376d6c1b49e5
Author:jfranck
Date: 2012-12-03 11:16 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/376d6c1b49e5
8001114: Container annotation is not checked for semantic correctness
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/code/Annotations.jav
Looks good to me.
I didn't know about this file and so I was interested in finding out
more. This file classfile_constants.h doesn't look like a header file
exported from the hotspot repo (I couldn't find it). It's used by hprof
and the old verifier (jdk/src/share/native/common/check_code.h
Changeset: 8d7323a9d8ed
Author:dholmes
Date: 2012-12-13 21:18 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d7323a9d8ed
8003632: HPROF class file version java.lang.RuntimeException errors
Reviewed-by: mchung, lancea
! src/share/javavm/export/classfile_constants.h
On 14/12/2012 12:03 PM, Mandy Chung wrote:
Looks good to me.
Thanks Mandy.
FYI tested with nsk/hprof suite
I didn't know about this file and so I was interested in finding out
more. This file classfile_constants.h doesn't look like a header file
exported from the hotspot repo (I couldn't fin
This file was added by me, to the jdk repo, mostly for reading class files.
But as I recall (it was a while ago) the idea was that this file would describe
the classfile format for the jdk being released.
As I recall, the hotspot sources never exported anything like this, certainly
not something
21 matches
Mail list logo
