Looks good!
Thanks,
/Staffan
> On 23 mar 2015, at 20:20, Jaroslav Bachorik
> wrote:
>
> On 23.3.2015 13:44, Staffan Larsen wrote:
>> Looks good, but please print the exception at line 118 in
>> AttachWithStalePidFile.java.
>
> Hm, like this http://cr.openjdk.java.net/~jbachorik/8024055/webre
Jaroslav,
test/serviceability/attach/AttachWithStalePidFile.java
A question:
101 private static void waitForTargetReady(Process target) throws
IOException {
102 BufferedReader br = new BufferedReader(new
InputStreamReader(target.getInputStream()));
103 String line = br.readLine(
Hi Serguei,
On 24.3.2015 10:22, serguei.spit...@oracle.com wrote:
Jaroslav,
test/serviceability/attach/AttachWithStalePidFile.java
A question:
101 private static void waitForTargetReady(Process target) throws
IOException {
102 BufferedReader br = new BufferedReader(new
InputStrea
Thank you for explanation, Jaroslav!
Would it make sense to add short comment before the loop?
No need to re-review.
Thanks,
Serguei
On 3/24/15 2:44 AM, Jaroslav Bachorik wrote:
Hi Serguei,
On 24.3.2015 10:22, serguei.spit...@oracle.com wrote:
Jaroslav,
test/serviceability/attach/AttachWit
Could the reviewers, please, have a look at the proposed changes below?
In addition, we are going to make a change to the TEST.ROOT file as indicated
by Staffan in the mail below.
Do you think the changes (plus the one-line change to the TEST.ROOT) can be
pushed into the jdk?
Best regards,
Al
Notifying hotspot-dev as well.
// Katja
On 03/24/2015 11:48 AM, Alexander Kulyakhtin wrote:
Could the reviewers, please, have a look at the proposed changes below?
In addition, we are going to make a change to the TEST.ROOT file as indicated
by Staffan in the mail below.
Do you think the c
This looks good, thank you for making these changes! A couple of
comments that I don't feel need another webrev but should be fixed
before pushing.
- copyrights on all the tests need to be updated
- the following tests have a blank comment line before the new
"@modules" line that co
Lois,
Thank you very much for your findings.
We are going to remove the blank comments as you have suggested. If possible,
however, we would prefer to pursue the copyrights issue under a different CR as
this is another and not strictly related bulk change, which, probably, can be
best achieve
Hi Alex,
I assume you've run all the tests and that they are still passing?
The @module changes looks good. As Lois pointed out, you need to update the
copyrights and this should be done as part of this change.
Thanks,
Christian
-Original Message-
From: serviceability-dev [mailto:ser
Hi Christian,
Yes, I have run the tests and they do pass the same as before.
According to your and Lois' comments I'm going to fix the copyrights and
resubmit the webrev as soon as I'm done.
Best regards,
Alex
- Original Message -
From: christian.tornqv...@oracle.com
To: alexander.kuly
10 matches
Mail list logo
