Re: JDK 9 RFR of JDK-8077923: Add missing doclint in javax.management

2015-04-16 Thread Daniel Fuchs
Hi Joe, Looks good to me! +1 for doclint :-) best regards, -- daniel On 4/16/15 4:47 AM, joe darcy wrote: Hello, While trying to turn on doclint checking in the build on more modules, it came to my attention that various parts of the javax.management package are missing javadoc. Please re

RFR(S): JDK-8074146 jdb has succeded to read an unreadable file

2015-04-16 Thread Dmitry Samersoff
Everybody, Please review: http://cr.openjdk.java.net/~dsamersoff/JDK-8074146/webrev.01/ With current testing infrastructure it's hard to make file unreadable on all platforms. From the other side codepath triggered by file open error is covered by the case: "Read a directory - verify the read

Re: RFR(S): JDK-8074146 jdb has succeded to read an unreadable file

2015-04-16 Thread Erik Gahlin
Looks good Erik Dmitry Samersoff skrev 2015-04-16 17:59: Everybody, Please review: http://cr.openjdk.java.net/~dsamersoff/JDK-8074146/webrev.01/ With current testing infrastructure it's hard to make file unreadable on all platforms. From the other side codepath triggered by file open er

Re: RFR (S) 8073705: more performance issues in class redefinition

2015-04-16 Thread Daniel D. Daugherty
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8073705-JVMTI-redefscale2.1/ src/share/vm/classfile/javaClasses.hpp No comments. src/share/vm/classfile/javaClasses.cpp No comments. src/share/vm/oops/cpCache.hpp No comments. src/share/vm/oops/cpCache.cpp No comments

Re: RFR(S): JDK-8074146 jdb has succeded to read an unreadable file

2015-04-16 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 16 apr 2015, at 17:59, Dmitry Samersoff > wrote: > > Everybody, > > Please review: > > http://cr.openjdk.java.net/~dsamersoff/JDK-8074146/webrev.01/ > > With current testing infrastructure it's hard to make file unreadable > on all platforms. > > From the