RFR(XS): 8132094: Mark intermittently failuring core-svc tests

2015-07-22 Thread Yekaterina Kantserova
Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8132094 webrev: http://cr.openjdk.java.net/~ykantser/8132094/webrev.00 Thanks, Katja

RFR (XXS): JDK-8131783 : Put LowMemoryTest.java in quarantine

2015-07-22 Thread [email protected]
Hi, Could you please review this very light fix: bug: https://bugs.openjdk.java.net/browse/JDK-8131783 webrev: http://cr.openjdk.java.net/~olagneau/8131783/webrev.00/ We first quarantine the test. We will then add tracing information to help diagnosing the problem (https://bugs.openjdk.java.n

RFR 8087315: SIGBUS error in nsk/jvmti/RedefineClasses/StressRedefine

2015-07-22 Thread Coleen Phillimore
Summary: Need to get source_file_name from the_class's constant pool not previous version constant pool open webrev at http://cr.openjdk.java.net/~coleenp/8087315.01/ bug link https://bugs.openjdk.java.net/browse/JDK-8087315 Tested with added test (yay!), RBT (remote build and test), vm.redefi

os::current_thread_id on Linux

2015-07-22 Thread Jeremy Manson
Hey folks, os::current_thread_id on Linux now maps to pthread_self. The problem with pthread_self is that it only makes sense in the context of the running process. When it is written out to the log (as it is in several places), there really isn't a way (AFAICT) for the user to map it back to an

Re: os::current_thread_id on Linux

2015-07-22 Thread Dmitry Samersoff
Jeremy, Please take in account that gettid() returns a value that unique for the *running threads* across a system. I.e. for long running java process gettid() can return a value that was previously assigned to one of dead threads. -Dmitry On 2015-07-22 21:22, Jeremy Manson wrote: > Hey folks,

Re: os::current_thread_id on Linux

2015-07-22 Thread Jeremy Manson
Example of where this would help: Current output of SIGQUIT: "C1 CompilerThread3" #8 daemon prio=9 os_prio=0 tid=0x7f0890247800 nid=0x2e3d waiting on condition [0x] java.lang.Thread.State: RUNNABLE "C2 CompilerThread2" #7 daemon prio=9 os_prio=0 tid=0x7f0890245000 nid=

Re: os::current_thread_id on Linux

2015-07-22 Thread Rainer Jung
Am 22.07.2015 um 20:52 schrieb Jeremy Manson: Example of where this would help: Current output of SIGQUIT: "C1 CompilerThread3" #8 daemon prio=9 os_prio=0 tid=0x7f0890247800 nid=0x2e3d waiting on condition [0x] java.lang.Thread.State: RUNNABLE "C2 CompilerThread2" #7 da

Re: os::current_thread_id on Linux

2015-07-22 Thread Martin Buchholz
It would be nice if even internal hotspot APIs had clear specs. All we have now is: // thread id on Linux/64bit is 64bit, on Windows and Solaris, it's 32bit static intx current_thread_id(); pthread_self() is documented as being an opaque value that cannot necessarily be stored in a native int

Re: os::current_thread_id on Linux

2015-07-22 Thread Jeremy Manson
Based on the feedback, this seems to be a good idea, approximately. Coleen would have sponsored, but she's going on vacation. Anyone else feel like sponsoring? Jeremy On Wed, Jul 22, 2015 at 11:22 AM, Jeremy Manson wrote: > Hey folks, > > os::current_thread_id on Linux now maps to pthread_sel

Re: RFR (XXS): JDK-8131783 : Put LowMemoryTest.java in quarantine

2015-07-22 Thread [email protected]
Hi Olivier, The fix is good. Thanks, Serguei On 7/22/15 9:25 AM, [email protected] wrote: Hi, Could you please review this very light fix: bug: https://bugs.openjdk.java.net/browse/JDK-8131783 webrev: http://cr.openjdk.java.net/~olagneau/8131783/webrev.00/ We first quarantine the t

Re: RFR 8087315: SIGBUS error in nsk/jvmti/RedefineClasses/StressRedefine

2015-07-22 Thread Daniel D. Daugherty
On 7/22/15 11:22 AM, Coleen Phillimore wrote: Summary: Need to get source_file_name from the_class's constant pool not previous version constant pool open webrev at http://cr.openjdk.java.net/~coleenp/8087315.01/ src/share/vm/classfile/javaClasses.cpp So in the new code, you avoid the use

Re: RFR 8087315: SIGBUS error in nsk/jvmti/RedefineClasses/StressRedefine

2015-07-22 Thread Coleen Phillimore
Dan, Thank you again for the quick code review. On 7/22/15 8:57 PM, Daniel D. Daugherty wrote: On 7/22/15 11:22 AM, Coleen Phillimore wrote: Summary: Need to get source_file_name from the_class's constant pool not previous version constant pool open webrev at http://cr.openjdk.java.net/~co

Re: os::current_thread_id on Linux

2015-07-22 Thread David Holmes
On 23/07/2015 8:01 AM, Jeremy Manson wrote: Based on the feedback, this seems to be a good idea, approximately. Coleen would have sponsored, but she's going on vacation. Anyone else feel like sponsoring? Hold up a minute! :) There are different notions of "native thread id" that exist. First

Re: os::current_thread_id on Linux

2015-07-22 Thread Jeremy Manson
Hey David, Thanks for the offer of sponsorship. My goal here is really to make the log output on Linux usable. I want to be able to map the log output back to an actual thread. I don't think it really matters to users if the API consistently means "kernel thread ID" or "threading API thread ID"

Re: os::current_thread_id on Linux

2015-07-22 Thread David Holmes
On 23/07/2015 3:15 PM, Jeremy Manson wrote: Hey David, Thanks for the offer of sponsorship. My goal here is really to make the log output on Linux usable. I want to be able to map the log output back to an actual thread. I don't think it really matters to users if the API consistently means "

Re: RFR 8087315: SIGBUS error in nsk/jvmti/RedefineClasses/StressRedefine

2015-07-22 Thread [email protected]
Coleen, The fix looks good in general. There is one more place where the same may need to be fixed. It is in the function java_lang_StackTraceElement::create (): 1911 // Fill in source file name and line number. 1912 // Use specific ik version as a holder since the mirror might 1913