Hello,
Following is the link with all the comments incorporated, kindly review the
same.
http://cr.openjdk.java.net/~jbachorik/sponsorship/6659240/webrev.02/
-Sharath Ballal
-Original Message-
From: Daniel Fuchs
Sent: Thursday, January 07, 2016 7:43 PM
To: Sharath Ballal; Jaroslav
Hi,
This looks good to me now. Thanks for the update!
best regards,
-- daniel
On 1/18/16 10:23 AM, Sharath Ballal wrote:
Hello,
Following is the link with all the comments incorporated, kindly review the
same.
http://cr.openjdk.java.net/~jbachorik/sponsorship/6659240/webrev.02/
-Sharath B
On 18.1.2016 10:23, Sharath Ballal wrote:
Hello,
Following is the link with all the comments incorporated, kindly review the
same.
http://cr.openjdk.java.net/~jbachorik/sponsorship/6659240/webrev.02/
Thumbs up! bd
-Sharath Ballal
-Original Message-
From: Daniel Fuchs
Sent: Thur
Yasumasa,
1. It might be better to have one jcmd to run both java and native java
agent. If agent library name ends with ".jar" we can assume it's java agent.
2. Please get rid of malloc/free and check _libpath.value() for NULL at
ll. 295 and below.
if (_libpath.value() == NULL) {
error ...
Hi,
New webrev: http://cr.openjdk.java.net/~aeriksso/8129419/webrev.02/hotspot/
Write_internal handles writes less than len, and EINTR.
EINTR is taken care of by os::write, but to use it I had to remove an
assert from the solaris os::write, which checked that a JavaThread was
in_native. Since
Андреас,
481: It's better to declare n as ssize_t and remove cast at 488
Looks good for me!
-Dmitry
On 2016-01-18 14:42, Andreas Eriksson wrote:
> Hi,
>
> New webrev: http://cr.openjdk.java.net/~aeriksso/8129419/webrev.02/hotspot/
>
> Write_internal handles writes less than len, and EINTR.
>
I believe I then have to cast it to size_t at 496, 497 and 498?
I'm not sure how write works in regards to returning ssize_t vs a size_t
length.
Maybe I should change it back to checking for return value < 0 (instead
of only checking for OS_ERR), and then keep 'n' as ssize_t?
- Andreas
On 201
Andreas,
On 2016-01-18 15:26, Andreas Eriksson wrote:
> I believe I then have to cast it to size_t at 496, 497 and 498?
I hope not.
> I'm not sure how write works in regards to returning ssize_t vs a size_t
> length.
It's a tricky part.
The maximum number of bytes that could be actually writte
On 2016-01-18 13:58, Dmitry Samersoff wrote:
Andreas,
On 2016-01-18 15:26, Andreas Eriksson wrote:
I believe I then have to cast it to size_t at 496, 497 and 498?
I hope not.
I'm not sure how write works in regards to returning ssize_t vs a size_t
length.
It's a tricky part.
The maximum
Hi Dmitry,
1. It might be better to have one jcmd to run both java and native java
agent. If agent library name ends with ".jar" we can assume it's java agent.
Okay, I'll try it.
if (_libpath.value() == NULL) {
error ...
}
I will add it.
However, I note you that _libpath is given manda
Andreas,
Thumbs up! (Reviewed)
-Dmitry
On 2016-01-18 16:07, Andreas Eriksson wrote:
>
>
> On 2016-01-18 13:58, Dmitry Samersoff wrote:
>> Andreas,
>>
>> On 2016-01-18 15:26, Andreas Eriksson wrote:
>>> I believe I then have to cast it to size_t at 496, 497 and 498?
>> I hope not.
>>
>>> I'm no
Thanks!
On 2016-01-18 14:10, Dmitry Samersoff wrote:
Andreas,
Thumbs up! (Reviewed)
-Dmitry
On 2016-01-18 16:07, Andreas Eriksson wrote:
On 2016-01-18 13:58, Dmitry Samersoff wrote:
Andreas,
On 2016-01-18 15:26, Andreas Eriksson wrote:
I believe I then have to cast it to size_t at 496, 4
Yasumasa,
> Can we use VLA (Variable Length Arrays) ?
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.5.0
Thread model: posix
Compiles it just fine.
-Dmitry
On 2016-01-18 16:09, Yasumasa Suenaga wrote:
> Hi Dmitry,
>
>> 1. It might be better to
Hi Dmitry,
Could you please review this patch and the below patch which are related JHSDB?
http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-January/018656.html
Thanks in advance,
Yuji
2016-01-06 3:08 GMT+09:00 Dmitry Samersoff :
> Yuji,
>
> I'm on vacation till Jan 10, answer you n
I uploaded webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8147388/webrev.02/
This webrev can load java agent and native agent through JVMTI.agent_load dcmd.
Could you review again?
Thanks,
Yasumasa
On 2016/01/18 22:20, Dmitry Samersoff wrote:
Yasumasa,
Can we use VLA (Variable Length
Historical note - I never liked having a reaper thread for each
subprocess, but no other reliable implementation is known. Given the
potential for many reaper threads, I at least wanted to keep the
memory waste low.
On Wed, Jan 13, 2016 at 2:25 AM, cheleswer sahu
wrote:
> + Th
Yuji
Looks good for me.
Are you a committer? If yes, please prepare a changeset. I'll sponsor
the push.
-Dmitry
On 2015-12-15 11:23, KUBOTA Yuji wrote:
> Hi all,
>
> When I ran HSDB by jhsdb on CLI i.e. without x11 display, HSDB could
> not terminate after throwing HeadlessException.
>
> HSDB
On 18/01/2016 11:20 PM, Dmitry Samersoff wrote:
Yasumasa,
Can we use VLA (Variable Length Arrays) ?
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.5.0
Thread model: posix
Compiles it just fine.
Are we using variable length arrays anywhere e
David,
On 2016-01-18 23:47, David Holmes wrote:
> On 18/01/2016 11:20 PM, Dmitry Samersoff wrote:
>> Yasumasa,
>>
>>> Can we use VLA (Variable Length Arrays) ?
>>
>> Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
>> Target: x86_64-apple-darwin14.5.0
>> Thread model: posix
>>
>>
On 19/01/2016 7:26 AM, Dmitry Samersoff wrote:
David,
On 2016-01-18 23:47, David Holmes wrote:
On 18/01/2016 11:20 PM, Dmitry Samersoff wrote:
Yasumasa,
Can we use VLA (Variable Length Arrays) ?
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin1
Dmitry
Thank you for your review!
Sorry, I do not have any role of OpenJDK yet. So I can't upload webrev.
I will send a request for becoming Author after pushing these patches :)
Thanks,
Yuji
2016-01-19 2:42 GMT+09:00 Dmitry Samersoff :
> Yuji
>
> Looks good for me.
>
> Are you a committer? If
Hi David, Dmitry,
This reports they are not available in Visual Studio C++:
https://msdn.microsoft.com/en-us/library/zb1574zs.aspx
Thanks David,
Should I use malloc/free at this patch?
(I think that we should NOT use VLA because VS2015 does not support it.)
Thanks,
Yasumasa
On 2016/01/19
On 19/01/2016 9:13 AM, Yasumasa Suenaga wrote:
Hi David, Dmitry,
This reports they are not available in Visual Studio C++:
https://msdn.microsoft.com/en-us/library/zb1574zs.aspx
Thanks David,
Should I use malloc/free at this patch?
I think so - but you need to check for a NULL from malloc
23 matches
Mail list logo
