Re: RFR(S): JDK-8148104 HSDB could not terminate when launched on CLI.

2016-01-26 Thread Dmitry Samersoff
Yuji, I think both changes are good so I add this patch to webrev. see: http://cr.openjdk.java.net/~dsamersoff/sponsorship/kubota.yuji/JDK-8148104/webrev.02/ -Dmitry On 2016-01-25 13:57, KUBOTA Yuji wrote: > Hi Dmitry and Jaroslav, > > 2016-01-25 18:11 GMT+09:00 Jaroslav Bachorik : >> On 23.

Re: RFR(S): JDK-8148104 HSDB could not terminate when launched on CLI.

2016-01-26 Thread Jaroslav Bachorik
On 26.1.2016 11:54, Dmitry Samersoff wrote: Yuji, I think both changes are good so I add this patch to webrev. see: http://cr.openjdk.java.net/~dsamersoff/sponsorship/kubota.yuji/JDK-8148104/webrev.02/ Thanks Yuji, Dmitry! Thumbs up! -JB- -Dmitry On 2016-01-25 13:57, KUBOTA Yuji wrote

RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

2016-01-26 Thread Dmitry Samersoff
Everybody, Please review an RFE http://cr.openjdk.java.net/~dsamersoff/JDK-8148315/webrev.01/ This fix adds basic LingeredApp based reproducer (and template for more sophisticated reproducers) to debug JDI and underlying JVMTI issues. -Dmitry -- Dmitry Samersoff Oracle Java development team,

Re: RFR(S, TESTONLY): JDK-8148315 Create a basic reproducer for JDI issues

2016-01-26 Thread Staffan Larsen
Can you explain more? There is very little information here or in the bug about what problem you are trying to solve. Why aren’t the current JDI tests (jdk/test/com/sun/jdi) sufficient? I have not read your code, and I would like more background before I do so. > On 26 jan. 2016, at 22:53, Dmit

Re: RFR: 8147348: LogTagLevelExpression not properly initialized in configure_stdout

2016-01-26 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 21 jan. 2016, at 11:42, Marcus Larsson wrote: > > Hi, > > Please review the following patch to fix an initialization error in > LogTagLevelExpression. If not using the parse() method (as is the case in > LogConfiguration::configure_stdout) instances of the c