Re: RFR (S): 8137165: Tests fail in SR_Handler because thread is not VMThread or JavaThread

2016-03-15 Thread David Holmes
Thanks Kim - pushing now. In a way this does "fix" the original problem as we should no longer get to that particular assert :) Robbin: you don't have an OpenJDK user name yet! So I couldn't give you reviewing credit. :( David - On 15/03/2016 4:48 PM, Kim Barrett wrote: On Mar 15, 201

Re: Check core dumping is enabled when set CrashOnOutOfMemoryError

2016-03-15 Thread KUBOTA Yuji
Thank David for taking time. And sorry for misunderstand about the purpose of each VM options. 2016-03-15 9:38 GMT+09:00 David Holmes : > Again clarify what you mean by this? Given CreateCoredumpOnCrash is usually > on this would produce warning messages in many execution contexts where core > dum

Re: RFR: 8146879: Add option for handling existing log files in UL

2016-03-15 Thread Marcus Larsson
On 03/14/2016 04:06 PM, Dmitry Samersoff wrote: Marcus, 1. Most of log analyzing tools utilize the fact that filesystem returns files in alphabetical order or uses scandir()/alphasort() So good log rotation strategy is log, log.001, log.002, log.003 etc where "log" is current one and log.MAX_C

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-15 Thread Erik Joelsson
Hello, New webrev where "closed" is replaced with "custom". http://cr.openjdk.java.net/~erikj/8151653/webrev.hotspot.02/ Also, to clarify the refactoring of trace.xml here on the list too. I needed to create 2 separate entry points, one open and one closed trace.xml. The way xinclude works, I

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-15 Thread David Holmes
Thanks Erik! Looks okay to me. David On 15/03/2016 8:36 PM, Erik Joelsson wrote: Hello, New webrev where "closed" is replaced with "custom". http://cr.openjdk.java.net/~erikj/8151653/webrev.hotspot.02/ Also, to clarify the refactoring of trace.xml here on the list too. I needed to create 2 se

Re: JDK-8148659: Add all option to JSnap

2016-03-15 Thread Yasumasa Suenaga
Hi all, I updated webrev to adapt to current repos. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8148659/webrev.01/ Thanks, Yasumasa On 2016/03/03 23:46, Yasumasa Suenaga wrote: > Hi Dmitry, > >> Overall direction is to support jhsdb as the only entry point for SA and >

RFR(m): 8150015: Integrate TraceTime with Unified Logging more seamlessly

2016-03-15 Thread Robbin Ehn
Hi, please review this enhancement. This adds support for multiple UL tags in TraceTime. Bug: https://bugs.openjdk.java.net/browse/JDK-8150015/ Webrev: http://cr.openjdk.java.net/~rehn/8150015/v1/webrev/ Tested with jprt hotspot and manually tested log output. Thanks! /Robbin

Re: RFR: 8146879: Add option for handling existing log files in UL

2016-03-15 Thread Gerard Ziemski
hi Marcus, Sorry for getting back so late, but I got sick last Friday. > On Mar 14, 2016, at 5:52 AM, Marcus Larsson wrote: > >> >> --- >> #3 File src/share/vm/logging/log.cpp >> >> The number_of_lines_with_substring_in_file() function will not coun

Re: RFR(m): 8150015: Integrate TraceTime with Unified Logging more seamlessly

2016-03-15 Thread David Holmes
Hi Robbin, Thanks for tackling this. :) On 16/03/2016 6:31 AM, Robbin Ehn wrote: Hi, please review this enhancement. This adds support for multiple UL tags in TraceTime. Bug: https://bugs.openjdk.java.net/browse/JDK-8150015/ Webrev: http://cr.openjdk.java.net/~rehn/8150015/v1/webrev/ Initia

Re: RFR(m): 8150015: Integrate TraceTime with Unified Logging more seamlessly

2016-03-15 Thread David Holmes
On 16/03/2016 3:14 PM, David Holmes wrote: Hi Robbin, Thanks for tackling this. :) On 16/03/2016 6:31 AM, Robbin Ehn wrote: Hi, please review this enhancement. This adds support for multiple UL tags in TraceTime. Bug: https://bugs.openjdk.java.net/browse/JDK-8150015/ Webrev: http://cr.openjd

Re: RFR(m): 8150015: Integrate TraceTime with Unified Logging more seamlessly

2016-03-15 Thread Robbin Ehn
Thanks David for looking at this! On 03/16/2016 06:27 AM, David Holmes wrote: On 16/03/2016 3:14 PM, David Holmes wrote: Hi Robbin, Thanks for tackling this. :) On 16/03/2016 6:31 AM, Robbin Ehn wrote: Hi, please review this enhancement. This adds support for multiple UL tags in TraceTime.