Hi all,
If we try to attach invalid JVMTI agent via JVMTI.agent_load dcmd, we will get
"Command executed successfully". However, it implies error in
JVMTIAgentLoadDCmd.
This message is from JCmd.java when jcmd does not receive output from target VM.
So we should send error message from JVMTIAge
On 27/08/2016 7:35 AM, Chris Plummer wrote:
Hi Dmitry,
Although the fix is addressing the specific issue described in the bug,
what about the general issue of referencing gdata after a call to
cbEarlyVMDeath(). Do more references to gdata need to be protected?
Also, is there the possibility of
Hi Yasumasa,
On 28/08/2016 10:47 PM, Yasumasa Suenaga wrote:
Hi all,
If we try to attach invalid JVMTI agent via JVMTI.agent_load dcmd, we
will get
"Command executed successfully". However, it implies error in
JVMTIAgentLoadDCmd.
This message is from JCmd.java when jcmd does not receive output
On 24/08/2016 4:10 PM, Jini Susan George wrote:
Hi all,
Could you please review the fix for:
Bug: https://bugs.openjdk.java.net/browse/JDK-8164562
Webrev: http://cr.openjdk.java.net/~jgeorge/8164562/webrev.00/
I took the liberty to do some module related cleanups in the test also
while fixing
Thank you, Mandy. The test was throwing an NPE due to the option
“-XX:+UnlockDiagnosticVMOptions” not being used for
TestInstanceKlassSizeForInterface.java in the release build. jcmd’s
GC.class_stats requires this, and hence, parsing of the jcmd output was
resulting in an NPE.
Regards,
Ji
On 29/08/2016 2:14 PM, Jini Susan George wrote:
Thank you, Mandy. The test was throwing an NPE due to the option
“-XX:+UnlockDiagnosticVMOptions” not being used for
TestInstanceKlassSizeForInterface.java in the release build. jcmd’s
GC.class_stats requires this, and hence, parsing of the jcmd out
On 29/08/2016 2:29 PM, David Holmes wrote:
On 29/08/2016 2:14 PM, Jini Susan George wrote:
Thank you, Mandy. The test was throwing an NPE due to the option
“-XX:+UnlockDiagnosticVMOptions” not being used for
TestInstanceKlassSizeForInterface.java in the release build. jcmd’s
GC.class_stats requi
Hi David,
The reason I fixed the indent was to maintain 80 character line width. I
am not too familiar with coding conventions being followed w.r.t
indentations. Could you point me to coding conventions for native code
if we are following anything of that sort
Thanks
Harsha
On Friday 26 Aug
Hello All,
Could I get review from one more Reviewer?
Thanks
Harsha
On Wednesday 24 August 2016 10:07 AM, [email protected] wrote:
Thanks David.
Harsha
On Wed, Aug 24, 2016 at 6:55 AM +0530, "David Holmes"
mailto:[email protected]>> wrote:
On 23/08/2016 10:17 PM
Hello,
Please review a small test only change.
Bug id : https://bugs.openjdk.java.net/browse/JDK-8164609
Webrev : http://cr.openjdk.java.net/~sballal/sponsorship/8164609/webrev.00/
PS : Based on triaging , it looked like a timing issue in test case, so the
proposed changes are done
Hi Amit,
On 29/08/2016 3:55 PM, Amit Sapre wrote:
Hello,
Please review a small test only change.
Bug id : https://bugs.openjdk.java.net/browse/JDK-8164609
Webrev : http://cr.openjdk.java.net/~sballal/sponsorship/8164609/webrev.00/
! * Copyright (c) 2010, 2015, 2016, Oracle and/or its affil
This comment no longer matches the code and should be deleted:
2412 // Agent_OnAttach executed so completion status is JNI_OK
2413 st->print_cr("return code: %d", result);
Thanks David!
I removed it in new webrev.
http://cr.openjdk.java.net/~ysuenaga/JDK-8164913/webrev.01/
Yasu
On 8/28/16 6:14 PM, David Holmes wrote:
On 27/08/2016 7:35 AM, Chris Plummer wrote:
Hi Dmitry,
Although the fix is addressing the specific issue described in the bug,
what about the general issue of referencing gdata after a call to
cbEarlyVMDeath(). Do more references to gdata need to be prote
Hi Harsha,
On 29/08/2016 8:12 PM, Harsha Wardhana B wrote:
Hi David,
The reason I fixed the indent was to maintain 80 character line width. I
am not too familiar with coding conventions being followed w.r.t
indentations. Could you point me to coding conventions for native code
if we are followi
14 matches
Mail list logo
