Hi Volker,
On 10/02/2017 11:21 PM, Volker Simonis wrote:
On Fri, Feb 10, 2017 at 10:40 AM, Andrew Haley wrote:
On 10/02/17 03:13, Yasumasa Suenaga wrote:
We can calculate start address of executable (java command) through entry
point.
I updated webrev:
http://cr.openjdk.java.net/~ysuenaga/
Planning to push under trivial rules so just need one Reviewer please.
Bug: https://bugs.openjdk.java.net/browse/JDK-8174798
Stumbled on this by accident. This test should no longer be ignored, but
somehow the removal of the @ignore was lost in a Merge.
webrev: http://cr.openjdk.java.net/~dho
Thumbs up!
Dan
On 2/12/17 5:19 PM, David Holmes wrote:
Planning to push under trivial rules so just need one Reviewer please.
Bug: https://bugs.openjdk.java.net/browse/JDK-8174798
Stumbled on this by accident. This test should no longer be ignored,
but somehow the removal of the @ignore wa
Hi Yasumasa,
Please don't start new email threads on the same topic just to add a cc.
I've added to the existing thread and that is now missed on this new
one! It makes it hard to track comments, reviews and outstanding issues.
serviceability-dev was the correct mailing list for this change
Thanks Dan!
Pushing now.
David
On 13/02/2017 10:46 AM, Daniel D. Daugherty wrote:
Thumbs up!
Dan
On 2/12/17 5:19 PM, David Holmes wrote:
Planning to push under trivial rules so just need one Reviewer please.
Bug: https://bugs.openjdk.java.net/browse/JDK-8174798
Stumbled on this by accid
Hi David,
Sorry for my incorrect mail thread.
For this issue, I already got two reviewers:
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-February/020968.html
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-February/020973.html
Yasumasa
2017-02-13 10:09 GMT+09
On 13/02/2017 1:02 PM, Yasumasa Suenaga wrote:
Hi David,
Sorry for my incorrect mail thread.
For this issue, I already got two reviewers:
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-February/020968.html
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-February
Hi David,
> I'm a bit unclear on the problem being fixed - do I take it that Oracle
JDK binaries are not built as DSO's and so do not experience this problem?
Is there a reasonable way to test this (is it covered by any existing
tests) ?
You cannot check this issue with Oracle JDK because it is n
On 13/02/2017 1:54 PM, Yasumasa Suenaga wrote:
Hi David,
I'm a bit unclear on the problem being fixed - do I take it that
Oracle JDK binaries are not built as DSO's and so do not experience this
problem? Is there a reasonable way to test this (is it covered by any
existing tests) ?
You cannot
Hi Jini,
It looks pretty good to me.
A couple of comments.
http://cr.openjdk.java.net/%7Ejgeorge/8173896/webrev.00/hotspot/test/serviceability/sa/TestPrintMdo.java.html
It seems these exports are not really needed:
29 import java.io.BufferedInputStream;
31 import java.io.FileInputStream;
Please, review a JDK 9 fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8172969
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172969-jvmti-spec.hs1/
Summary:
It was identified during the review of 8172261 that the GetCurrentThread
may return NULL during the
Looks good!
Thanks Serguei!
David
On 13/02/2017 5:33 PM, serguei.spit...@oracle.com wrote:
Please, review a JDK 9 fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8172969
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172969-jvmti-spec.hs1/
Summary:
It was
Thank you, David!
Serguei
On 2/12/17 23:40, David Holmes wrote:
Looks good!
Thanks Serguei!
David
On 13/02/2017 5:33 PM, serguei.spit...@oracle.com wrote:
Please, review a JDK 9 fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8172969
Webrev:
http://cr.openjdk.java.net/~sspitsyn
On 13/02/2017 07:33, serguei.spit...@oracle.com wrote:
Please, review a JDK 9 fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8172969
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172969-jvmti-spec.hs1/
This looks okay to me.
-Alan
Thank you, Alan!
Serguei
On 2/12/17 23:45, Alan Bateman wrote:
On 13/02/2017 07:33, serguei.spit...@oracle.com wrote:
Please, review a JDK 9 fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8172969
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172969-jvmti-sp
15 matches
Mail list logo
