Re: JDK-8171119: Low-Overhead Heap Profiling

2018-01-30 Thread Robbin Ehn
Hi JC, On 01/30/2018 04:22 AM, JC Beyler wrote: - Collectedheap still needs to call AllocTracer to see if it is to be sampled, I can't hide everything in it without a bigger refactor (want me to try?) Yes we need a bigger refactor to do this nicely. I suggested not doing that now, so just roll

Re: PING: RFR: 8194249: SA: G1HeapRegionTable#getByAddress() returns incorrect HeapRegion

2018-01-30 Thread Thomas Schatzl
Hi, On Tue, 2018-01-30 at 07:00 +1000, David Holmes wrote: > Added in hotspot-gc-dev. Although this is in the SA it is about the > SA interaction with G1 and so likely needs someone familiar with G1 > to review it. > > David > > On 28/01/2018 10:41 PM, Yasumasa Suenaga wrote: > > PING: Could you

Re: RFR: 8196361: JTReg failure in serviceability/sa/ClhsdbInspect.java

2018-01-30 Thread Jini George
Hi Daniel, David, Thanks, Daniel, for bringing this up. The intent of the test is to get the oop address corresponding to a java.lang.ref.ReferenceQueue$Lock, which can typically be obtained from the stack traces of the Common-Cleaner or the Finalizer threads. The stack traces which I had bee

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

2018-01-30 Thread Erik Helin
On 01/30/2018 03:07 AM, Hohensee, Paul wrote: That’s one reviewer who’s ok with a short term patch. Anyone else? And, any reviewers for said short term patch? :) Well, the patch is not really complete as it is. The problem is the definitions of the MemoryPoolMXBeans and GarbageCollectorMXBeans

Re: PING: RFR: 8194249: SA: G1HeapRegionTable#getByAddress() returns incorrect HeapRegion

2018-01-30 Thread Thomas Schatzl
Hi all, On Tue, 2018-01-30 at 11:06 +0100, Thomas Schatzl wrote: > Hi, > > On Tue, 2018-01-30 at 07:00 +1000, David Holmes wrote: > > Added in hotspot-gc-dev. Although this is in the SA it is about the > > SA interaction with G1 and so likely needs someone familiar with G1 > > to review it. > >

Re: PING: RFR: 8194249: SA: G1HeapRegionTable#getByAddress() returns incorrect HeapRegion

2018-01-30 Thread Yasumasa Suenaga
Hi Thomas, >> looks good to me - however there is another (pre-existing) bug: the >> shift in that code should be a logical shift, not an arithmetic >> shift. >> >> I.e. ">>" instead of ">>>". >> >> I will run the patch through testing and report back in a few hours. >> Should be okay. > > is

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

2018-01-30 Thread Hohensee, Paul
It’s true that my patch doesn’t completely solve the larger problem, but it fixes the most immediately important part of it, particularly for JDK8 where current expected behavior is entrenched. If we’re going to fix the larger problem, imo we should file another bug/rfe to do it. I’d be happy to