My 2c ...
We have to have tests that can test core file attaching capability -
else we don't know it works. So we have to try and generate a core file.
But, we have to expect that in many cases no core file will be generated
even if the hs-err file claims it was. For example my primary local
Hi Rafael,
I think it's best to separate the testing requirement from java agents
doing instrumentation that may run in production environment.
I have created a JBS issue to track the testing mode idea that would
require more discussion and investigation:
https://bugs.openjdk.java.net/brow
Hi Sangheon,
On 4/18/18 12:41 PM, sangheon.kim wrote:
CR: https://bugs.openjdk.java.net/browse/JDK-8196325
webrev: http://cr.openjdk.java.net/~sangheki/8196325/webrev.0/
This is indeed a regression. GcInfoBuilder depends on the order of the
pool name array.
The change looks okay. I woul
Hi Serguei,
Do you need me to try anything else for this review?
hotspot/jtreg/serviceability suite run successfully.
Many Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: [email protected]
Hi Andrew,
Sorry, I did not reply earlier.
The fix need more testing. We also have some important tests in
closed.
I'll run them but I'm a little bit busy at the moment.
You have two reviews which is enough for push after testing.
I agree with the need of testing as much as we can. I could do something
on the lines of how other debuggers like LLDB test: if we can't find the
core file location, check for "|" at the beginning of a line in the
/proc/sys/kernel/core_pattern file -- and fail with a message stating
that the sy
Thank you very much for the reviews, Coleen and Ioi. I have filed the RFE.
-Jini.
On 4/17/2018 11:09 AM, Ioi Lam wrote:
The changes look good to me.
I agree with Coleen. Maybe FileMapHeader should be moved to a common
file that can be included in all the ps_core files, as well as the VM's
fi
Hei Mandy,
Generally I agree with you that these two should be seperate but I think
that there is a very blurry border between the two. Java agents are
sometimes used to test something in a production environment and there is a
long history of agent development that relies on the easy and general
Hi Mandy,
On 04/18/2018 02:20 AM, mandy chung wrote:
Hi Sangheon,
On 4/18/18 12:41 PM, sangheon.kim wrote:
CR: https://bugs.openjdk.java.net/browse/JDK-8196325
webrev: http://cr.openjdk.java.net/~sangheki/8196325/webrev.0/
This is indeed a regression. GcInfoBuilder depends on the order of
On 4/19/18 4:52 AM, sangheon.kim wrote:
Webrev:
http://cr.openjdk.java.net/~sangheki/8196325/webrev.1 (full)
http://cr.openjdk.java.net/~sangheki/8196325/webrev.1_to_0/ (inc)
Looks good.
Mandy
https://bugs.openjdk.java.net/browse/JDK-8201784
This is the correct JBS issue (Sorry I cut-n-paste the wrong link).
Mandy
On 4/18/18 3:46 PM, mandy chung wrote:
Hi Rafael,
I think it's best to separate the testing requirement from java agents
doing instrumentation that may run in production
11 matches
Mail list logo
