Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread Chris Plummer
Sorry, I thought this had been pushed already, but it hasn't. But it still looks like JDK-8202896 should be closed as a dup, and it's unclear to me if JDK-8206076 has been fixed and this test can be removed from the problem list. Chris On 7/30/18 6:34 PM, Chris Plummer wrote: Hi Coleen, Now

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread [email protected]
Hi Coleen, The explanation from David is very helpful - thanks! So the fix looks good to me as well. We still need to answer questions from Chris though. Thanks, Serguei On 7/30/18 14:46, David Holmes wrote: On 31/07/2018 6:49 AM, [email protected] wrote: Summary: fixed refactori

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread [email protected]
Hi Chris, Good catch. It is possible that this webrev does not fix the JDK-8202896. The JDK-8202896 is about timeouts which are normally intermittent (is it right?). There are two options here:   A: close 8202896 as a dup of 8208074   B: keep the test problem listed and labeled with 8202896 L

Re: [PING] RFR(XS): 8208091: SA: jhsdb jstack --mixed throws UnmappedAddressException on i686

2018-07-31 Thread Severin Gehwolf
On Mon, 2018-07-30 at 21:23 -0700, Sharath Ballal wrote: > > Ok. It looks like we don't even have a "jstack --mixed" test. Could > > you add one? It would be even better if the test included a JNI lib > > that wasn't compiled with -fno-omit-frame-pointer so you don't need > > to rely on glibc to re

Re: RFR: JDK-8169718: nsk/jdb/locals/locals002: ERROR: Cannot find boolVar with expected value: false

2018-07-31 Thread [email protected]
On 7/30/18 09:46, Chris Plummer wrote: On 7/30/18 12:47 AM, [email protected] wrote: Hi Chris, Just one quick simple comment below. On 7/29/18 22:05, Chris Plummer wrote:

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread coleen . phillimore
On 7/30/18 5:46 PM, David Holmes wrote: On 31/07/2018 6:49 AM, [email protected] wrote: Summary: fixed refactoring caused by JDK-8203820 open webrev at http://cr.openjdk.java.net/~coleenp/8208074.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8208074 For the sake of

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread coleen . phillimore
On 7/30/18 9:34 PM, Chris Plummer wrote: Hi Coleen, Now that this had been pushed, I assume JDK-8202896 should be closed as a dup. And what about JDK-8206076? Is it fixed by this change also? Yes, it should be closed also.   I didn't see this bug.  When I was fixing the first one: https:/

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread coleen . phillimore
On 7/31/18 3:29 AM, [email protected] wrote: Hi Chris, Good catch. It is possible that this webrev does not fix the JDK-8202896. The JDK-8202896 is about timeouts which are normally intermittent (is it right?). There are two options here:   A: close 8202896 as a dup of 8208074   B

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread Chris Plummer
On 7/31/18 5:06 AM, [email protected] wrote: On 7/31/18 3:29 AM, [email protected] wrote: Hi Chris, Good catch. It is possible that this webrev does not fix the JDK-8202896. The JDK-8202896 is about timeouts which are normally intermittent (is it right?). There are two

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread Chris Plummer
Hi Coleen, I just realized that there is also https://bugs.openjdk.java.net/browse/JDK-8208234 filed for this test last week. It results in an OOME. I think it's the same issue, but just want check with you. Please close it as a dup if you think it is the same. thanks, Chris On 7/31/18 9:1

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread [email protected]
On 7/31/18 09:13, Chris Plummer wrote: On 7/31/18 5:06 AM, [email protected] wrote: On 7/31/18 3:29 AM, [email protected] wrote: Hi Chris, Good catch. It is possible that this webrev does not fix the JDK-8202896. The JDK-8202896 is about timeouts which are normally interm

Re: RFR(L): 8196989: Revamp G1 JMX MemoryPoolMXBean, GarbageCollectorMXBean, and jstat counter definitions

2018-07-31 Thread Hohensee, Paul
A few small things for http://cr.openjdk.java.net/~tschatzl/8208498/webrev/, otherwise looks good. collectionSetChooser.cpp: Doesn't !r->is_old() include is_archive()? g1CollectedHeap.hpp: Add archive_region_add(), archive_region_remove(), and old_set_bulk_remove(). In n

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread coleen . phillimore
On 7/31/18 1:43 PM, Chris Plummer wrote: Hi Coleen, I just realized that there is also https://bugs.openjdk.java.net/browse/JDK-8208234 filed for this test last week. It results in an OOME. I think it's the same issue, but just want check with you. Please close it as a dup if you think it

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread coleen . phillimore
On 7/31/18 2:07 PM, [email protected] wrote: On 7/31/18 09:13, Chris Plummer wrote: On 7/31/18 5:06 AM, [email protected] wrote: On 7/31/18 3:29 AM, [email protected] wrote: Hi Chris, Good catch. It is possible that this webrev does not fix the JDK-8202896. T

Re: RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

2018-07-31 Thread [email protected]
On 7/31/18 13:09, [email protected] wrote: On 7/31/18 2:07 PM, [email protected] wrote: On 7/31/18 09:13, Chris Plummer wrote: On 7/31/18 5:06 AM, [email protected] wrote: On 7/31/18 3:29 AM, [email protected] wrote: Hi Chris, Good catch. It is pos