It would be great to get some input from the non-compilers teams on this RFR.
-Doug
> On 28 Sep 2018, at 19:51, Vladimir Kozlov wrote:
>
> To let you know, me and Tom R. did review these changes and agreed that it is
> the least intrusive changes for Hotspot shared code.
>
> Thanks,
> Vladimi
Solaris debug builds are failing tests that use the attach interface.
An IOException is reported when the java_pid file is not opened.
It appears that the attempt to attach is taking place too quickly.
This workaround will allow the open operation to be retried
after a short pause.
Webrev: htt
Looking for one more reviewer before we push this changeset.
On 9/22/18, 6:45 AM, [email protected] wrote:
This is a very old bug that started off as a closed test, but should
have an open review
before it finally gets pushed. Many other jdb bugs will be closed as
duplicates as a
result of
On 01/10/2018 17:43, JC Beyler wrote:
Hi,
Should we not be also incrementing i to get the next Ace? Otherwise,
we are always getting the same one and probably just waiting till the
count is 0 which would terminate the loop (if that is what we want,
why not just break?).
Thanks,
Jc
An alter
Without the fix was this issue easy enough to reproduce that you can be
sure this is resolving it?
Chris
On 10/2/18 8:16 AM, Gary Adams wrote:
Solaris debug builds are failing tests that use the attach interface.
An IOException is reported when the java_pid file is not opened.
It appears that
The problem reproduced pretty quickly.
I added a call to checkPermission and revealed the
"file not found" from the stat call when the IOException
was detected.
There has been some flakiness from the Solaris test machines today,
so I'll continue with the testing a bit longer.
On 10/2/18 3:12 PM,
Can you summarize how the attach handshaking is suppose to work? I'm
just wondering why the attacher would ever be looking for the file
before the attachee has created it. It seems a proper handshake would
prevent this. Maybe there's some sort of visibility issue where the
attachee has indeed c
The general attach sequence ...
src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java
the attacher creates an attach_pid file in a directory where the
attachee is runnning
issues a signal to the attacheee
loops waiting for the java_pid file to be created
default timeou
On 10/2/18 1:44 PM, [email protected] wrote:
The general attach sequence ...
src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java
the attacher creates an attach_pid file in a directory where the
attachee is runnning
issues a signal to the attacheee
loops waiting
Hi Jc,
This looks much better to me :)
Sometimes the script generate too long lines like
-if (!NSK_JNI_VERIFY(jni, (testedMeth =
NSK_CPP_STUB4(GetStaticMethodID,
-jni, objCls, meth_sig[clsIdx][i][0],
-meth_sig[clsIdx][i][2])) != NULL)) {
+
Chris,
On 3/10/2018 6:57 AM, Chris Plummer wrote:
On 10/2/18 1:44 PM, [email protected] wrote:
The general attach sequence ...
src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java
the attacher creates an attach_pid file in a directory where the
attachee is runnning
On 10/2/18 2:38 PM, David Holmes wrote:
Chris,
On 3/10/2018 6:57 AM, Chris Plummer wrote:
On 10/2/18 1:44 PM, [email protected] wrote:
The general attach sequence ...
src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java
the attacher creates an attach_pid file in a d
Looks good to me.
--alex
On 10/02/2018 11:29, Gary Adams wrote:
Looking for one more reviewer before we push this changeset.
On 9/22/18, 6:45 AM, [email protected] wrote:
This is a very old bug that started off as a closed test, but should
have an open review
before it finally gets pushed
Minor correction: EPERM -> EACCES for Solaris
Hard to see how to get a transient EACCES when opening a file ... though
as it is really a door I guess there could be additional complexity.
David
On 3/10/2018 7:54 AM, Chris Plummer wrote:
On 10/2/18 2:38 PM, David Holmes wrote:
Chris,
On 3/1
Hi Doug,
The JVMTI related part looks good to me.
Thank you for fixing it!
Thanks,
Serguei
On 10/2/18 1:11 AM, Doug Simon wrote:
It would be great to get some input from the non-compilers teams on this RFR.
-Doug
On 28 Sep 2018, at 19:51, Vladimir Kozlov wrote:
To let you know, me and Tom
+1 (if you still need it)
Thanks,
Serguei
On 9/26/18 4:41 AM, David Holmes wrote:
That all seems fine to me.
Thanks for fixing.
David
On 26/09/2018 5:48 AM, Langer, Christoph wrote:
Hi Matthias,
looks good (and trivial). Ccing serviceability-dev because of change
in libjdwp.
Best regard
Hi Jc,
Looks good to me.
Thanks,
Serguei
On 10/2/18 6:51 AM, JC Beyler wrote:
Hi Alex,
That is because this webrev was done before I added the 100 character
wrap, which I added when I was generating the next batch of changes.
Here is the webrev with the new version of the script:
Webrev:
Hi Goetz,
I have opened https://bugs.openjdk.java.net/browse/JDK-8211421 for the backport.
Thanks,
Sharath
-Original Message-
From: Lindenmaier, Goetz [mailto:[email protected]]
Sent: Friday, September 28, 2018 8:41 PM
To: Sharath Ballal; serviceability-dev
Subject: RE: RFR (X
18 matches
Mail list logo
