Re: [PING?] RFR: 8217338: [Containers] Improve systemd slice memory limit support

Hi, Could I get another reviewer for this, please? Bob Vandette already reviewed it. Thank you! Cheers, Severin On Tue, 2019-04-02 at 13:48 +0200, Severin Gehwolf wrote: > Could I get a second review, please? > > Thanks, > Severin > > On Thu, 2019-03-28 at 11:37 -0400, Bob Vandette wrote: > >

Re: RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java failes with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]

Hi David, you're right! The fix for JDK-8212117 should help here as well. After that fix we may want to revisit ValueContainer.findType implementors, currently they all (except for ArrayTypeImpl) delegates to ReferenceTypeImpl.findType (which ends up in classloader.visibleClasses). Someone shou

Re: RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java failes with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][]

On 9/04/2019 7:36 pm, Egor Ushakov wrote: Hi David, you're right! The fix for JDK-8212117 should help here as well. After that fix we may want to revisit ValueContainer.findType implementors, currently they all (except for ArrayTypeImpl) delegates to ReferenceTypeImpl.findType (which ends up in

Re: RFR(MS): 8222072: JVMTI GenerateEvents() sends CompiledMethodLoad events to wrong jvmtiEnv

Hi Jc, Thank you a lot for looking at this! On 4/9/19 9:29 AM, Jean Christophe Beyler wrote: Hi Serguei, I saw a nit here: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8222072-jvmti-GenerateEvents.1/test/hotspot/jtreg/serviceability/jvmti/GenerateEvents/MyPackage/GenerateEventsTest.java.

Re: RFR(MS): 8222072: JVMTI GenerateEvents() sends CompiledMethodLoad events to wrong jvmtiEnv

Thank you, Jc! Serguei On 4/9/19 2:21 PM, Jean Christophe Beyler wrote: Hi Serguei, Looks good to me now :) Jc On Tue, Apr 9, 2019 at 1:58 PM > wrote: Hi Jc, Thank you a lot for looking at this! On 4/9/19 9:29 AM, Jean Christophe Beyler wrote:

Re: RFR: JDK-8203364: Some serviceability/sa/ tests intermittently fail with java.io.IOException: LingeredApp terminated with non-zero exit code 3

Hi Gary, It looks Okay in general. On minor suggestion. Could you, introduce symbolic constants and use them for exit codes? They will be self-describing that way. Thanks, Serguei On 4/4/19 5:02 AM, Gary Adams wrote: I need a second reviewer for this minor update. On 4/2/19, 2:18 PM, Chris Pl

RFR: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails

Please review the change that fixes intermittent failure of the test when running with Graal on. The problem here is the similar to the one fixed in JDK-8218401, the callbacks this test enables keep processing events and perform JVMTI calls after VM is terminated. The fix ensures that the test

Re: RFR(MS): 8222072: JVMTI GenerateEvents() sends CompiledMethodLoad events to wrong jvmtiEnv

Hi Serguei, Maybe resolve code duplication in post_compiled_method_load(nmethod *nm) and post_compiled_method_load(JvmtiEnv* env, nmethod *nm)? Looks like the only difference is logging, but I don't think it's important as old post_compiled_method_load(JvmtiEnv* env, const jmethodID method,

Re: RFR(MS): 8222072: JVMTI GenerateEvents() sends CompiledMethodLoad events to wrong jvmtiEnv

Hi Alex, Thank you for review! On 4/9/19 4:57 PM, Alex Menkov wrote: Hi Serguei, Maybe resolve code duplication in post_compiled_method_load(nmethod *nm) and post_compiled_method_load(JvmtiEnv* env, nmethod *nm)? Looks like the only difference is logging, but I don't think it's important a

Re: RFR(MS): 8222072: JVMTI GenerateEvents() sends CompiledMethodLoad events to wrong jvmtiEnv

Hi Alex, New webrev version with refactoring: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8222072-jvmti-GenerateEvents.3/ I will also re-submit mach5 jobs for jvmti tests and new test. Thanks, Serguei On 4/9/19 5:39 PM, [email protected] wrote: Hi Alex, Thank you for review!

Re: RFR: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails

Hi Daniil, It looks good. Thanks, Serguei On 4/9/19 4:37 PM, Daniil Titov wrote: Please review the change that fixes intermittent failure of the test when running with Graal on. The problem here is the similar to the one fixed in JDK-8218401, the callbacks this test enables keep processing