Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

2020-03-17 Thread Dmitry Samersoff
Hello Alexander, The fix looks good for me. -Dmitry On 05.03.2020 17:27, Daniel Fuchs wrote: Hi Alexander, Fixes to JMX & management agent are reviewed on the seviceability-dev (added in to:) these days. best regards, -- daniel On 05/03/2020 13:17, Alexander Scherbatiy wrote: Hello, Coul

Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

2020-03-17 Thread Igor Ignatyev
Hi Alexander, overall looks good to me, I have a few comments though: - you can use Utils.TEST_CLASSPATH instead of CustomLauncherTest.TEST_CLASSPATH - CustomLauncherTest::findLibjvm can be simplified by use Platform::jvmLibDir - exelauncher.c has a comment which refers to the test as CustomLaun

Re: RFR: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

2020-03-17 Thread Daniil Titov
Hi Alex, Please review a new version of the fix that removes the old version of the code that tried to handle the "port in use" case. Testing: Mach5 tests for sun/tools/jstatd/ successfully passed 100 times. Tier1-tier3 tests successfully passed. [1] http://cr.openjdk.java.net/~dtitov/82407

Re: RFR: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

2020-03-17 Thread Alex Menkov
LGTM --alex On 03/17/2020 11:40, Daniil Titov wrote: Hi Alex, Please review a new version of the fix that removes the old version of the code that tried to handle the "port in use" case. Testing: Mach5 tests for sun/tools/jstatd/ successfully passed 100 times. Tier1-tier3 tests successful

RFR 8240902: JDI shared memory connector can use already closed Handles

2020-03-17 Thread Patricio Chilano
Hi all, Please review the following patch: Bug: https://bugs.openjdk.java.net/browse/JDK-8240902 Webrev: http://cr.openjdk.java.net/~pchilanomate/8240902/v1/webrev/ Calling closeConnection() on an already created/opened connection includes calls to CloseHandle() on objects that can still be us

RFR(XS) 8240906: Update ZGC ProblemList for serviceability/sa/TestJmapCoreMetaspace.java

2020-03-17 Thread Chris Plummer
Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8240906 diff --git a/test/hotspot/jtreg/ProblemList-zgc.txt b/test/hotspot/jtreg/ProblemList-zgc.txt --- a/test/hotspot/jtreg/ProblemList-zgc.txt +++ b/test/hotspot/jtreg/ProblemList-zgc.txt @@ -47,5 +47,5 @@  servic

RFR(XS) 8227340: Modify problem list entry for javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java

2020-03-17 Thread Chris Plummer
Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8227340 diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -587,7 +587,7 @@  java/lang/management/ThreadMXBean/AllThreadIds.java 8131745 ge

Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump

2020-03-17 Thread David Holmes
Hi Ralf, On 13/03/2020 9:43 pm, Schmelter, Ralf wrote: Hi, I have updated the webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8237354/webrev.1/ It has the following significant changes: - The jcmd now uses two separate flags. The -gz flag is now a boolean flag which toggles the compr

Re: RFR(XS) 8227340: Modify problem list entry for javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java

2020-03-17 Thread David Holmes
Hi Chris, On 18/03/2020 2:59 pm, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8227340 diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -587,7 +587,7 @@  java/

Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump

2020-03-17 Thread Schmelter, Ralf
Hi David, > However I'm not clear how this solves  the problem of destroying > the monitor while it can still be being accessed - is the dumping > occurring at a safepoint in the WorkGang threads? Because when the run_task() method returns, I can be sure none of the work gang threads still use th

Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump

2020-03-17 Thread David Holmes
On 18/03/2020 4:39 pm, Schmelter, Ralf wrote: Hi David,  However I'm not clear how this solves  the problem of destroying the monitor while it can still be being accessed - is the dumping occurring at a safepoint in the WorkGang threads? Because when the run_task() method returns, I can be s