Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi Patricio, On 18/03/2020 6:14 am, Patricio Chilano wrote: Hi all, Please review the following patch: Bug: https://bugs.openjdk.java.net/browse/JDK-8240902 Webrev: http://cr.openjdk.java.net/~pchilanomate/8240902/v1/webrev/ Calling closeConnection() on an already created/opened connection i

Re: RFR(XS) 8240906: Update ZGC ProblemList for serviceability/sa/TestJmapCoreMetaspace.java

Looks good. StefanK On 2020-03-18 05:52, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8240906 diff --git a/test/hotspot/jtreg/ProblemList-zgc.txt b/test/hotspot/jtreg/ProblemList-zgc.txt --- a/test/hotspot/jtreg/ProblemList-zgc.txt +++ b

Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8240604/webrev.01 Utils.TEST_CLASS_PATH, Platform.jvmLibDir(), and /native flag are added to the CustomLauncherTest.java test. I also included TEST_NATIVE_PATH to the Utils lib. I have not found a history about C

Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

On 18.03.2020 14:57, Alexander Scherbatiy wrote: Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8240604/webrev.01 Utils.TEST_CLASS_PATH, Platform.jvmLibDir(), and /native flag are added to the CustomLauncherTest.java test. I also included TEST_NATIVE_PATH to

Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

Hi Alexander, > I also included TEST_NATIVE_PATH to the Utils lib. for the sake of clarity and ease of backporting, I'd prefer to have it added by a separate bug and commit. > Could I just use "hg remove binary-fie" and run webrev to add the removed > binary files into webrev? IIRC correctly, w

Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

On 18.03.2020 19:00, Igor Ignatyev wrote: Hi Alexander, I also included TEST_NATIVE_PATH to the Utils lib. for the sake of clarity and ease of backporting, I'd prefer to have it added by a separate bug and commit. Here is the updated fix where TEST_NATIVE_PATH is not added to the Utils li

Re: RFR: 8227269: Slow class loading when running JVM in debug mode

Hi Serguei, Thanks for your review! A quick update on my progress: The wrong condition was a good find! In-fact so much that it lead to the whole implementation not reporting any unloaded classes. I changed that back, and now it's so slow because of all those unloaded classes firing events, I'm t

Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

+import static jdk.test.lib.Utils.TEST_CLASS_PATH; I'm not a huge fun of 'import static', yet don't insist on removing it either. +System.out.println(" libjvm: " + jvmLibDir.toString()); jvmLibDir doesn't point to libjvm, so you need either update message prefix or use the actua

Re: RFR(XS) 8240906: Update ZGC ProblemList for serviceability/sa/TestJmapCoreMetaspace.java

Thanks! On 3/18/20 2:00 AM, Stefan Karlsson wrote: Looks good. StefanK On 2020-03-18 05:52, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8240906 diff --git a/test/hotspot/jtreg/ProblemList-zgc.txt b/test/hotspot/jtreg/ProblemList-zgc.tx

Re: RFR: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

Hi Alex, Thank you for reviewing this change. Best regards, Daniil On 3/17/20, 11:58 AM, "Alex Menkov" wrote: LGTM --alex On 03/17/2020 11:40, Daniil Titov wrote: > Hi Alex, > > Please review a new version of the fix that removes the old version of the code

Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

On 18.03.2020 20:02, Igor Ignatyev wrote: +import static jdk.test.lib.Utils.TEST_CLASS_PATH; I'm not a huge fun of 'import static', yet don't insist on removing it either. + System.out.println(" libjvm : " + jvmLibDir.toString()); jvmLibDir doesn't point to libjvm, so you need either update m

Re: RFR(XS) 8227340: Modify problem list entry for javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java

Thanks! Chris On 3/17/20 10:16 PM, David Holmes wrote: Hi Chris, On 18/03/2020 2:59 pm, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8227340 diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt

Re: jmx-dev RFR 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file

thanks! LGTM. -- Igor > On Mar 18, 2020, at 10:35 AM, Alexander Scherbatiy > wrote: > > On 18.03.2020 20:02, Igor Ignatyev wrote: > >> +import static jdk.test.lib.Utils.TEST_CLASS_PATH; >> I'm not a huge fun of 'import static', yet don't insist on removing it >> either. >> >> +

RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

Hi Could you please review following fix which slightly refactor vmTestbase stress test harness. This refactoring helps to add virtual threads testing support. The Wicket uses plain sync/wait/notify mechanism which cause carrier thread starvation and should not be used in virtual threads. Th

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

Hi Leonid, I've started looking at your webrev, and so far have a couple questions: > Test > vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects003/referringObjects003a.java > was updated to don't use Wicket. (The lock has a reference to thread which > affects test.) can't you

RFR(XS) 8241162: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java on OSX

Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8241162 diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt +++ b/test/hotspot/jtreg/ProblemList.txt @@ -131,7 +131,7 @@  serviceability/sa/Te

Re: RFR(XS) 8241162: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java on OSX

Thumbs up. Also, this fix is trivial. Dan On 3/18/20 4:05 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8241162 diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList

Re: RFR(XS) 8241162: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java on OSX

Thanks! On 3/18/20 1:07 PM, Daniel D. Daugherty wrote: Thumbs up. Also, this fix is trivial. Dan On 3/18/20 4:05 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8241162 diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jt

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

On 3/18/20 12:48 PM, Igor Ignatyev wrote: Hi Leonid, I've started looking at your webrev, and so far have a couple questions: Test vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects003/referringObjects003a.java was updated to don't use Wicket. (The lock has a reference to

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

On 3/17/20 4:14 PM, Patricio Chilano wrote: Hi all, Please review the following patch: Bug: https://bugs.openjdk.java.net/browse/JDK-8240902 Webrev: http://cr.openjdk.java.net/~pchilanomate/8240902/v1/webrev/ src/jdk.jdi/share/native/libdt_shmem/shmemBase.c     L411:     int attempts = 10;   

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi David, On 3/18/20 4:27 AM, David Holmes wrote: Hi Patricio, On 18/03/2020 6:14 am, Patricio Chilano wrote: Hi all, Please review the following patch: Bug: https://bugs.openjdk.java.net/browse/JDK-8240902 Webrev: http://cr.openjdk.java.net/~pchilanomate/8240902/v1/webrev/ Calling closeCon

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi Patricio, Good finding, thank you for taking care about this! The fix looks good in general. There are several spots with the wrong indent (must be 4, not 2): 64 #define ENTER_CONNECTION(connection) do { \ 65

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

> On Mar 18, 2020, at 1:29 PM, Leonid Mesnik wrote: > > > On 3/18/20 12:48 PM, Igor Ignatyev wrote: >> Hi Leonid, >> >> I've started looking at your webrev, and so far have a couple questions: >> >>> Test >>> vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects003/referring

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

> I need more time to get grasp of Wicket and your changes in it; will come > back to you after I understand them. ok, now when I believe that I have enough understanding of Wicket, I have a few comments: 1. > 68 private Lock lock = new ReentrantLock(); > 69 private Condition conditi

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Patricio, This is a separate follow up about the jshell tests. Since I have been tracking these as part of my GK work and filed a number of those bugs, I figured I would help analyze them... JDK-8209848 test/langtools/jdk/jshell tests failed with Accept timed out https://bugs.openjdk.java.net/br

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

serviceability-dev@... was included in this email by mistake. This was only supposed to go to Patricio since the Mach5 links won't work outside of Oracle. Sigh... Sorry about the noise folks! Dan On 3/18/20 5:37 PM, Daniel D. Daugherty wrote: Patricio, This is a separate follow up about the

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi Dan, On 3/18/20 5:30 PM, Daniel D. Daugherty wrote: On 3/17/20 4:14 PM, Patricio Chilano wrote: Hi all, Please review the following patch: Bug: https://bugs.openjdk.java.net/browse/JDK-8240902 Webrev: http://cr.openjdk.java.net/~pchilanomate/8240902/v1/webrev/ src/jdk.jdi/share/native/li

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi Serguei, On 3/18/20 6:03 PM, [email protected] wrote: Hi Patricio, Good finding, thank you for taking care about this! The fix looks good in general. There are several spots with the wrong indent (must be 4, not 2): 64 #define ENTER_CONNECTION(connection) do { \ 65 InterlockedIncre

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

On 3/18/20 2:30 PM, Igor Ignatyev wrote: I need more time to get grasp of Wicket and your changes in it; will come back to you after I understand them. ok, now when I believe that I have enough understanding of Wicket, I have a few comments: 1. 68 private Lock lock = new ReentrantLock(); 69

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

Reviewed. — Igor > On Mar 18, 2020, at 3:18 PM, Leonid Mesnik wrote: > >  > > > On 3/18/20 2:30 PM, Igor Ignatyev wrote: >>> I need more time to get grasp of Wicket and your changes in it; will come >>> back to you after I understand them. >> ok, now when I believe that I have enough unde

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

Thank you for review and  feedback. Leonid On 3/18/20 3:22 PM, Igor Ignatev wrote: Reviewed. — Igor On Mar 18, 2020, at 3:18 PM, Leonid Mesnik wrote:  On 3/18/20 2:30 PM, Igor Ignatyev wrote: I need more time to get grasp of Wicket and your changes in it; will come back to you after I

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi Patricio, On 19/03/2020 6:44 am, Patricio Chilano wrote: Hi David, On 3/18/20 4:27 AM, David Holmes wrote: Hi Patricio, On 18/03/2020 6:14 am, Patricio Chilano wrote: Hi all, Please review the following patch: Bug: https://bugs.openjdk.java.net/browse/JDK-8240902 Webrev: http://cr.openj

RFR(XS) 8240543: Update problem list entry for serviceability/sa/TestRevPtrsForInvokeDynamic.java to reference JDK-8241235

Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8240543 diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt +++ b/test/hotspot/jtreg/ProblemList.txt @@ -140,7 +140,7 @@  serviceability/sa/Te

Re: RFR(XS) 8240543: Update problem list entry for serviceability/sa/TestRevPtrsForInvokeDynamic.java to reference JDK-8241235

Looks good Chris. Thanks, David On 19/03/2020 12:35 pm, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8240543 diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt ++

Re: RFR(XS) 8240543: Update problem list entry for serviceability/sa/TestRevPtrsForInvokeDynamic.java to reference JDK-8241235

Thanks! On 3/18/20 8:42 PM, David Holmes wrote: Looks good Chris. Thanks, David On 19/03/2020 12:35 pm, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8240543 diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemLis

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi David, On 3/18/20 8:10 PM, David Holmes wrote: Hi Patricio, On 19/03/2020 6:44 am, Patricio Chilano wrote: Hi David, On 3/18/20 4:27 AM, David Holmes wrote: Hi Patricio, On 18/03/2020 6:14 am, Patricio Chilano wrote: Hi all, Please review the following patch: Bug: https://bugs.openjdk