Re: RFR: 8240956: SEGV in DwarfParser::process_dwarf after JDK-8234624

Hi Yasumasa, I looked at you changes. It is hard to understand if this fully solves the issue. http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.03/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java.frames.html

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi Patricio, The update looks good. Thanks, Serguei On 3/18/20 23:18, Patricio Chilano wrote: Hi David, On 3/18/20 8:10 PM, David Holmes wrote: Hi Patricio, On

Re: RFR: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

Hi Daniil, It looks Okay in general. But I've got a question. 329 while (jstatdThread == null) { 330 if (!useDefaultPort) { 331 port = String.valueOf(Utils.getFreePort()); 332 } 333 334

Re: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

Hi Serguei, In this case tryToSetupJstatdProcess() on line 346 return null and the test   will try to find a new pair of ports and start jstatd process. Best regards, Daniil From: "[email protected]" Date: Monday, March 23, 2020 at 11:45 AM To: Daniil Titov , Alex Menkov

RFR: JDK-8241463 Move build tools to respective modules

The build tools (small java tools that are run during the build to generate source code, or data, needed in the JDK) have historically been placed in the "make" directory. This maybe made sense long time ago, but does not do so anymore. Instead, the build tools source code should move the the

Re: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

On 3/23/20 12:05, Daniil Titov wrote: Hi Serguei,   In this case tryToSetupJstatdProcess() on line 346 return null and the test  will try to find a new pair of ports and start jstatd process. I under

Re: RFR: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

Hi Serguei, I don’t think  that in any real environment the loop could not be able to find the pair of free ports before it is killed by JTREG due to timeout. But if you think that we need to limit the number of attempts here I could create a new issue for that. Thanks! --Daniil

Re: RFR: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

Hi Daniil, My concern is that we have too many failures (and different cases) with timeouts. A big part of them happen when a connection is being established. Can these situation happen because servers are configured incorrectly? If so, is it be

Re: RFR: JDK-8241463 Move build tools to respective modules

Looks good. /Erik On 2020-03-23 12:03, Magnus Ihse Bursie wrote: The build tools (small java tools that are run during the build to generate source code, or data, needed in the JDK) have historically been placed in the "make" directory. This maybe made sense long time ago, but does not do so

Re: RFR: JDK-8241463 Move build tools to respective modules

Hi Magnus, Modularizing the build tools is a good move.    This patch suggests to place the build tools under     src/$MODULE/share/tools/$PACKAGE/*.java I think the modular source location of the build tools needs more discussion, including jigsaw-dev for this discussion. The JDK source as

Re: RFR: JDK-8241463 Move build tools to respective modules

On 23/03/2020 19:03, Magnus Ihse Bursie wrote: The build tools (small java tools that are run during the build to generate source code, or data, needed in the JDK) have historically been placed in the "make" directory. This maybe made sense long time ago, but does not do so anymore. Instea

Re: RFR: 8240711: TestJstatdPort.java failed due to "ExportException: Port already in use:"

Hi Daniil, Please, skip my concern. As we privately concluded the chance to endlessly loop on getting unused free port is very small. I'm okay with the fix as it is. Thanks, Serguei On 3/23/20 12:48, serguei.spit...@or

Re: RFR: JDK-8241463 Move build tools to respective modules

Hi Magnus, I looked at i18n related changes: make/CopyInterimTZDB.gmk make/ToolsJdk.gmk make/gendata/Gendata-java.base.gmk make/gendata/GendataBreakIterator.gmk make/gendata/GendataTZDB.gmk make/gensrc/GensrcCharacterData.gmk make/gensrc/GensrcEmojiData.gmk They look ok to me. The *.java chang

Re: RFR: 8240956: SEGV in DwarfParser::process_dwarf after JDK-8234624

Hi Yasumasa, The mach5 tier5 testing looks good. The serviceability/sa/ClhsdbPstack.java is failed without fix and is not failed with it. Thanks, Serguei On 3/23/20 10:18, [email protected] wrote: Hi

Re: RFR: 8240956: SEGV in DwarfParser::process_dwarf after JDK-8234624

Hi Serguei, Thanks for your comment! I uploaded new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.04/ Also I pushed it to submit repo: http://hg.openjdk.java.net/jdk/submit/rev/fade6a949bd1 On 2020/03/24 7:39, [email protected] wrote: Hi Yasumasa, The mach5 ti

Re: RFR: 8227269: Slow class loading when running JVM in debug mode

Hi Roman, I assume JVMTI maintains separate tagging data for each agent so having two agents doing tagging won't result in confusion. I didn't actually find this in the spec. Would be nice to confirm that it is the case. However, your implementation does seem to conflict with other uses of ta

Re: RFR: 8196751: Add jhsdb option to specify debug server RMI connector port

Hi Daniil, It looks pretty good in general. It looks like you removed the last call site of DebugServer.main. Do we need to remove the DebugServer.java as well? Thanks, Serguei On 3/22/20 15:29, Daniil Titov wrote: Hi Yasumasa, Serguei and Alex, Please review a new version of the webrev tha