Hi,
this is webrev.5 based on Robbin's feedback and Martin's review - thanks! :)
The change affects jvmti, hotspot and c2. Partial reviews are very welcome too.
Full: http://cr.openjdk.java.net/~rrich/webrevs/2019/8227745/webrev.5/
Delta: http://cr.openjdk.java.net/~rrich/webrevs/2019/8227745/w
Hi,
this is webrev.5 based on Robbin's feedback and Martin's review - thanks! :)
The change affects jvmti, hotspot and c2. Partial reviews are very welcome too.
Full: http://cr.openjdk.java.net/~rrich/webrevs/2019/8227745/webrev.5/
Delta: http://cr.openjdk.java.net/~rrich/webrevs/2019/8227745/w
Hi Mandy,
I have just one comment so far.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp.frames.html
356 void add_classes(LoadedClassInfo* first_class, int num_classes,
bool has_class_mirror_holder) {
3
Sorry to jump in on this but it caught my eye though I may be missing a
larger context ...
On 30/03/2020 7:30 pm, [email protected] wrote:
Hi Mandy,
I have just one comment so far.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotspot/share/classfil
No opinions on this?
/Magnus
On 2020-03-25 23:34, Magnus Ihse Bursie wrote:
Hi everyone,
As a follow-up to the ongoing review for JDK-8241618, I have also
looked at fixing the deprecation warnings in jdk.hotspot.agent. These
fall in three broad categories:
* Deprecation of the boxing type
On 3/30/20 5:54 AM, David Holmes wrote:
Sorry to jump in on this but it caught my eye though I may be missing
a larger context ...
On 30/03/2020 7:30 pm, [email protected] wrote:
Hi Mandy,
I have just one comment so far.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-
Adding back serviceability-dev. Sometimes reply (and myself) remembers
it and sometimes it strips it off
Coleen
On 3/30/20 10:16 AM, [email protected] wrote:
On 3/29/20 10:17 PM, Mandy Chung wrote:
On 3/27/20 8:51 PM, Chris Plummer wrote:
Hi Mandy,
A couple of very minor
On 2020-03-25 20:52, Chris Plummer wrote:
Hi Magus,
I haven't looked at the changes yet, other to see that there are many
files touched, but after reading below (and only partly understanding
since I don't know this area well), I was wondering if this issue
wouldn't be better served with m
Hi, This is great work! I did a prereview and all of my comments were
addressed. These are a few minor things I noticed.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotspot/share/ci/ciInstanceKlass.hpp.udiff.html
Nit. Can you add 'const' to the is_hidde
Adding back hotspot-dev.
On 3/30/20 11:02 AM, [email protected] wrote:
Hi, This is great work! I did a prereview and all of my comments
were addressed. These are a few minor things I noticed.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotsp
On 3/30/20 7:16 AM, [email protected] wrote:
I agree with you that this comment needs update. Perhaps it should
say "primitive, array types and hidden classes are non-modifiable. A
modifiable class must be an InstanceKlass."
I may have written the last part of that comment (or r
On 3/30/20 02:30, [email protected] wrote:
Hi Mandy,
I have just one comment so far.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp.frames.html
356 void add_classes(LoadedClassInfo* first_clas
Hi Leonid,
I haven't gone through all the tests yet. I've accumulated enough
questions that I'd like to see them answered or addressed before I
continue on.
This isn't directly related to your changes, but I noticed that users of
JDKToolLauncher do nothing to make sure that default test opt
I was wondering why this is needed when debugging a core file, which is
the key thing we need the SA for:
/** This is used by both the debugger and any runtime system. It is
the basic mechanism by which classes which mimic underlying VM
functionality cause themselves to be initi
This is the patch to keep the JDK 14 behavior if target release to 14
(thanks to Jan for helping making change in javac to get the tests working)
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/webrev-javac-target-release-14/
Mandy
On 3/27/20 9:29 AM, Mandy Chung wrote:
Hi Jan,
Go
Please review the change [1] that fixes the failure of
com/sun/jdi/JdwpListenTest.java
and com/sun/jdi/JdwpAttachTest.java tests on OSX 10.15.
The problem here is the similar to the one solved in [4] by additional filtering
of unusual network interfaces in the test library class
jdk.test.lib.N
Looks good.
--alex
On 03/30/2020 12:43, Daniil Titov wrote:
Please review the change [1] that fixes the failure of
com/sun/jdi/JdwpListenTest.java
and com/sun/jdi/JdwpAttachTest.java tests on OSX 10.15.
The problem here is the similar to the one solved in [4] by additional filtering
of unus
Hi
See my comments inline. I will update webrev after go through all your
comments.
On 3/30/20 11:39 AM, Chris Plummer wrote:
Hi Leonid,
I haven't gone through all the tests yet. I've accumulated enough
questions that I'd like to see them answered or addressed before I
continue on.
Thi
Hi Leonid,
On 3/30/20 5:42 PM, Leonid Mesnik wrote:
Hi
See my comments inline. I will update webrev after go through all your
comments.
On 3/30/20 11:39 AM, Chris Plummer wrote:
Hi Leonid,
I haven't gone through all the tests yet. I've accumulated enough
questions that I'd like to see t
19 matches
Mail list logo
