Re: RFR: 8227337: javax/management/remote/mandatory/connection/ReconnectTest.java NoSuchObjectException no such object in table

2020-07-01 Thread Daniil Titov
Hi Paul, Thank you for reviewing this change. You are right, in most test configurations test.timeout.factor is greater than 1.0. Best regards, Daniil On 6/30/20, 8:50 AM, "Hohensee, Paul" wrote: The JBS issue is non-public, but this looks fine. I assume you set test.timeout.factor to s

Re: RFR (Preliminary): 8248194: Need better support for running SA tests on core files

2020-07-01 Thread Leonid Mesnik
Good idea, I think. So we will have core utils which allow to ensure that core is dumped and help to find them. Leonid > On Jun 29, 2020, at 5:10 PM, Chris Plummer wrote: > > Hi Leonid, > > I'm starting to think that this should all go in a new CoreUtils.java file. I > experimented with mo

RFR: 8248658: Remove vmTestbase/vm/share/vmcrasher

2020-07-01 Thread Leonid Mesnik
Hi Could you please review fix which removes unused code. webrev: http://cr.openjdk.java.net/~lmesnik/8248658/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8248658

Re: RFR: 8248658: Remove vmTestbase/vm/share/vmcrasher

2020-07-01 Thread Chris Plummer
Looks good. Chris On 7/1/20 11:05 AM, Leonid Mesnik wrote: Hi Could you please review fix which removes unused code. webrev: http://cr.openjdk.java.net/~lmesnik/8248658/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8248658

Re: RFR: 8248658: Remove vmTestbase/vm/share/vmcrasher

2020-07-01 Thread [email protected]
Hi Leonid, LGTM++ Thanks, Serguei On 7/1/20 11:32, Chris Plummer wrote: Looks good. Chris On 7/1/20 11:05 AM, Leonid Mesnik wrote: Hi Could you please review fix which removes unused code. webrev: http://cr.openjdk.java.net/~lmesnik/8248658/webrev.00/ bug: https://bugs.openjdk.java.net/b

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

2020-07-01 Thread David Holmes
Hi Yasumasa, On 1/07/2020 11:53 am, Yasumasa Suenaga wrote: Hi, I uploaded new webrev. Could review again?   http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.02/ Updates look fine - thanks. One minor nit: 1274 _collector.allocate_and_fill_stacks(1); 1275 _collector.set_resu