Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

2022-01-11 Thread Severin Gehwolf
On Wed, 1 Dec 2021 19:19:02 GMT, zzambers wrote: > Condition is obviously wrong, because if name starts with "java." other 2 > conditions are always true. Intent, as I understand it, was to redefine class > where debug event took place (in case of test classes), unless it took place > in class

Integrated: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

2022-01-11 Thread zzambers
On Wed, 1 Dec 2021 19:19:02 GMT, zzambers wrote: > Condition is obviously wrong, because if name starts with "java." other 2 > conditions are always true. Intent, as I understand it, was to redefine class > where debug event took place (in case of test classes), unless it took place > in class

Re: RFR: 8225093: Special property jdk.boot.class.path.append should not default to empty string [v3]

2022-01-11 Thread Harold Seigel
On Mon, 20 Dec 2021 18:36:45 GMT, Harold Seigel wrote: >> Please review this fix for JDK-8225093 to set the default value of property >> jdk.boot.class.path.append to NULL instead of "". This fix was tested by >> running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 >> on

Integrated: 8225093: Special property jdk.boot.class.path.append should not default to empty string

2022-01-11 Thread Harold Seigel
On Thu, 16 Dec 2021 17:33:29 GMT, Harold Seigel wrote: > Please review this fix for JDK-8225093 to set the default value of property > jdk.boot.class.path.append to NULL instead of "". This fix was tested by > running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on > Lin

Re: RFR: 8225093: Special property jdk.boot.class.path.append should not default to empty string [v3]

2022-01-11 Thread Harold Seigel
On Mon, 20 Dec 2021 18:36:45 GMT, Harold Seigel wrote: >> Please review this fix for JDK-8225093 to set the default value of property >> jdk.boot.class.path.append to NULL instead of "". This fix was tested by >> running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 >> on

Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

2022-01-11 Thread zzambers
On Tue, 11 Jan 2022 09:11:57 GMT, Severin Gehwolf wrote: >> Condition is obviously wrong, because if name starts with "java." other 2 >> conditions are always true. Intent, as I understand it, was to redefine >> class where debug event took place (in case of test classes), unless it took >> pl