Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases [v3]

2022-01-24 Thread Aleksey Shipilev
> While working on JDK-8280003, I noticed that > java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays > with more than 1-byte size elements, and no large arrays (past 4G limit) are > tested either. It would be better to add those test cases. > > Additional testing: > - [

Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases [v2]

2022-01-24 Thread Aleksey Shipilev
On Fri, 21 Jan 2022 16:19:07 GMT, Leonid Mesnik wrote: > Please update copyright years. Updated, thanks! - PR: https://git.openjdk.java.net/jdk/pull/7132

Re: RFR: 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987 [v3]

2022-01-24 Thread Per Liden
On Thu, 20 Jan 2022 04:22:28 GMT, Chris Plummer wrote: >> The JDWP spec mentions nothing about `DisableCollection` and >> `EnableCollection` tracking the depth or nesting of the commands. This means >> that `EnableCollection` should enable collection no matter how many >> `DisableCollection` c

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v2]

2022-01-24 Thread Alex Menkov
> Changes: > - ClassFileReconstituter is updated to restore "MethodParameters" attribute; > - handling of the attribute in VM_RedefineClasses is moved to be consistent > with other code (like local variable table); > - copied ClassTransformer class (from test/jdk/com/sun/jdi/lib/jdb) to > /test/l

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v2]

2022-01-24 Thread Alex Menkov
On Fri, 21 Jan 2022 19:02:39 GMT, Serguei Spitsyn wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed condition > > src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 3684: > >> 3682: // Update constant po

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Daniel Fuchs
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by dfuchs (Reviewer). LGTM. I hope in the future IDEs will pick that rule up and offer some help when writing `{@link }` `@see`... - PR: https://git

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Pavel Rappo
On Mon, 24 Jan 2022 11:00:37 GMT, Daniel Fuchs wrote: > LGTM. I hope in the future IDEs will pick that rule up and offer some help > when writing `{@link }` `@see`... They will do it quicker, if you create new or support existing bugs in their bug trackers. - PR: https://git.open

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Pavel Rappo
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Is that a wrong bug? If you are talking about module-prefix syntax for links, then it was introduced in JDK 15; JDK-8164408: Add module support for @see, @link and @linkplain javado

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-24 Thread Joe Darcy
On Mon, 24 Jan 2022 11:33:18 GMT, Pavel Rappo wrote: > > Use presumed syntax that will be introduced by JDK-8280488. > > Is that a wrong bug? If you are talking about module-prefix syntax for links, > then it was introduced in JDK 15; JDK-8164408: Add module support for @see, > @link and @link

Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links

2022-01-24 Thread Alexey Ivanov
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by aivanov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189

Re: RFR: JDK-8280492: Use cross-module syntax for cross-module links [v2]

2022-01-24 Thread Joe Darcy
> Use presumed syntax that will be introduced by JDK-8280488. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since t

Integrated: JDK-8280492: Use cross-module syntax for cross-module links

2022-01-24 Thread Joe Darcy
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This pull request has now been integrated. Changeset: 8e82d002 Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/8e82d0021c119b7793870811fad37d7659c1174d Stat

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v3]

2022-01-24 Thread Ioi Lam
On Mon, 24 Jan 2022 07:41:44 GMT, Thomas Stuefe wrote: >> JDK-8249944 moved AllStatic to its own header. We should use that one >> instead of allocation.hpp where possible to reduce header dependencies. >> >> This patch: >> - replaces includes of allocation.hpp with allstatic.hpp where appropia