Integrated: 8290489: Initial nroff manpage generation for JDK 20

2022-07-21 Thread David Holmes
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote: > The version will be 20-ea and the copyright year 2023 (for March 2023 release > date). > > Thanks. This pull request has now been integrated. Changeset: e9f97b2e Author:David Holmes URL: https://git.openjdk.org/jdk/commit/e9f

Re: RFR: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

2022-07-21 Thread Leonid Mesnik
On Fri, 22 Jul 2022 00:52:37 GMT, Chris Plummer wrote: >> Yes, ZGC reports dash for eden and survivor spaces. > > So shouldn't we have ZGC test failures then? No, test passes with ZGC. - PR: https://git.openjdk.org/jdk/pull/9604

Re: RFR: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

2022-07-21 Thread Chris Plummer
On Fri, 22 Jul 2022 00:03:26 GMT, Leonid Mesnik wrote: >> test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48: >> >>> 46: S0(GcStatisticsType.PERCENTAGE_OR_DASH), >>> 47: S1(GcStatisticsType.PERCENTAGE_OR_DASH), >>> 48: E(GcStatisticsType.PERCENTAGE_OR_DASH), >> >>

Re: RFR: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

2022-07-21 Thread Leonid Mesnik
On Thu, 21 Jul 2022 23:01:55 GMT, Chris Plummer wrote: >> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the >> output of non-generation (ZGC) GC as valid. > > test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48: > >> 46: S0(GcStatisticsType.PERCENTAGE_OR_DAS

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v18]

2022-07-21 Thread Serguei Spitsyn
On Thu, 21 Jul 2022 19:18:28 GMT, Zhengyu Gu wrote: > I pushed update that removed the block, could you please run it through > Oracle's internal tests? I think, you can run all the needed tests by yourself. But I'll also submit mach5 jobs to be safe. - PR: https://git.openjdk.org

Re: RFR: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

2022-07-21 Thread Chris Plummer
On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik wrote: > Propagate test.vm.opts/test.java.opts to tested process. Also, accept the > output of non-generation (ZGC) GC as valid. test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48: > 46: S0(GcStatisticsType.PERCENTAGE_OR_DASH), > 47

RFR: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

2022-07-21 Thread Leonid Mesnik
Propagate test.vm.opts/test.java.opts to tested process. Also, accept the output of non-generation (ZGC) GC as valid. - Commit messages: - 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options Changes: https://git.openjdk.org/jdk/pull/9604/files Webrev: https://webrevs

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-21 Thread Serguei Spitsyn
On Thu, 21 Jul 2022 15:31:48 GMT, Chris Plummer wrote: > This becomes a problem when the test tries to free a raw monitor on exit. It > first disable events, then it frees the raw monitor that the even handler > synchronizes on. However, it's possible that an event can be in flight when > doin

Integrated: 8290687: serviceability/sa/TestClassDump.java could leave files owned by root on macOS

2022-07-21 Thread Chris Plummer
On Wed, 20 Jul 2022 22:21:52 GMT, Chris Plummer wrote: > Unless this test is run as root, it needs sudo privileges. If it gets them, > the test runs fine, but leaves around files with root ownership so jtreg > cannot delete them, and you see errors when "make clean" tries to delete > them. It'

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v18]

2022-07-21 Thread Zhengyu Gu
On Thu, 21 Jul 2022 13:33:01 GMT, Zhengyu Gu wrote: >> Hi, it was added because some tests were failing. With the concurrent >> posting, we were missing events and flushing them made the tests pass. > >> Hi, it was added because some tests were failing. With the concurrent >> posting, we were

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v19]

2022-07-21 Thread Zhengyu Gu
> Currently, jdi only check and process class unloading event when it detects a > new GC cycle. > > After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting > class events can overlap with GC finish event, that results, sometimes, it > only captures partial or even empty unload

Integrated: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended

2022-07-21 Thread Alex Menkov
On Mon, 18 Jul 2022 23:13:14 GMT, Alex Menkov wrote: > The test verifies that JDI threads are daemon threads. > But enumerating threads at breakpoint it performs sanity check that all > threads returned by ThreadGroup.enumerate hasn't terminated. > But this is wrong assumption, as the test enum

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-21 Thread Chris Plummer
On Thu, 21 Jul 2022 05:42:49 GMT, Serguei Spitsyn wrote: > > That wasn't quite what I was getting at. My comment / question was much > > more general. If you call SetEventNotificationMode() to disable a specific > > event, once it returns are you guaranteed that no more events will be > > deli

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v18]

2022-07-21 Thread Chris Plummer
On Thu, 21 Jul 2022 13:33:01 GMT, Zhengyu Gu wrote: >> Hi, it was added because some tests were failing. With the concurrent >> posting, we were missing events and flushing them made the tests pass. > >> Hi, it was added because some tests were failing. With the concurrent >> posting, we were

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v18]

2022-07-21 Thread Coleen Phillimore
On Thu, 21 Jul 2022 13:33:01 GMT, Zhengyu Gu wrote: >> Hi, it was added because some tests were failing. With the concurrent >> posting, we were missing events and flushing them made the tests pass. > >> Hi, it was added because some tests were failing. With the concurrent >> posting, we were

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v18]

2022-07-21 Thread Serguei Spitsyn
On Thu, 21 Jul 2022 13:33:01 GMT, Zhengyu Gu wrote: > > Hi, it was added because some tests were failing. With the concurrent > > posting, we were missing events and flushing them made the tests pass. > > Thanks, @coleenp Can you recall what were those tests? > > I removed the block and passed

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v18]

2022-07-21 Thread Zhengyu Gu
On Thu, 21 Jul 2022 13:18:25 GMT, Coleen Phillimore wrote: > Hi, it was added because some tests were failing. With the concurrent > posting, we were missing events and flushing them made the tests pass. Thanks, @coleenp Can you recall what were those tests? I removed the block and passed vm

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v18]

2022-07-21 Thread Coleen Phillimore
On Mon, 18 Jul 2022 23:12:00 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: RFR: 8290525: Move HeapRegion::_compaction_top to G1FullCollector [v2]

2022-07-21 Thread Kim Barrett
On Thu, 21 Jul 2022 08:02:05 GMT, Thomas Schatzl wrote: >> Hi all, >> >> can I have reviews for this change that moves >> `HeapRegion::_compaction_top` into the `G1FullCollector` class; my reasoning >> is that these values are transient temporary values only ever useful for the >> full coll

Re: RFR: 8290525: Move HeapRegion::_compaction_top to G1FullCollector [v2]

2022-07-21 Thread Thomas Schatzl
> Hi all, > > can I have reviews for this change that moves `HeapRegion::_compaction_top` > into the `G1FullCollector` class; my reasoning is that these values are > transient temporary values only ever useful for the full collection > algorithm, basically results of the application of the al