Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-02 Thread Ao Qi
On Tue, 2 Aug 2022 17:25:19 GMT, Alan Bateman wrote: > Just an FYI that the [ORDER OF > TAGS](https://openjdk.org/jtreg/tag-spec.html#ORDER) section of the tag > language spec recommends putting the `@requires` before the `@modules` and > `@library` tags. Done. Didn't know that. Thank you for

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v5]

2022-08-02 Thread Ao Qi
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and > `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` > are added or modified by > [JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161), and they are > failed if Loom or JVMTI is

Integrated: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM

2022-08-02 Thread Serguei Spitsyn
On Mon, 1 Aug 2022 07:41:50 GMT, Serguei Spitsyn wrote: > This is a regression that has been introduced by the fix of: > [8256811](https://bugs.openjdk.org/browse/JDK-8256811): Delayed/missed jdwp > class unloading events > > This is the relevant comment from Zhengyu: > > It is caused by https

Re: RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM

2022-08-02 Thread Serguei Spitsyn
On Mon, 1 Aug 2022 07:41:50 GMT, Serguei Spitsyn wrote: > This is a regression that has been introduced by the fix of: > [8256811](https://bugs.openjdk.org/browse/JDK-8256811): Delayed/missed jdwp > class unloading events > > This is the relevant comment from Zhengyu: > > It is caused by https

Re: RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM

2022-08-02 Thread Alex Menkov
On Mon, 1 Aug 2022 07:41:50 GMT, Serguei Spitsyn wrote: > This is a regression that has been introduced by the fix of: > [8256811](https://bugs.openjdk.org/browse/JDK-8256811): Delayed/missed jdwp > class unloading events > > This is the relevant comment from Zhengyu: > > It is caused by https

Integrated: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath

2022-08-02 Thread Chris Plummer
On Mon, 1 Aug 2022 21:02:39 GMT, Chris Plummer wrote: > Near the end of the test, the debuggee forces a GC so ClassUnloadEvents will > be generated, and then the debuggee immediately exits. However, the > ClassUnloadEvents might not be sent out before the VMDeath is generated, and > it prevent

Integrated: 8291578: Remove JMX related tests from ProblemList-svc-vthreads.txt

2022-08-02 Thread Chris Plummer
On Mon, 1 Aug 2022 20:05:02 GMT, Chris Plummer wrote: > These tests do not belong in ProblemList-svc-vthreads.txt. This problem list > is meant for tests that fail when the debuggee is run with the virtual thread > wrapper. These tests are not setup to run in that mode, and therefore never > a

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-02 Thread Dean Long
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >

Re: RFR: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath

2022-08-02 Thread Alex Menkov
On Mon, 1 Aug 2022 21:02:39 GMT, Chris Plummer wrote: > Near the end of the test, the debuggee forces a GC so ClassUnloadEvents will > be generated, and then the debuggee immediately exits. However, the > ClassUnloadEvents might not be sent out before the VMDeath is generated, and > it prevent

Re: RFR: 8291578: Remove JMX related tests from ProblemList-svc-vthreads.txt

2022-08-02 Thread Leonid Mesnik
On Mon, 1 Aug 2022 20:05:02 GMT, Chris Plummer wrote: > These tests do not belong in ProblemList-svc-vthreads.txt. This problem list > is meant for tests that fail when the debuggee is run with the virtual thread > wrapper. These tests are not setup to run in that mode, and therefore never > a

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-02 Thread Leonid Mesnik
On Tue, 2 Aug 2022 06:32:09 GMT, Ao Qi wrote: >> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and >> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` >> are added or modified by >> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8291578: Remove JMX related tests from ProblemList-svc-vthreads.txt

2022-08-02 Thread Kevin Walls
On Mon, 1 Aug 2022 20:05:02 GMT, Chris Plummer wrote: > These tests do not belong in ProblemList-svc-vthreads.txt. This problem list > is meant for tests that fail when the debuggee is run with the virtual thread > wrapper. These tests are not setup to run in that mode, and therefore never > a

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-02 Thread Alan Bateman
On Tue, 2 Aug 2022 06:32:09 GMT, Ao Qi wrote: >> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and >> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` >> are added or modified by >> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v2]

2022-08-02 Thread Axel Boldt-Christmas
On Mon, 1 Aug 2022 04:58:49 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj { >