On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote:
> It's a bit shorter and clearer.
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9816
On Thu, 11 Aug 2022 16:45:54 GMT, Chris Plummer wrote:
>> We currently have no tests for co-located MethodEntry, Step, and Breakpoint
>> events. We should make sure they are being properly co-located as described
>> in the JDI spec, and also do special test cases for
>> [JDK-8292217](https://b
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote:
> It's a bit shorter and clearer.
Approving (just) the client change
-
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9816
> The proposal is to encapsulate the nmethod mark for deoptimization logic in
> one place and only allow access to the `mark_for_deoptimization` from a
> closure object:
> ```C++
> class DeoptimizationMarkerClosure : StackObj {
> public:
> virtual void marker_do(Deoptimization::MarkFn mark_fn)
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote:
> It's a bit shorter and clearer.
Also, it avoids unnecessary boxing.
-
PR: https://git.openjdk.org/jdk/pull/9816
It's a bit shorter and clearer.
-
Commit messages:
- [PATCH] Use static methods for hashCode/toString primitives
Changes: https://git.openjdk.org/jdk/pull/9816/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9816&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8292350
