On Thu, 6 Oct 2022 02:24:12 GMT, Alex Menkov wrote:
> Test failure is a duplicate of
> [JDK-8284777](https://bugs.openjdk.org/browse/JDK-8284777), but the test
> needs to be updated:
> - the test instruments all loaded classes, so need to updated ASM version to
> support records and permits;
>
Test failure is a duplicate of
[JDK-8284777](https://bugs.openjdk.org/browse/JDK-8284777), but the test needs
to be updated:
- the test instruments all loaded classes, so need to updated ASM version to
support records and permits;
Instrumentor.addNativeMethodTrackingInjection is used only by t
The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require the
target thread to be suspended. If not suspended then the
JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the implementation.
The CSR is: https://bugs.openjdk.org/browse/JDK-8294690
A few tests are impacted
On Tue, 4 Oct 2022 18:42:45 GMT, Chris Plummer wrote:
>> The bug is due to the debug agent still having a reference to one of the
>> classes when the full GC is issued by the debuggee, thus keeping the classes
>> loaded. The debug agent it about to free the reference, but doesn't do it
>> quit
On Tue, 4 Oct 2022 17:59:36 GMT, Alan Bateman wrote:
> This is a test only change for two tests for virtual threads that
> hang/timeout on single core systems. The two tests involve pinning and
> require at least two carrier threads. The test lib used by these tests is
> updated to define a ne
On Wed, 5 Oct 2022 19:58:24 GMT, Alan Bateman wrote:
>> It's not a matter of whether or not the test needs to restore it. It _will_
>> restore it if there is a GC, and if this happens before the test completes,
>> it could find itself without enough carrier threads.
>
> No, restoration requires
On Wed, 5 Oct 2022 19:44:44 GMT, Chris Plummer wrote:
>> This test doesn't need to restore it so it doesn't keep a reference and not
>> an issue if it is GC'ed.
>
> It's not a matter of whether or not the test needs to restore it. It _will_
> restore it if there is a GC, and if this happens bef
On Wed, 5 Oct 2022 19:30:46 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java line
>> 30:
>>
>>> 28: * platform and virtual threads in deadlock
>>> 29: * @enablePreview
>>> 30: * @modules java.base/java.lang:+open java.management
>>
>> Can
On Wed, 5 Oct 2022 19:02:04 GMT, Chris Plummer wrote:
>> This is a test only change for two tests for virtual threads that
>> hang/timeout on single core systems. The two tests involve pinning and
>> require at least two carrier threads. The test lib used by these tests is
>> updated to define
On Tue, 4 Oct 2022 17:59:36 GMT, Alan Bateman wrote:
> This is a test only change for two tests for virtual threads that
> hang/timeout on single core systems. The two tests involve pinning and
> require at least two carrier threads. The test lib used by these tests is
> updated to define a ne
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
LGTM
-
Marked as reviewed
On Tue, 4 Oct 2022 18:42:45 GMT, Chris Plummer wrote:
>> The bug is due to the debug agent still having a reference to one of the
>> classes when the full GC is issued by the debuggee, thus keeping the classes
>> loaded. The debug agent it about to free the reference, but doesn't do it
>> quit
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote:
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
This pull request has now been i
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base due to a merge or
a re
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
Marked as reviewed by mullan (Reviewer)
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
Changes to java.net and javax.managemen
This is a test only change to remove the granting of
RuntimePermission("stopThread") from the tests. With Thread.stop changed to
throw UOE it means there is nothing that requires this permission.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/10577/f
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
Hi,
I appreciate a lot the new name, especially replacing call trace by
stack trace, because it is stack traces that are handled by the API.
Maybe adding "native" might be a good idea, because it can also
handle native frames? I think this is a distinguishing feature
of this API.
Best regards,
This is a test only change for two tests for virtual threads that hang/timeout
on single core systems. The two tests involve pinning and require at least two
carrier threads. The test lib used by these tests is updated to define a new
method that ensures parallelism is at least a given value and
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
22 matches
Mail list logo