Re: RFR: 8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8"

2022-10-05 Thread Leonid Mesnik
On Thu, 6 Oct 2022 02:24:12 GMT, Alex Menkov wrote: > Test failure is a duplicate of > [JDK-8284777](https://bugs.openjdk.org/browse/JDK-8284777), but the test > needs to be updated: > - the test instruments all loaded classes, so need to updated ASM version to > support records and permits; >

RFR: 8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8"

2022-10-05 Thread Alex Menkov
Test failure is a duplicate of [JDK-8284777](https://bugs.openjdk.org/browse/JDK-8284777), but the test needs to be updated: - the test instruments all loaded classes, so need to updated ASM version to support records and permits; Instrumentor.addNativeMethodTrackingInjection is used only by t

RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread

2022-10-05 Thread Serguei Spitsyn
The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require the target thread to be suspended. If not suspended then the JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the implementation. The CSR is: https://bugs.openjdk.org/browse/JDK-8294690 A few tests are impacted

Re: RFR: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading [v2]

2022-10-05 Thread Serguei Spitsyn
On Tue, 4 Oct 2022 18:42:45 GMT, Chris Plummer wrote: >> The bug is due to the debug agent still having a reference to one of the >> classes when the full GC is issued by the debuggee, thus keeping the classes >> loaded. The debug agent it about to free the reference, but doesn't do it >> quit

Re: RFR: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

2022-10-05 Thread Serguei Spitsyn
On Tue, 4 Oct 2022 17:59:36 GMT, Alan Bateman wrote: > This is a test only change for two tests for virtual threads that > hang/timeout on single core systems. The two tests involve pinning and > require at least two carrier threads. The test lib used by these tests is > updated to define a ne

Re: RFR: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

2022-10-05 Thread Chris Plummer
On Wed, 5 Oct 2022 19:58:24 GMT, Alan Bateman wrote: >> It's not a matter of whether or not the test needs to restore it. It _will_ >> restore it if there is a GC, and if this happens before the test completes, >> it could find itself without enough carrier threads. > > No, restoration requires

Re: RFR: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

2022-10-05 Thread Alan Bateman
On Wed, 5 Oct 2022 19:44:44 GMT, Chris Plummer wrote: >> This test doesn't need to restore it so it doesn't keep a reference and not >> an issue if it is GC'ed. > > It's not a matter of whether or not the test needs to restore it. It _will_ > restore it if there is a GC, and if this happens bef

Re: RFR: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

2022-10-05 Thread Chris Plummer
On Wed, 5 Oct 2022 19:30:46 GMT, Alan Bateman wrote: >> test/jdk/java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java line >> 30: >> >>> 28: * platform and virtual threads in deadlock >>> 29: * @enablePreview >>> 30: * @modules java.base/java.lang:+open java.management >> >> Can

Re: RFR: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

2022-10-05 Thread Alan Bateman
On Wed, 5 Oct 2022 19:02:04 GMT, Chris Plummer wrote: >> This is a test only change for two tests for virtual threads that >> hang/timeout on single core systems. The two tests involve pinning and >> require at least two carrier threads. The test lib used by these tests is >> updated to define

Re: RFR: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

2022-10-05 Thread Chris Plummer
On Tue, 4 Oct 2022 17:59:36 GMT, Alan Bateman wrote: > This is a test only change for two tests for virtual threads that > hang/timeout on single core systems. The two tests involve pinning and > require at least two carrier threads. The test lib used by these tests is > updated to define a ne

Re: RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Mandy Chung
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote: > This is a test only change to remove the granting of > RuntimePermission("stopThread") from the tests. With Thread.stop changed to > throw UOE it means there is nothing that requires this permission. LGTM - Marked as reviewed

Re: RFR: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading [v2]

2022-10-05 Thread Coleen Phillimore
On Tue, 4 Oct 2022 18:42:45 GMT, Chris Plummer wrote: >> The bug is due to the debug agent still having a reference to one of the >> classes when the full GC is issued by the debuggee, thus keeping the classes >> loaded. The debug agent it about to free the reference, but doesn't do it >> quit

Integrated: JDK-8294618: Update openjdk.java.net => openjdk.org

2022-10-05 Thread Joe Darcy
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote: > With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. This pull request has now been i

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v9]

2022-10-05 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request with a new target base due to a merge or a re

Re: RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Sean Mullan
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote: > This is a test only change to remove the granting of > RuntimePermission("stopThread") from the tests. With Thread.stop changed to > throw UOE it means there is nothing that requires this permission. Marked as reviewed by mullan (Reviewer)

Re: RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Daniel Fuchs
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote: > This is a test only change to remove the granting of > RuntimePermission("stopThread") from the tests. With Thread.stop changed to > throw UOE it means there is nothing that requires this permission. Changes to java.net and javax.managemen

RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Alan Bateman
This is a test only change to remove the granting of RuntimePermission("stopThread") from the tests. With Thread.stop changed to throw UOE it means there is nothing that requires this permission. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jdk/pull/10577/f

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-10-05 Thread Alexey Ivanov
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote: >> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni > > Michael Ernst has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Reinstate t

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-10-05 Thread Alexey Ivanov
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote: >> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni > > Michael Ernst has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Reinstate t

RE: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-05 Thread Lindenmaier, Goetz
Hi, I appreciate a lot the new name, especially replacing call trace by stack trace, because it is stack traces that are handled by the API. Maybe adding "native" might be a good idea, because it can also handle native frames? I think this is a distinguishing feature of this API. Best regards,

RFR: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

2022-10-05 Thread Alan Bateman
This is a test only change for two tests for virtual threads that hang/timeout on single core systems. The two tests involve pinning and require at least two carrier threads. The test lib used by these tests is updated to define a new method that ensures parallelism is at least a given value and

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v8]

2022-10-05 Thread Magnus Ihse Bursie
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated the