On Mon, 14 Nov 2022 20:39:47 GMT, Joe Darcy wrote:
>> Update the compile command in JdbLastErrorTest.java so that it doesn't need
>> to be modified with each new JDK release to keep using preview features.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit sin
On Mon, 14 Nov 2022 13:19:38 GMT, Kevin Walls wrote:
> This is a (trivial) change of the @requires statement in a test:
> don't run in -Xcomp or -Xint modes, where the interaction of Windows' native
> GetLastError and Panama direct native access are known not to work well
> together.
>
> Remo
On Mon, 14 Nov 2022 20:39:47 GMT, Joe Darcy wrote:
>> Update the compile command in JdbLastErrorTest.java so that it doesn't need
>> to be modified with each new JDK release to keep using preview features.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit sin
On Mon, 14 Nov 2022 13:19:38 GMT, Kevin Walls wrote:
> This is a (trivial) change of the @requires statement in a test:
> don't run in -Xcomp or -Xint modes, where the interaction of Windows' native
> GetLastError and Panama direct native access are known not to work well
> together.
>
> Remo
On Mon, 14 Nov 2022 08:02:49 GMT, David Holmes wrote:
>> Yep, it was renamed since the file is also named VISCPP, and I felt that
>> matching the names was a good style change
>
> I think it is the file that has the "bad" name in this case. :( But okay.
I also think the macro name should be lef
On Tue, 15 Nov 2022 00:49:59 GMT, Julian Waters wrote:
>> make/hotspot/lib/CompileJvm.gmk line 67:
>>
>>> 65: # Hotspot cannot handle an empty build number
>>> 66: VERSION_BUILD := 0
>>> 67: endif
>>
>> I think the proposed "solution" is *much* worse than this.
>
> Reverted to use the origi
On Mon, 14 Nov 2022 16:12:48 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features t
On Thu, 10 Nov 2022 22:42:10 GMT, Ioi Lam wrote:
> Here's redo for https://github.com/openjdk/jdk/pull/10687. This PR has two
> commits:
> - 739b79afb1965b625b2002187ac3fd43f385a639 is the same as in the original PR
> - 78455c024ec5c00f1a0ce6c0e13df477c3063fe1 fixes the bug in the original PR.
>
On Fri, 11 Nov 2022 03:17:58 GMT, Chris Plummer wrote:
> Get rid of `list` argument in debug agent's `removeNode()` API. The list is
> stored in the node, so no need to pass it in.
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.or
On Fri, 11 Nov 2022 00:43:33 GMT, Alex Menkov wrote:
> Changes:
> - removed `` from TOC;
> - added CSS style for TOC (to simplify customization, currently it's empty);
> - removed `` from from function list (per Phase);
> - removed `` from from list of events;
> - introduced CSS style for bold te
On Mon, 14 Nov 2022 17:32:13 GMT, Leonid Mesnik wrote:
>> Change Thread.resume() to error reporting and add some time to complete
>> thread.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed after Chris's comments
Lo
On Mon, 14 Nov 2022 13:08:56 GMT, Kim Barrett wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert to using simpler solution similar to the original 8274980
>
> make/hotspot/lib/CompileJvm.gmk line 67:
>
>> 65:
On Fri, 28 Oct 2022 09:32:58 GMT, Roman Kennke wrote:
>> This change replaces the current stack-locking implementation with a
>> fast-locking scheme that retains the advantages of stack-locking (namely
>> fast locking in uncontended code-paths), while avoiding the overload of the
>> mark word.
On Fri, 28 Oct 2022 01:47:23 GMT, David Holmes wrote:
> So the data structure for lock records (per thread) could consist of a series
> of distinct values [ A B C ] and each of the values could be repeated, but
> only adjacently: [ A A A B C C ] for example.
> @rose00 why only adjacently? Neste
On Mon, 14 Nov 2022 13:19:38 GMT, Kevin Walls wrote:
> This is a (trivial) change of the @requires statement in a test:
> don't run in -Xcomp or -Xint modes, where the interaction of Windows' native
> GetLastError and Panama direct native access are known not to work well
> together.
>
> Remo
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
>
On Mon, 14 Nov 2022 20:39:47 GMT, Joe Darcy wrote:
>> Update the compile command in JdbLastErrorTest.java so that it doesn't need
>> to be modified with each new JDK release to keep using preview features.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit sin
On Mon, 14 Nov 2022 19:04:49 GMT, Pavel Rappo wrote:
> Please review this trivial documentation change that fixes a typo
> accidentally found while comparing javadoc output for an unrelated change in
> jdk.javadoc.
Marked as reviewed by dfuchs (Reviewer).
-
PR: https://git.openjd
> Update the compile command in JdbLastErrorTest.java so that it doesn't need
> to be modified with each new JDK release to keep using preview features.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update.
-
Changes:
On Mon, 14 Nov 2022 19:13:22 GMT, Alan Bateman wrote:
>> Is that a new jtreg feature? I've used the idiom in the updated version of
>> this file elsewhere in the JDK.
>
> https://bugs.openjdk.org/browse/CODETOOLS-7902654
> I only became aware of it a few months ago.
Thanks @AlanBateman; I wasn'
On Mon, 31 Oct 2022 19:08:14 GMT, Chris Plummer wrote:
> The debug agent sets a breakpoint in Thread.resume() so it can prevent the
> debugger from suspending threads while in the resume call:
>
> /*
> * Track the resuming thread by marking it as being within
>
> Update the compile command in JdbLastErrorTest.java so that it doesn't need
> to be modified with each new JDK release to keep using preview features.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
--
On Mon, 14 Nov 2022 19:04:49 GMT, Pavel Rappo wrote:
> Please review this trivial documentation change that fixes a typo
> accidentally found while comparing javadoc output for an unrelated change in
> jdk.javadoc.
Looks like a day 1 bug. Changes look good.
-
Marked as reviewed b
On Thu, 10 Nov 2022 20:58:36 GMT, Chris Plummer wrote:
>> The debug agent sets a breakpoint in Thread.resume() so it can prevent the
>> debugger from suspending threads while in the resume call:
>>
>> /*
>> * Track the resuming thread by marking it as being within
>>
Please review this trivial documentation change that fixes a typo accidentally
found while comparing javadoc output for an unrelated change in jdk.javadoc.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/11140/files
Webrev: https://webrevs.openjdk.org
On Mon, 14 Nov 2022 13:19:38 GMT, Kevin Walls wrote:
> This is a (trivial) change of the @requires statement in a test:
> don't run in -Xcomp or -Xint modes, where the interaction of Windows' native
> GetLastError and Panama direct native access are known not to work well
> together.
>
> Remo
On Mon, 14 Nov 2022 19:09:10 GMT, Joe Darcy wrote:
>> test/jdk/com/sun/jdi/JdbLastErrorTest.java line 31:
>>
>>> 29: * @library /test/lib
>>> 30: * @run compile --release ${jdk.version} --enable-preview
>>> JdbLastErrorTest.java
>>> 31: * @run main/othervm --enable-preview JdbLastErrorTest
>
On Mon, 14 Nov 2022 19:07:42 GMT, Alan Bateman wrote:
>> Update the compile command in JdbLastErrorTest.java so that it doesn't need
>> to be modified with each new JDK release to keep using preview features.
>
> test/jdk/com/sun/jdi/JdbLastErrorTest.java line 31:
>
>> 29: * @library /test/lib
On Mon, 14 Nov 2022 18:49:14 GMT, Joe Darcy wrote:
> Update the compile command in JdbLastErrorTest.java so that it doesn't need
> to be modified with each new JDK release to keep using preview features.
test/jdk/com/sun/jdi/JdbLastErrorTest.java line 31:
> 29: * @library /test/lib
> 30: * @
Update the compile command in JdbLastErrorTest.java so that it doesn't need to
be modified with each new JDK release to keep using preview features.
-
Commit messages:
- JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java
Changes: https://git.openjdk.org/jdk/pull/111
On Fri, 11 Nov 2022 07:01:19 GMT, Alan Bateman wrote:
> This is good cleanup, I had forgotten that the JDWP agent has code to defend
> against direct use of Thread.resume. The changes look good. Somewhat
> subjective, but I think I would have made the comment in commonSuspendByNode
> just say
On Mon, 14 Nov 2022 17:32:13 GMT, Leonid Mesnik wrote:
>> Change Thread.resume() to error reporting and add some time to complete
>> thread.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed after Chris's comments
Ma
On Mon, 14 Nov 2022 14:19:48 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
> Change Thread.resume() to error reporting and add some time to complete
> thread.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
fixed after Chris's comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1087
> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
> code across the JDK can be replaced and simplified with cleaner language
> features that were previously not available due to required compatibili
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
>
On Mon, 14 Nov 2022 14:19:48 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
On Mon, 14 Nov 2022 11:36:21 GMT, Christoph Langer wrote:
> Hm, I also don't like the code duplication...
Code duplication is gone. Just one test file with two @run tags.
-
PR: https://git.openjdk.org/jdk/pull/11083
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8296709: use multiple @run tags instead of multiple files
-
On Mon, 14 Nov 2022 01:42:40 GMT, Julian Waters wrote:
>> make/autoconf/flags-cflags.m4 line 632:
>>
>>> 630: if test "x$TOOLCHAIN_TYPE" = xgcc || test "x$TOOLCHAIN_TYPE" =
>>> xclang; then
>>> 631: STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS -ffunction-sections
>>> -fdata-sections \
>>> 632
On Mon, 14 Nov 2022 04:14:24 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features t
This is a (trivial) change of the @requires statement in a test:
don't run in -Xcomp or -Xint modes, where the interaction of Windows' native
GetLastError and Panama direct native access are known not to work well
together.
Remove test/jdk/ProblemList-Xcomp.txt entry for this test.
Running jtr
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
>
On Mon, 14 Nov 2022 08:01:27 GMT, David Holmes wrote:
>> I'm not sure I follow, I didn't remove anything here?
>
> Sorry my eyes must be playing tricks on me. ??
>
> Why did you need to add this here?
It's to avoid redefining the linkage as static in os_windows.cpp (where it's
implemented) aft
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
>
On Mon, 14 Nov 2022 08:08:40 GMT, David Holmes wrote:
>> The ATTRIBUTE_PRINTF macros are still there, just moved in front of the
>> methods
>
> Wow I'm really having eyesight problems today! Sorry about that.
Haha, no worries
-
PR: https://git.openjdk.org/jdk/pull/11081
On Fri, 11 Nov 2022 21:21:43 GMT, Kim Barrett wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> One of the more prevalent issues is that files in src/hotspot/share/include
>> are not properly sorted. There has
On Mon, 14 Nov 2022 11:07:52 GMT, Lutz Schmidt wrote:
> > Couldn't you simply add a second `doExec` statement in the existing test
> > rather than copy the entire test file?
>
> Actually, I first did it that way. And I did not like it. It's not just the
> doExec, you need to duplicate the chec
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Lutz Schmidt has updated the pull request incrementally with two additional
commits since the last revision:
- 8296709: typo
- 8296709: Copyright year and more specific summary text
On Sun, 13 Nov 2022 23:51:28 GMT, David Holmes wrote:
> Couldn't you simply add a second `doExec` statement in the existing test
> rather than copy the entire test file?
Actually, I first did it that way. And I did not like it. It's not just the
doExec, you need to duplicate the checks as well
On Mon, 14 Nov 2022 08:28:04 GMT, Thomas Stuefe wrote:
> unfortunately, your patch will make backporting more difficult. We cannot
> downport it to older releases compiled with older compilers. But since it
> touches a lot of files it will sit smack in the middle of patch sequences,
> requirin
On Fri, 11 Nov 2022 23:01:12 GMT, Christoph Langer wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8296709: fix testcase naming
>
> test/jdk/tools/launcher/TestXcheckJdwpJNIWarnings.java line 2:
>
>> 1: /*
>> 2:
On Mon, 14 Nov 2022 10:43:23 GMT, Stefan Karlsson wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix verification and RISC-V support
>
> Looks good to me. I wrote parts of this code, so I want wan extra Reviewer
On Mon, 14 Nov 2022 10:15:41 GMT, Erik Österlund wrote:
>> The current loom code makes some assumptions about GC that will not work
>> with generational ZGC. We should make this code more GC agnostic, and
>> provide a better interface for talking to the GC.
>>
>> In particular,
>> 1) All GCs h
On Sat, 12 Nov 2022 08:08:15 GMT, Fei Yang wrote:
> PS: I see JVM crashes when running Skynet with extra VM option:
> -XX:+VerifyContinuations on linux-aarch64 platform.
>
> $java --enable-preview -XX:+VerifyContinuations Skynet
>
> ```
> # A fatal error has been detected by the Java Runtime E
On Sat, 12 Nov 2022 01:30:57 GMT, Fei Yang wrote:
> > Nice to have PR 1. It's gonna take a long time until we see 11.
>
> Nice PR number :-) May I ask if you could also add handling for riscv while
> you are at it? We have ported loom to this platform recently [1]. I can help
> perform
> The current loom code makes some assumptions about GC that will not work with
> generational ZGC. We should make this code more GC agnostic, and provide a
> better interface for talking to the GC.
>
> In particular,
> 1) All GCs have a way of encoding oops inside of the heap differently to oop
One of the more prevalent issues is that files in src/hotspot/share/include are
not properly sorted. There has been some discussion that that was done on
purpose, but it just adds another exception to the include rules that don't
have any practical purposes, IMHO. It also goes against our writte
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has b
On Mon, 14 Nov 2022 04:14:24 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features t
On Mon, 14 Nov 2022 01:39:17 GMT, Julian Waters wrote:
>> src/hotspot/share/utilities/debug.hpp line 172:
>>
>>> 170: int status, const char* detail);
>>> 171: ATTRIBUTE_PRINTF(4, 5)
>>> 172: void report_fatal(VMErrorType error_type, const char* file, int line,
>>> c
On Mon, 14 Nov 2022 01:17:38 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/os_windows.hpp line 35:
>>
>>> 33: class Thread;
>>> 34:
>>> 35: static unsigned __stdcall thread_native_entry(Thread*);
>>
>> Why was this removed? This is needed to correctly specify the call sequence
>> for th
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has b
64 matches
Mail list logo
