On Thu, 24 Nov 2022 01:23:00 GMT, Serguei Spitsyn wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix formatting
>
> Nice doc update.
> Looks good to me.
> Thanks,
> Serguei
Thanks for looking at this @sspitsyn !
On Wed, 23 Nov 2022 10:14:23 GMT, Serguei Spitsyn wrote:
>> This problem has two sides.
>> One is that the `VirtualThread::run() `cashes the field `notifyJvmtiEvents`
>> value.
>> It caused the native method `notifyJvmtiUnmountBegin()` not called after the
>> field `notifyJvmtiEvents`
>> value
On Thu, 24 Nov 2022 00:50:22 GMT, David Holmes wrote:
>> This is mainly an expansion of the included platforms by changing "linux and
>> macOS" to "Non-Windows". There are a few additional examples, and
>> clarification that they are just examples. There are also some minor edits
>> and correc
> This is mainly an expansion of the included platforms by changing "linux and
> macOS" to "Non-Windows". There are a few additional examples, and
> clarification that they are just examples. There are also some minor edits
> and corrections I spotted.
>
> One actual fix relates to the "control
> This is mainly an expansion of the included platforms by changing "linux and
> macOS" to "Non-Windows". There are a few additional examples, and
> clarification that they are just examples. There are also some minor edits
> and corrections I spotted.
>
> One actual fix relates to the "control
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> li
On Wed, 23 Nov 2022 12:31:26 GMT, Kevin Walls wrote:
> Simple change to remove these mentions of RuntimeOperationsException.
>
> More notes in the bug, but this seems like a long-standing oversight that has
> become the only warning in "make docs".
Marked as reviewed by amenkov (Reviewer).
--
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> li
On Wed, 23 Nov 2022 18:25:59 GMT, Ioi Lam wrote:
> Remove code for supporting an ancient JDK version (1.4.2). We don't have any
> test cases for this code so it's unclear whether it still works or not.
>
> Testing: tiers 1-4.
Looks good. Thanks for the cleanup!
-
Marked as review
On Wed, 23 Nov 2022 19:20:53 GMT, Daniel Fuchs wrote:
> The java.base/net/, java.http/, java.naming/ changes look reasonable to me -
> though like Alan I wonder if it wouldn't be better to have an inline `{@spec
> }` tag - similar to `{@systemProperty }`, rather than repeating all the
> refere
On Wed, 23 Nov 2022 18:25:59 GMT, Ioi Lam wrote:
> Remove code for supporting an ancient JDK version (1.4.2). We don't have any
> test cases for this code so it's unclear whether it still works or not.
>
> Testing: tiers 1-4.
Looks good.
Surprised that code survived for so long!
Thanks.
---
On Wed, 23 Nov 2022 05:22:10 GMT, Kim Barrett wrote:
>> It's to avoid redefining the linkage as static in os_windows.cpp (where it's
>> implemented) after an extern declaration (inside the class), which is
>> forbidden by C++11:
>>
>>> The linkages implied by successive declarations for a give
On Wed, 23 Nov 2022 18:25:59 GMT, Ioi Lam wrote:
> Remove code for supporting an ancient JDK version (1.4.2). We don't have any
> test cases for this code so it's unclear whether it still works or not.
>
> Testing: tiers 1-4.
Looks good and reasonable.
Thanks,
Serguei
-
Marked as
On Wed, 23 Nov 2022 10:31:00 GMT, Alan Bateman wrote:
>> Fixed the `yieldContinuation()` method.
>> There is also `switchToCarrierThread()` method that returns the
>> `notifyJvmtiEvents` value.
>> It seems to be an optimization. I'm not sure yet, if we need to fix these
>> places as well.
>
>>
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> li
On Wed, 23 Nov 2022 12:31:26 GMT, Kevin Walls wrote:
> Simple change to remove these mentions of RuntimeOperationsException.
>
> More notes in the bug, but this seems like a long-standing oversight that has
> become the only warning in "make docs".
It is good.
Thanks,
Serguei
-
M
On Wed, 23 Nov 2022 02:22:46 GMT, Chris Plummer wrote:
> [JDK-8295376](https://bugs.openjdk.org/browse/JDK-8295376) introduced some
> new code that disables JVMTI VIRTUAL_THREAD_START/END events when the
> debugger disconnects. Sometimes this disabling attempt results in a
> JVMTI_ERROR_WRONG_
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed in the `@spec` tags.
>
> "Somewhat automated" means that I
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
On Wed, 23 Nov 2022 02:22:46 GMT, Chris Plummer wrote:
> [JDK-8295376](https://bugs.openjdk.org/browse/JDK-8295376) introduced some
> new code that disables JVMTI VIRTUAL_THREAD_START/END events when the
> debugger disconnects. Sometimes this disabling attempt results in a
> JVMTI_ERROR_WRONG_
Remove code for supporting an ancient JDK version (1.4.2). We don't have any
test cases for this code so it's unclear whether it still works or not.
Testing: tiers 1-4.
-
Commit messages:
- 8295253: Remove kludge from v1_0/PerfDataBuffer.java
Changes: https://git.openjdk.org/jdk/p
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty
wrote:
> Misc stress testing related fixes:
>
> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
> another JLI GetObjectSizeIntrinsicsTest.java subtest
> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Wed, 23 Nov 2022 17:21:42 GMT, Daniel D. Daugherty
wrote:
> What kind of testing has been done?
I ran tier1 and tier3 and ran the jck 1000 times (previously it failed twice in
1200 runs).
-
PR: https://git.openjdk.org/jdk/pull/11307
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Wed, 23 Nov 2022 02:22:46 GMT, Chris Plummer wrote:
> [JDK-8295376](https://bugs.openjdk.org/browse/JDK-8295376) introduced some
> new code that disables JVMTI VIRTUAL_THREAD_START/END events when the
> debugger disconnects. Sometimes this disabling attempt results in a
> JVMTI_ERROR_WRONG_
On Wed, 23 Nov 2022 12:43:16 GMT, Daniel Fuchs wrote:
> Thanks for adding the RFC prefix to the RFC link. What is the purpose of
> editing non exported classes though, like those in the `sun.net` subpackages?
That was not intentional, and is a result of the scripted edit. I will look to
r
On Wed, 23 Nov 2022 12:31:26 GMT, Kevin Walls wrote:
> Simple change to remove these mentions of RuntimeOperationsException.
>
> More notes in the bug, but this seems like a long-standing oversight that has
> become the only warning in "make docs".
Thanks Daniel!
-
PR: https://gi
On Wed, 23 Nov 2022 12:31:26 GMT, Kevin Walls wrote:
> Simple change to remove these mentions of RuntimeOperationsException.
>
> More notes in the bug, but this seems like a long-standing oversight that has
> become the only warning in "make docs".
Seems reasonable to me.
-
Marke
On Tue, 22 Nov 2022 22:04:57 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> li
Simple change to remove these mentions of RuntimeOperationsException.
More notes in the bug, but this seems like a long-standing oversight that has
become the only warning in "make docs".
-
Commit messages:
- Copyright year
- 8297192: Warning generating API docs for javax.manageme
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Wed, 23 Nov 2022 10:16:44 GMT, Serguei Spitsyn wrote:
> There is also `switchToCarrierThread()` method that returns the
> `notifyJvmtiEvents` value.
> It seems to be an optimization. I'm not sure yet, if we need to fix these
> places as well.
It was to ensure that hide(true) and hide(false)
On Wed, 23 Nov 2022 10:01:07 GMT, Serguei Spitsyn wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 273:
>>
>>> 271: private void run(Runnable task) {
>>> 272: assert state == RUNNING;
>>> 273: boolean notifyJvmti = notifyJvmtiEvents;
>>
>> Don't we hav
> This problem has two sides.
> One is that the `VirtualThread::run() `cashes the field `notifyJvmtiEvents`
> value.
> It caused the native method `notifyJvmtiUnmountBegin()` not called after the
> field `notifyJvmtiEvents`
> value has been set to `true` when an agent library is loaded into runni
On Wed, 23 Nov 2022 02:17:43 GMT, Leonid Mesnik wrote:
>> This problem has two sides.
>> One is that the `VirtualThread::run() `cashes the field `notifyJvmtiEvents`
>> value.
>> It caused the native method `notifyJvmtiUnmountBegin()` not called after the
>> field `notifyJvmtiEvents`
>> value ha
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
37 matches
Mail list logo
