On Sat, 7 Jan 2023 17:41:04 GMT, Kim Barrett wrote:
> Please review this change to remove GCCause::_wb_conc_mark and the supporting
> implementation. After JDK-8293824 it is no longer used as the cause when
> requesting a GC.
>
> Note: The implementation in ZGC appears to have never been used.
On Mon, 9 Jan 2023 15:01:21 GMT, Erik Österlund wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits
> Please review this change to remove GCCause::_wb_conc_mark and the supporting
> implementation. After JDK-8293824 it is no longer used as the cause when
> requesting a GC.
>
> Note: The implementation in ZGC appears to have never been used. Prior to
> JDK-8293824 this cause was only used by a
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the compiler
On Tue, 10 Jan 2023 23:38:14 GMT, Maurizio Cimadamore
wrote:
>> OK I'm glad you pointed that out because I'm a little unclear on the best
>> way to do this bit.
>>
>> Just to confirm, you are saying that this:
>>
>> `if (erasure(type).equalsIgnoreMetadata(outerType)) {`
>>
>> should be repla
On Wed, 11 Jan 2023 00:04:14 GMT, Maurizio Cimadamore
wrote:
>> Yes, because the 'this' reference can bounce around through different
>> variables in scope each time around the loop. So we have to repeat the loop
>> until all 'this' references have "flooded" into all the nooks and crannies.
>>
On Tue, 10 Jan 2023 19:20:35 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 1098:
>>
>>> 1096: private void visitLooped(T tree, Consumer
>>> visitor) {
>>> 1097: this.visitScoped(tree, false, t -> {
>>> 1098:
On Tue, 10 Jan 2023 23:45:59 GMT, Maurizio Cimadamore
wrote:
>> It's slightly different from that.
>>
>> Considering any of the various things in scope that can point to an object
>> (these are: the current 'this' instance, the current outer 'this' instance,
>> method parameter/variable, meth
On Tue, 10 Jan 2023 19:18:04 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 85:
>>
>>> 83: *
>>> 84: *
>>> 85: * When tracking references, we distinguish between direct references
>>> and indirect references,
>>
>> I'
On Tue, 10 Jan 2023 16:56:31 GMT, Afshin Zafari wrote:
>> test of tier1-5 passed.
>
> Afshin Zafari has updated the pull request incrementally with three
> additional commits since the last revision:
>
> - 8292741: Convert JvmtiTagMapTable to ResourceHashtable
> - 8292741: Convert JvmtiTagMap
On Tue, 10 Jan 2023 16:56:31 GMT, Afshin Zafari wrote:
>> test of tier1-5 passed.
>
> Afshin Zafari has updated the pull request incrementally with three
> additional commits since the last revision:
>
> - 8292741: Convert JvmtiTagMapTable to ResourceHashtable
> - 8292741: Convert JvmtiTagMap
On Tue, 10 Jan 2023 19:42:06 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 2345:
>>
>>> 2343: if (!innerType.hasTag(CLASS) || !outerType.hasTag(CLASS))
>>> 2344: return false;
>>> 2345: innerType = erasure(inner
> Remove abstraction that is a holdover from Solaris. Direct usages of
> `MmapArrayAllocator` have been switched to normal `malloc`. The justification
> is that none of the code paths are called from signal handlers, so using
> `mmap` directly does not make sense and is potentially slower than g
> Remove abstraction that is a holdover from Solaris. Direct usages of
> `MmapArrayAllocator` have been switched to normal `malloc`. The justification
> is that none of the code paths are called from signal handlers, so using
> `mmap` directly does not make sense and is potentially slower than g
> Remove abstraction that is a holdover from Solaris. Direct usages of
> `MmapArrayAllocator` have been switched to normal `malloc`. The justification
> is that none of the code paths are called from signal handlers, so using
> `mmap` directly does not make sense and is potentially slower than g
Remove abstraction that is a holdover from Solaris. Direct usages of
`MmapArrayAllocator` have been switched to normal `malloc`. The justification
is that none of the code paths are called from signal handlers, so using `mmap`
directly does not make sense and is potentially slower than going thr
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the compiler
On Mon, 9 Jan 2023 14:23:47 GMT, Maurizio Cimadamore
wrote:
>> Archie L. Cobbs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix incorrect @bug numbers in unit tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.j
On Mon, 9 Jan 2023 15:03:10 GMT, Maurizio Cimadamore
wrote:
>> Archie L. Cobbs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix incorrect @bug numbers in unit tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEsc
On Sat, 7 Jan 2023 21:08:07 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gener
On Wed, 21 Dec 2022 18:50:52 GMT, Alexey Bakhtin wrote:
> Please find a patch to improve JMX Repository.query performance
>
> Using ObjectName.apply() allows significantly decrease memory usage and the
> number of GC cycles:
> Before:
>
> $ java test 100 100
> Test PASSED in 8943169791
> test of tier1-5 passed.
Afshin Zafari has updated the pull request incrementally with three additional
commits since the last revision:
- 8292741: Convert JvmtiTagMapTable to ResourceHashtable
- 8292741: Convert JvmtiTagMapTable to ResourceHashtable
- 8292741: Convert JvmtiTagMapTable to Re
On Mon, 9 Jan 2023 10:30:06 GMT, Fredrik Bredberg wrote:
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tested tier1-tier8 on
On Tue, 10 Jan 2023 14:38:32 GMT, Axel Boldt-Christmas
wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tie
On Mon, 9 Jan 2023 10:30:06 GMT, Fredrik Bredberg wrote:
> Implementation of relativized locals in interpreter frames for x86. x64, arm,
> aarch64, ppc64le and riscv.
> Not relativized locals on zero and s390 but done some changes to cope with
> the changed generic code.
> Tested tier1-tier8 on
> Simple change of using the actual type for a field.
>
> Test: hotspot_gc
Albert Mingkun Yang has updated the pull request incrementally with one
additional commit since the last revision:
review
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11925/files
- new: https://
On Tue, 10 Jan 2023 10:51:14 GMT, Albert Mingkun Yang wrote:
> Simple change of using the actual type for a field.
>
> Test: hotspot_gc
Looks good. Some nits:
src/hotspot/share/gc/serial/tenuredGeneration.hpp line 68:
> 66: void assert_correct_size_change_locking();
> 67:
> 68: TenuredSp
On Tue, 10 Jan 2023 10:51:14 GMT, Albert Mingkun Yang wrote:
> Simple change of using the actual type for a field.
>
> Test: hotspot_gc
Marked as reviewed by tschatzl (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11925
> harmless refactor to share code across different platforms of
> VirtualMachineImpl:
> 1. Shared code to process command response after requesting a command
> execution
> 2. Read functionality in SocketInputStream can be reused
Yi Yang has updated the pull request incrementally with three addit
Simple change of using the actual type for a field.
Test: hotspot_gc
-
Commit messages:
- s1-tenured-space
Changes: https://git.openjdk.org/jdk/pull/11925/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11925&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8299853
S
30 matches
Mail list logo
