On Thu, 23 Mar 2023 02:17:44 GMT, David Holmes wrote:
> Seems okay. But I am really over this game of whack-a-mole with
> ThreadWXEnable.
You're not the only one.
Andrei Pangin added a workaround to async-profiler, so nobody noticed the
problem before.
-
PR Comment: https://git
> The fix is to enable virtual threads support for late binding JVMTI agents.
> The fix includes:
> - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which
> does enabling JVMTI VTMS transition notifications in case of agent loaded
> into running VM. This function executes a VM
On Thu, 23 Mar 2023 02:02:01 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor cleanup in enable_virtual_threads_notify_jvmti()
>
> src/hotspot/share/prims/jvmtiThreadState.hpp line 102:
>
On Thu, 23 Mar 2023 02:00:56 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor cleanup in enable_virtual_threads_notify_jvmti()
>
> src/hotspot/share/prims/jvmtiEnvBase.hpp line 87:
>
>>
On Wed, 22 Mar 2023 15:57:40 GMT, Johannes Bechberger
wrote:
> Fixes the issue by transitioning the thread into the WXWrite mode while
> walking the stack in AsyncGetCallTrace.
>
> Tested on my M1 mac.
Seems okay. But I am really over this game of whack-a-mole with ThreadWXEnable.
--
On Wed, 22 Mar 2023 19:06:34 GMT, Serguei Spitsyn wrote:
>> The fix is to enable virtual threads support for late binding JVMTI agents.
>> The fix includes:
>> - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which
>> does enabling JVMTI VTMS transition notifications in case
On Wed, 22 Mar 2023 21:36:57 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor cleanup in enable_virtual_threads_notify_jvmti()
>
> src/hotspot/share/prims/jvmtiExport.cpp line 389:
>
>>
On Wed, 22 Mar 2023 21:11:45 GMT, Chris Plummer wrote:
> > The fix is to enable support for late binding JVMTI agents.
> Just to be clear, the late binding support was already there, but wasn't
> working properly with virtual threads. Correct?
Nice catch. Right, it is virtual threads support. Fi
On Wed, 22 Mar 2023 19:06:34 GMT, Serguei Spitsyn wrote:
>> The fix is to enable support for late binding JVMTI agents.
>> The fix includes:
>> - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which
>> does enabling JVMTI VTMS transition notifications in case of agent loaded
On Wed, 22 Mar 2023 19:06:34 GMT, Serguei Spitsyn wrote:
>> The fix is to enable support for late binding JVMTI agents.
>> The fix includes:
>> - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which
>> does enabling JVMTI VTMS transition notifications in case of agent loaded
> The fix is to enable support for late binding JVMTI agents.
> The fix includes:
> - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which
> does enabling JVMTI VTMS transition notifications in case of agent loaded
> into running VM. This function executes a VM operation count
On Thu, 16 Mar 2023 23:54:13 GMT, Leonid Mesnik wrote:
> The com/sun/jdi tests are located in the on package, and classes with same
> name cause 'class duplication error' when this directory is opened as source
> code in IDE.
>
> The simplest fix to avoid this is just to rename class.
This pu
On Wed, 22 Mar 2023 09:46:04 GMT, Roman Kennke wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 670:
>>
>>> 668: get_thread (scrReg);// beware: clobbers ICCs
>>> 669: movptr(Address(boxReg, OM_OFFSET_NO_MONITOR_VALUE_TAG(owner)),
>>> scrReg);
>>> 670: xorpt
On Wed, 22 Mar 2023 09:47:47 GMT, Roman Kennke wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 791:
>>
>>> 789: Compile::current()->output()->add_stub(stub);
>>> 790: jcc(Assembler::notEqual, stub->entry());
>>> 791: bind(stub->continuation());
>>
>> Why use stub
> The current structure used to store the resolution information for
> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
> ambigious fields f1 and f2. This structure can hold information for fields,
> methods, and invokedynamics and each of its fields can hold different
Fixes the issue by transitioning the thread into the WXWrite mode while walking
the stack in AsyncGetCallTrace.
Tested on my M1 mac.
-
Commit messages:
- Fix 8304725
Changes: https://git.openjdk.org/jdk/pull/13144/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13144&range
On Wed, 22 Mar 2023 00:25:43 GMT, Vladimir Kozlov wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/JDK-8291555-v2' into JDK-8291555-v2
>> - Set condition flags correctly after
On Tue, 21 Mar 2023 00:53:31 GMT, Serguei Spitsyn wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more cleanup
>
> src/hotspot/share/prims/jvmtiEnvBase.hpp line 166:
>
>> 164:
>> 165: const void* get_env_loc
18 matches
Mail list logo
