RFR: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries

2023-04-07 Thread Jiangli Zhou
… with JDK native libraries - Commit messages: - 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries Changes: https://git.openjdk.org/jdk/pull/13397/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13397&range=00 Issue: https://b

Withdrawn: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries

2023-04-07 Thread Jiangli Zhou
On Fri, 7 Apr 2023 23:32:46 GMT, Jiangli Zhou wrote: > Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol > problems when statically linking the launcher executable with JDK native > libraries. > > 8305761: Resolve multiple definition of 'jvm' when statically linking with > JD

RFR: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries

2023-04-07 Thread Jiangli Zhou
Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol problems when statically linking the launcher executable with JDK native libraries. 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries - Commit messages: - Resolve link

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-07 Thread Vladimir Kozlov
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote: > Updated VM internal object allocation C2 intrinsic to post jvmti events when > needed. Good. - Marked as reviewed by kvn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13312#pullrequestreview-1376633778

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-07 Thread Leonid Mesnik
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote: > Updated VM internal object allocation C2 intrinsic to post jvmti events when > needed. Tested with all CI tests. - PR Comment: https://git.openjdk.org/jdk/pull/13312#issuecomment-1500670951

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-07 Thread Leonid Mesnik
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote: > Updated VM internal object allocation C2 intrinsic to post jvmti events when > needed. Thanks to Vladimir K for fix in escape.cpp. - PR Comment: https://git.openjdk.org/jdk/pull/13312#issuecomment-1500656370

RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-07 Thread Leonid Mesnik
Updated VM internal object allocation C2 intrinsic to post jvmti events when needed. - Commit messages: - fixed EA - Merge branch 'master' of https://github.com/openjdk/jdk into 8277573 - 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects Change

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v8]

2023-04-07 Thread Roger Riggs
On Fri, 7 Apr 2023 21:13:03 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X8

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Roger Riggs
On Fri, 7 Apr 2023 06:03:11 GMT, Thomas Stuefe wrote: >>> What did you use as the example that would not compile on the other >>> architecture? >> >> https://github.com/openjdk/jdk/blob/52ca4a70fc3de9e285964f9545ea8cd54e2d9924/src/java.base/share/classes/jdk/internal/util/OperatingSystemProps.

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Roger Riggs
On Fri, 7 Apr 2023 12:05:28 GMT, Lutz Schmidt wrote: >> Okay, Lutz is the expert here. Sorry for the noise. > > Just to let my voice be heard directly after being cited several times: s390 > is used to designate the CPU architecture. The arch-specific files are stored > in src/hotspot/cpu/s390

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v8]

2023-04-07 Thread Roger Riggs
> Define an internal jdk.internal.util.Architecture enumeration and static > methods to replace uses of the system property `os.arch`. > The enumeration values are defined to match those used in the build. > The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X, > PPC64LE` > Note

Re: RFR: 8298048: Combine CDS archive heap into a single block

2023-04-07 Thread Matias Saavedra Silva
On Mon, 3 Apr 2023 03:32:27 GMT, Ioi Lam wrote: > This PR combines the "open" and "closed" regions of the CDS archive heap into > a single region. This significantly simplifies the implementation, making it > more compatible with non-G1 collectors. There's a net removal of ~1000 lines > in src

Re: RFR: 8298048: Combine CDS archive heap into a single block

2023-04-07 Thread Matias Saavedra Silva
On Mon, 3 Apr 2023 03:32:27 GMT, Ioi Lam wrote: > This PR combines the "open" and "closed" regions of the CDS archive heap into > a single region. This significantly simplifies the implementation, making it > more compatible with non-G1 collectors. There's a net removal of ~1000 lines > in src

Re: RFR: 8304834: Fix wrapper insertion in TestScaffold.parseArgs(String args[]) [v2]

2023-04-07 Thread Leonid Mesnik
On Fri, 24 Mar 2023 06:31:14 GMT, Leonid Mesnik wrote: >> The TestScaffold incorrectly parse options, it should insert wrapper class >> between VM options and applications classame. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8304834: Fix wrapper insertion in TestScaffold.parseArgs(String args[]) [v3]

2023-04-07 Thread Leonid Mesnik
> The TestScaffold incorrectly parse options, it should insert wrapper class > between VM options and applications classame. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: updated parsing. - Changes: - all: https://

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Roger Riggs
On Thu, 6 Apr 2023 22:44:52 GMT, Phil Race wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unneeded qualified export from java.base to jdk.attach > > src/jdk.accessibility/windows/classes/com/sun/java/accessi

Re: RFR: 8304919: Implementation of Virtual Threads [v7]

2023-04-07 Thread Jaikiran Pai
On Fri, 7 Apr 2023 11:54:00 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Lutz Schmidt
On Fri, 7 Apr 2023 11:21:33 GMT, Thomas Stuefe wrote: >> Hello Thomas, that change was based on the review comment here >> https://github.com/openjdk/jdk/pull/13357#discussion_r1159810942 > > Okay, Lutz is the expert here. Sorry for the noise. Just to let my voice be heard directly after being

Re: RFR: 8304919: Implementation of Virtual Threads [v7]

2023-04-07 Thread Alan Bateman
> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The > APIs that were preview APIs in Java 19/20 are changed to permanent and their > `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The > JNI and JVMTI versions are bumped as this is the first chan

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Thomas Stuefe
On Fri, 7 Apr 2023 10:52:47 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/jdk/internal/util/Architecture.java line 41: >> >>> 39: AARCH64(), >>> 40: RISCV64(), >>> 41: S390(), >> >> Why getting rid of the X in s390x? There has not been an s390 linux kernel >> in almost te

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Jaikiran Pai
On Fri, 7 Apr 2023 10:24:20 GMT, Thomas Stuefe wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unneeded qualified export from java.base to jdk.attach > > src/java.base/share/classes/jdk/internal/util/Architec

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Thomas Stuefe
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X8

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread ExE Boss
On Fri, 7 Apr 2023 09:28:18 GMT, Thomas Stuefe wrote: > > > What I meant was: You define PPCLE. PPCLE specifies ppc, little endian. > > > We also have PPC big-endian, it is used by AIX (and you can also run > > > Linux with PPC big-endian). Why omit that? > > > os.arch for AIX is "ppc64". > >

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Thomas Stuefe
On Fri, 7 Apr 2023 07:42:51 GMT, Alan Bateman wrote: > > What I meant was: You define PPCLE. PPCLE specifies ppc, little endian. We > > also have PPC big-endian, it is used by AIX (and you can also run Linux > > with PPC big-endian). Why omit that? > > os.arch for AIX is "ppc64". > > So I thin

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread ExE Boss
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X8

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Alan Bateman
On Fri, 7 Apr 2023 07:38:31 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits si

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Alan Bateman
On Fri, 7 Apr 2023 07:43:02 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits si

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Alan Bateman
On Fri, 7 Apr 2023 07:44:39 GMT, Jaikiran Pai wrote: >> test/jdk/java/lang/Thread/java.base/jdk/internal/event/ThreadSleepEvent.java >> line 29: >> >>> 27: * ThreadSleepEvent to optionally throw OOME at create, begin or commit >>> time. >>> 28: */ >>> 29: public class ThreadSleepEvent { >>

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Jaikiran Pai
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Jaikiran Pai
On Fri, 7 Apr 2023 07:25:59 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits si

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Alan Bateman
On Fri, 7 Apr 2023 06:33:08 GMT, Thomas Stuefe wrote: > What I meant was: You define PPCLE. PPCLE specifies ppc, little endian. We > also have PPC big-endian, it is used by AIX (and you can also run Linux with > PPC big-endian). Why omit that? > > os.arch for AIX is "ppc64". So I think you ar

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Jaikiran Pai
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Jaikiran Pai
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Jaikiran Pai
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Alan Bateman
On Fri, 7 Apr 2023 06:56:51 GMT, Jaikiran Pai wrote: > In a JDK image that's built out of this PR, does the missing `@JEP` > annotation on this enum value cause issues in javadoc image generation or > presentation on that page? This has been looked at a few times and we didn't find any issues.

Re: RFR: 8304919: Implementation of Virtual Threads [v6]

2023-04-07 Thread Jaikiran Pai
On Thu, 6 Apr 2023 15:49:27 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>