On Wed, 3 May 2023 12:01:10 GMT, Afshin Zafari wrote:
> All of them can use the default one
Exactly my point.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1184606381
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote:
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
> This class is not referenced by other classes or tests.
Thanks for all the comments and reviews.
On the RMIConnector example, I had thought it was misleading to use
On Wed, 3 May 2023 14:18:00 GMT, Kevin Walls wrote:
> This should be a trivial change, to remove a test which is unreliable, and to
> remove its problem list entry.
>
> The test is unreliable, but also the updated Panama situation is that we now
> have Linker.Option.CaptureCallState which give
On Wed, 3 May 2023 14:18:00 GMT, Kevin Walls wrote:
> This should be a trivial change, to remove a test which is unreliable, and to
> remove its problem list entry.
>
> The test is unreliable, but also the updated Panama situation is that we now
> have Linker.Option.CaptureCallState which give
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote:
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
> This class is not referenced by other classes or tests.
Removing RMIIIOPServerImpl is fine, I think I agree with Daniel on leaving out
the change to RMIConnector. I
On Tue, 2 May 2023 16:47:06 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that removes the pinned tag from `HeapRegion`.
>>
>> So that "pinned" tag for G1 heap regions indicates that the region should
>> not move during (young) gc. This applies to now removed archive
On Thu, 27 Apr 2023 12:31:24 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that removes the pinned tag from `HeapRegion`.
>>
>> So that "pinned" tag for G1 heap regions indicates that the region should
>> not move during (young) gc. This applies to now removed archive
On Tue, 2 May 2023 20:37:18 GMT, Daniel D. Daugherty wrote:
>> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.
>
> Daniel D. Daugherty has updated the pull request incrementally with one
> additional commit since the last revision:
>
> dholmes CR - change ':' to '.'.
On Tue, 2 May 2023 21:16:20 GMT, Leonid Mesnik wrote:
> The debugger tests might start all debugee using virtual threads when
> property "main.wrapper" is set.
> However, the new mode JTREG_TEST_THREAD_FACTORY do the same thing. The only
> difference is that it use predefined problemlist names
On Wed, 3 May 2023 22:04:37 GMT, Alex Menkov wrote:
>> src/hotspot/share/prims/jvmtiTagMap.cpp line 2319:
>>
>>> 2317: }
>>> 2318: }
>>> 2319: }
>>
>> The fragments 2289-2303 and 2305-2319 are based on the
>> `StackValueCollection` and look very similar.
>> It can be wo
On Wed, 3 May 2023 22:02:30 GMT, Alex Menkov wrote:
>> The fix updates JVMTI FollowReferences implementation to report references
>> from virtual threads:
>> - unmounted vthreads are detected, their stack references for
>> JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL;
>> - st
On Tue, 2 May 2023 10:10:32 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added "no continuations" test case
>
> src/hotspot/share/prims/jvmtiTagMap.cpp line 2245:
>
>> 2243: bool is_top_fr
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - unmounted vthreads are detected, their stack references for
> JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL;
> - stacks of mounted vthreads are splitted into 2 parts (virtual
On Wed, 3 May 2023 21:32:54 GMT, Martin Doerr wrote:
> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>
> ```
> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
> "minor" is defined
> by . For historical compatibility, it is
> currently defined by as
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap i
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap i
On Wed, 3 May 2023 19:36:55 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version tha
On Wed, 3 May 2023 20:00:42 GMT, Chris Plummer wrote:
>> Yes, the test was finicky with the heap size. Given that the leak it tries
>> to provoke would be provoked by other GCs as well, we didn't think it was
>> that important to run this particular test with Generational ZGC. If you
>> still
On Wed, 3 May 2023 18:54:24 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/ProblemList-generational-zgc.txt line 27:
>
>> 25: #
>> 26: # List of quar
On Wed, 3 May 2023 19:42:01 GMT, Stefan Karlsson wrote:
>> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 30:
>>
>>> 28: *
>>> 29: * @comment Don't allow -Xcomp or -Xint as they impact memory useage
>>> and number of iterations
>>> 30: * @requires (vm.compMode == "Xmixed") & !(vm.gc.Z &
On Wed, 3 May 2023 18:57:22 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 30:
>
>> 28: *
>> 29: * @comm
On Wed, 3 May 2023 18:52:19 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/hotspot/jtreg/ProblemList-generational-zgc.txt line 32:
>
>> 30: # Quiet all S
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap i
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version tha
On Wed, 3 May 2023 14:18:00 GMT, Kevin Walls wrote:
> This should be a trivial change, to remove a test which is unreliable, and to
> remove its problem list entry.
>
> The test is unreliable, but also the updated Panama situation is that we now
> have Linker.Option.CaptureCallState which give
On Wed, 3 May 2023 08:36:22 GMT, Stefan Johansson wrote:
>> Hi all,
>>
>> Please review this change to avoid CleanClassLoaderDataMetaspaces safepoint
>> when there is nothing that can be cleaned up.
>>
>> **Summary**
>> When transforming/redefining classes a previous version list is linked
>
This should be a trivial change, to remove a test which is unreliable, and to
remove its problem list entry.
The test is unreliable, but also the updated Panama situation is that we now
have Linker.Option.CaptureCallState which gives us the chance to capture last
error when calling a MethodHand
On Fri, 14 Apr 2023 19:23:05 GMT, Kevin Walls wrote:
> This test is failing often since 8304725 added a call to
> Thread::current_in_asgct(). This can end up being called e.g. when resolving
> calls, and then the OS last error value is lost.
>
> The test is reliable with a single warm-up call
On Sat, 15 Apr 2023 10:15:20 GMT, Kevin Walls wrote:
>> This test is failing often since 8304725 added a call to
>> Thread::current_in_asgct(). This can end up being called e.g. when
>> resolving calls, and then the OS last error value is lost.
>>
>> The test is reliable with a single warm-up
On Tue, 25 Apr 2023 13:49:05 GMT, Thomas Schatzl wrote:
> Hi all,
>
> please review this change that removes the pinned tag from `HeapRegion`.
>
> So that "pinned" tag for G1 heap regions indicates that the region should not
> move during (young) gc. This applies to now removed archive regio
On Wed, 26 Apr 2023 17:28:49 GMT, Chris Plummer wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cplummer review
>
> SA changes look good.
Thanks @plummercj @sspitsyn @albertnetymk for your reviews
-
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version tha
On Wed, 3 May 2023 12:29:15 GMT, Martin Doerr wrote:
> Thanks for fixing PPC64! With this, the VM compiles and the
> `test/hotspot/jtreg/gc` tests are passing on linux PPC64le.
>
> I'm glad to see this PR for JDK 21 LTS. It's a big step forward for ZGC.
> Congratulations!
Thanks for porting G
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version tha
On Wed, 3 May 2023 05:42:29 GMT, David Holmes wrote:
>> It seems much better to force implementors to provide this method.
>
> Why? They all seem to do exactly the same thing.
After I moved the `registerCleanup` to the body of a `default` method in the
interface, there is no need for the implem
On Tue, 2 May 2023 17:57:14 GMT, Kevin Walls wrote:
> Removal of class, looks like it was missed in the JDK9 removal of RMIIIOP.
> This class is not referenced by other classes or tests.
Marked as reviewed by dfuchs (Reviewer).
Looks good to me. I probably wouldn't have bothered with removing t
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap i
On Wed, 3 May 2023 09:04:50 GMT, Stefan Karlsson wrote:
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exi
Hi all,
Please review the implementation of Generational ZGC, which can be turned on by
adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational ZGC is
a major rewrite of the non-generational ZGC version that exists in the
openjdk/jdk repository. It splits the heap into two gene
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
> Hi all,
>
> Please review this change to avoid CleanClassLoaderDataMetaspaces safepoint
> when there is nothing that can be cleaned up.
>
> **Summary**
> When transforming/redefining classes a previous version list is linked
> together in the InstanceKlass. The original class is added to thi
On Fri, 28 Apr 2023 15:57:49 GMT, Coleen Phillimore wrote:
>> Stefan Johansson has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test refactor
>> - Serguei review
>
> This looks good. Thanks for all the testing and adding the new test.
42 matches
Mail list logo
