[jdk21] RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

2023-06-20 Thread Serguei Spitsyn
Clean backport from latest jdk repo to jdk21 for the fix of: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING Testing: - TBD: mach5 tiers 1-5 - Commit messages: - Backport f91e9ba757f04983655c23542e06973805465249 Changes: https://git.openj

Re: [jdk21] RFR: 8303916: ThreadLists.java inconsistent results

2023-06-20 Thread Serguei Spitsyn
On Fri, 16 Jun 2023 09:15:52 GMT, Kevin Walls wrote: > Clean backport from latest jdk repo to jdk21 for the test change: > 8303916: ThreadLists.java inconsistent results The backport looks clean. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.o

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v3]

2023-06-20 Thread Phil Race
On Mon, 19 Jun 2023 06:55:52 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: [jdk21] RFR: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException

2023-06-20 Thread Kevin Walls
On Tue, 20 Jun 2023 18:25:02 GMT, Chris Plummer wrote: > Clean backport of [JDK-8308499](https://bugs.openjdk.org/browse/JDK-8308499) Looks good. - Marked as reviewed by kevinw (Committer). PR Review: https://git.openjdk.org/jdk21/pull/41#pullrequestreview-1488944096

[jdk21] RFR: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException

2023-06-20 Thread Chris Plummer
Clean backport of [JDK-8308499](https://bugs.openjdk.org/browse/JDK-8308499) - Commit messages: - Backport 79ff72a7762deb6010b57e5ac0ccede3d035ab4c Changes: https://git.openjdk.org/jdk21/pull/41/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=41&range=00 Issue: https://b

RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x

2023-06-20 Thread Tom Rodriguez
This is a minor fix to core file reading on macos x. I can confirm that after this fix I can run the problem listed SA core file tests on Ventura. - Commit messages: - 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x Changes: https://git.openjdk.org/

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files

2023-06-20 Thread Daohan Qu
On Tue, 20 Jun 2023 14:02:35 GMT, Ashutosh Mehra wrote: > On another note since you mentioned > [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) I should let you > know I have a fix for it and am planning to open a PR soon. Good news! Never mind and thanks for your notice đŸ˜„. ---

Re: RFR: 8242152: SA does not include StackMapTables when dumping .class files

2023-06-20 Thread Ashutosh Mehra
On Tue, 20 Jun 2023 11:31:40 GMT, Daohan Qu wrote: > This patch adds `StackMapTable` for the class files generated by `clhsdb`'s > `buildreplayjars` command. This bug manifests itself during my diagnosing > [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be > fixed firs

Integrated: 8310194: Generational ZGC: Lock-order asserts in JVMTI IterateThroughHeap

2023-06-20 Thread Stefan Karlsson
On Fri, 16 Jun 2023 11:52:51 GMT, Stefan Karlsson wrote: > Generational ZGC changed the location where the heap object iterator called > the visit function. It used to be called when the objects were popped and > then followed, but it was changed so that the function where called > immediately

Re: RFR: 8310194: Generational ZGC: Lock-order asserts in JVMTI IterateThroughHeap

2023-06-20 Thread Stefan Karlsson
On Fri, 16 Jun 2023 11:52:51 GMT, Stefan Karlsson wrote: > Generational ZGC changed the location where the heap object iterator called > the visit function. It used to be called when the objects were popped and > then followed, but it was changed so that the function where called > immediately

RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work

2023-06-20 Thread Matthias Baesken
Currently, a number of tests fail on macOS because they miss the core file (e.g. serviceability/sa/TestJmapCore.java). The reason is that configure detects on some setups that codesign does not work ("checking if debug mode codesign is possible... no) . So adding the needed entitlement to generat

RFR: 8242152: SA does not include StackMapTables when dumping .class files

2023-06-20 Thread Daohan Qu
This patch adds `StackMapTable` for the class files generated by `clhsdb`'s `buildreplayjars` command. This bug manifests itself during my diagnosing [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be fixed first. I have run jtreg test `tier1-3` of release build on x86 l

Re: [jdk21] RFR: 8310187: Improve Generational ZGC jtreg testing

2023-06-20 Thread Erik Ă–sterlund
On Tue, 20 Jun 2023 11:17:40 GMT, Axel Boldt-Christmas wrote: > Hi all, > > This pull request contains a backport of commit > [a0595761](https://github.com/openjdk/jdk/commit/a0595761ef35c4eec8cb84326a869b9473cd5bba) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The c

[jdk21] RFR: 8310187: Improve Generational ZGC jtreg testing

2023-06-20 Thread Axel Boldt-Christmas
Hi all, This pull request contains a backport of commit [a0595761](https://github.com/openjdk/jdk/commit/a0595761ef35c4eec8cb84326a869b9473cd5bba) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Axel Boldt-Christmas on 20 Jun 2023 and

Integrated: 8310187: Improve Generational ZGC jtreg testing

2023-06-20 Thread Axel Boldt-Christmas
On Fri, 16 Jun 2023 09:14:10 GMT, Axel Boldt-Christmas wrote: > The current implementation for testing generational ZGC with jtreg is > implemented with a filter on the mode flag `ZGenerational`. Because of this > only environments which set this flag explicitly will run most of the tests. >

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v3]

2023-06-20 Thread Axel Boldt-Christmas
On Mon, 19 Jun 2023 06:55:52 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v3]

2023-06-20 Thread Axel Boldt-Christmas
On Mon, 19 Jun 2023 09:04:17 GMT, Thomas Stuefe wrote: > How much time do we spend now in GHAs on the additional Zgenerational tests? > In any case, this makes sense. This adds around 40 more tests per platform. The runtime of GHA seems to have a lot of run to run variance. Most new tests are

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v4]

2023-06-20 Thread Julian Waters
On Wed, 12 Apr 2023 07:12:10 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request incrementally with four additional > commits since th

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v5]

2023-06-20 Thread Julian Waters
> C11 has been stable for a long time on all platforms, so native code can use > the standard alignas operator for alignment requirements Julian Waters has updated the pull request incrementally with three additional commits since the last revision: - Whitespace - Revert - _MSC_VER