Integrated: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 This pull request has now been integrated. Changeset: 8242c647 Author:Julian Waters URL: https://git.openjdk.org/jdk/commit/8242c647b9d31320757363b69e7048a109ce86df Stats: 11 lines in 3 fil

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 Our tier 1 builds have passed. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14645#pullrequestreview-1497595990

Re: RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work [v3]

2023-06-25 Thread Chris Plummer
On Fri, 23 Jun 2023 08:37:16 GMT, Matthias Baesken wrote: > Chris are you okay with the latest rev. of this change? Sorry, I've been on vacation the past few days. I will have a look at it tomorrow. - PR Comment: https://git.openjdk.org/jdk/pull/14562#issuecomment-1606661232

Re: RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x [v2]

2023-06-25 Thread Chris Plummer
On Fri, 23 Jun 2023 19:31:20 GMT, Tom Rodriguez wrote: >> This is a minor fix to core file reading on macos x. I can confirm that >> after this fix I can run the problem listed SA core file tests on Ventura. > > Tom Rodriguez has updated the pull request incrementally with three > additional c

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 04:26:47 GMT, David Holmes wrote: > > as is evident in the tests for this PR > > You mean the GHA builds? They don't seem to be building the failing > `jdk.jdwp.agent-static-libs` target. I can't recompile the JDK at the moment to compile ArrayReferenceImpl.c, but I can de

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 Okay I have it running through our tier1 builds at the moment. If that passes I will approve the PR. Thanks - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606580347

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 04:23:58 GMT, Julian Waters wrote: > as is evident in the tests for this PR You mean the GHA builds? They don't seem to be building the failing `jdk.jdwp.agent-static-libs` target. - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606573575

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 How was the original change tested? How was this change tested? - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606571300

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 _Alignas does work on Microsoft Visual C, fortunately - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606570803

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 04:15:09 GMT, David Holmes wrote: > https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170 :/ > How was the original change tested? How was this change tested? I made the mistake of testing the original on gcc instead of the native compiler for Wind

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Microsoft, your C "conformance" is garbage https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170 - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606567568

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Microsoft, your C "conformance" is garbage @dholmes-ora - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606505881

RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
Microsoft, your C "conformance" is garbage - Commit messages: - ArrayReferenceImpl.c - GSSLibStub.c - 8310863 Changes: https://git.openjdk.org/jdk/pull/14645/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14645&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310863

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]

2023-06-25 Thread David Holmes
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase.

Integrated: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes

2023-06-25 Thread Julian Waters
On Fri, 31 Mar 2023 06:07:39 GMT, Julian Waters wrote: > C11 has been stable for a long time on all platforms, so native code can use > the standard alignas operator for alignment requirements This pull request has now been integrated. Changeset: 78c38317 Author:Julian Waters URL:

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]

2023-06-25 Thread David Holmes
On Sun, 25 Jun 2023 15:58:06 GMT, Julian Waters wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 18 commits: >> >> - Merge branch 'openjdk:master' into patch-6 >> - Whitespace >> - Revert >> - _MSC_VER >

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]

2023-06-25 Thread Martin Doerr
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase.

Re: RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v6]

2023-06-25 Thread Julian Waters
On Fri, 23 Jun 2023 02:43:38 GMT, Julian Waters wrote: >> C11 has been stable for a long time on all platforms, so native code can use >> the standard alignas operator for alignment requirements > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase.

RFR: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit

2023-06-25 Thread Doug Simon
The VMSupport class is required for translating an exception between the HotSpot and libgraal heaps. Loading it lazily can result in a loading exception, obscuring the exception being translated. To avoid this, VMSupport is loaded eagerly along with the other vmClasses. - Commit mes