On Wed, 23 Aug 2023 01:25:40 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/perfMemory.hpp line 137:
>>
>>> 135: static size_t capacity() { return _capacity; }
>>> 136: static bool is_initialized();
>>> 137: static bool is_destroyed();
>>
>> So don't we need to make changes h
On Wed, 23 Aug 2023 02:51:04 GMT, Chris Plummer wrote:
>> Agreed - I assume the change to int was for the release_store etc but that
>> is not needed so we can keep the bool type and existing code.
>
> I was also partly going for consistency with _initialized and _destroyed
> w.r.t. int vs bool
> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
> noted that the PerfMemory _initialized and _destroyed fields should be
> volatile, but VMStructs didn't have the needed support for doing that, so it
> was left as a future task. @YaSuenag provided a patch at the time t
On Wed, 23 Aug 2023 01:16:54 GMT, Leonid Mesnik wrote:
> Test updated to run debugee VM with correct options.
Looks good. Make sure you test with the Virtual thread factory since that adds
additional argument complications.
-
Marked as reviewed by cjplummer (Reviewer).
PR Review:
On Tue, 22 Aug 2023 23:22:37 GMT, Chris Plummer wrote:
> The CDS archive can change memory locations on different runs of the same JVM
> binary. This exposed a long standing bug in FileMapInfo.java. It was caching
> addresses that could be different for different JVM processes. As a result,
>
On Wed, 23 Aug 2023 00:49:18 GMT, Yasumasa Suenaga wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> release_store() and load_acquire() not needed for _destroyed
>
> src/hotspot/share/runtime/perfMemory.hpp line 137
Test updated to run debugee VM with correct options.
-
Commit messages:
- 831433
Changes: https://git.openjdk.org/jdk/pull/15398/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15398&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8314333
Stats: 5 lines in 1 file cha
On Wed, 23 Aug 2023 01:24:24 GMT, David Holmes wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> release_store() and load_acquire() not needed for _destroyed
>
> src/hotspot/share/runtime/perfMemory.cpp line 56:
>
On Tue, 22 Aug 2023 20:03:47 GMT, Chris Plummer wrote:
>> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
>> noted that the PerfMemory _initialized and _destroyed fields should be
>> volatile, but VMStructs didn't have the needed support for doing that, so it
>> was le
On Mon, 21 Aug 2023 19:25:25 GMT, Chris Plummer wrote:
> The test tries to match up various GC -XX:+PrintFlagsFinal values with the
> output of jhsdb -jmap --pid --heap. With ZGC, MaxNewSize set to
> (size_t)-1, but PrintFlagsFinal prints it as an unsigned long:
>
> size_t MaxNewSize = 18
On Tue, 22 Aug 2023 20:03:47 GMT, Chris Plummer wrote:
>> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
>> noted that the PerfMemory _initialized and _destroyed fields should be
>> volatile, but VMStructs didn't have the needed support for doing that, so it
>> was le
On Mon, 21 Aug 2023 21:26:11 GMT, Chris Plummer wrote:
>> ObjectMonitor.object() can be null so we need to defend against it. This bug
>> was discovered by code inspection while working on
>> [JDK-8280555](https://bugs.openjdk.org/browse/JDK-8280555). We have no test
>> for this, and I'm not
On Thu, 10 Aug 2023 01:45:47 GMT, Alex Menkov wrote:
> The change fixes several issues with capability management:
> - handling can_support_virtual_threads capability.
> JvmtiExport::can_support_virtual_threads() should be set to true if we have
> one or more agent with can_support_virtual_thre
The CDS archive can change memory locations on different runs of the same JVM
binary. This exposed a long standing bug in FileMapInfo.java. It was caching
addresses that could be different for different JVM processes. As a result,
doing an attach, detach, and then another attach to a different J
> Please review this change which moves checked_cast from globalDefinitions.hpp
> to a separate file. As part of this change we modify files that use
> checked_cast to directly include that new file. There are around 80 such
> files, and that change constitutes the majority of the changed files a
On Mon, 21 Aug 2023 20:21:49 GMT, Chris Plummer wrote:
> VM.buildLongFromIntsPD() is not longer used. Remove it.
This pull request has now been integrated.
Changeset: 7c169a42
Author:Chris Plummer
URL:
https://git.openjdk.org/jdk/commit/7c169a426f93a9c5f1223eddeb9ce0427722c8ab
Stats
On Mon, 21 Aug 2023 21:16:02 GMT, Chris Plummer wrote:
>> VM.buildLongFromIntsPD() is not longer used. Remove it.
>
> Chris Plummer has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update copyright
> - Remove debugging code
Thanks for th
On Tue, 22 Aug 2023 07:07:57 GMT, David Holmes wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> release_store() and load_acquire() not needed for _destroyed
>
> src/hotspot/share/runtime/perfMemory.cpp line 200:
>
> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
> noted that the PerfMemory _initialized and _destroyed fields should be
> volatile, but VMStructs didn't have the needed support for doing that, so it
> was left as a future task. @YaSuenag provided a patch at the time t
On Tue, 22 Aug 2023 08:50:29 GMT, Kevin Walls wrote:
> Looks like the SA floatAt is also unused.
> So if we don't see a need to maintain a full mirror of
> stackValueCollection.cpp then it could be trimmed more. 8-)
I think I'll leave it in. The main goal here was to prune some code that was
k
On Tue, 22 Aug 2023 06:54:20 GMT, Thomas Stuefe wrote:
>> Please review this change which moves checked_cast from globalDefinitions.hpp
>> to a separate file. As part of this change we modify files that use
>> checked_cast to directly include that new file. There are around 80 such
>> files, an
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote:
> Please review this simple PR.
This pull request has now been integrated.
Changeset: f39fc0aa
Author:Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/f39fc0aa2de19332fa51af605ece0660891d8c7a
Stats: 124 lines in 28 files ch
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote:
> Please review this simple PR.
You can leave the copyright years as-is.
-
PR Comment: https://git.openjdk.org/jdk/pull/15382#issuecomment-1688104170
On Tue, 22 Aug 2023 12:23:18 GMT, Mark Reinhold wrote:
> I wouldn’t update the copyright year as you have in some of these files.
I was taught to do it every time when I change a file. Would you like me to
revert those changes to copyright years in this case?
-
PR Comment: https:/
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote:
> Please review this simple PR.
Removing `@revised` tags is not a substantive change, so I wouldn’t update the
copyright year as you have in some of these files.
Otherwise, this looks fine.
-
Marked as reviewed by mr (Lead).
P
On Tue, 22 Aug 2023 04:13:13 GMT, Kim Barrett wrote:
> Please review this change which moves checked_cast from globalDefinitions.hpp
> to a separate file. As part of this change we modify files that use
> checked_cast to directly include that new file. There are around 80 such
> files, and that
On Mon, 21 Aug 2023 21:16:02 GMT, Chris Plummer wrote:
>> VM.buildLongFromIntsPD() is not longer used. Remove it.
>
> Chris Plummer has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update copyright
> - Remove debugging code
Marked as rev
Please review this simple PR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/15382/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15382&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8314738
Stats: 124 lines in 28 files changed: 0 ins
On Mon, 21 Aug 2023 21:47:14 GMT, Chris Plummer wrote:
> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
> noted that the PerfMemory _initialized and _destroyed fields should be
> volatile, but VMStructs didn't have the needed support for doing that, so it
> was left a
29 matches
Mail list logo
