RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

2023-08-31 Thread Alan Bateman
In the virtual thread implementation, thread identity switches to the carrier before freezing and switches back to the virtual thread after thawing. This was a forced move due to issues getting JVMTI to work with virtual threads. JVMTI can now hide events during transitions so we can invert the

RFR: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests

2023-08-31 Thread Aleksey Shipilev
Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests, each running exclusively. This drags the tier4 test times up. There seem to be no reason to run these tests exclusively, though: they complete in reasonable time, are lightly-threaded, and consume the usual amount of mem

RFR: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

2023-08-31 Thread Aleksey Shipilev
Current vmTestbase/nsk/monitoring/stress/thread tests contains 21 tests, each running exclusively. This drags the tier4 test times up. There seem to be no reason to run these tests exclusively, though: they complete in reasonable time, are lightly-threaded, and consume the usual amount of memory

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-31 Thread Mark Sheppard
On Thu, 31 Aug 2023 05:45:27 GMT, David Holmes wrote: > > So you could create a single createJavaProcessBuilder with add an > > additional parameter boolean addTestOpts e.g. > > createJavaProcessBuilder(List command, boolean addTestOpts) { ... } > > @msheppar that is actually where we started,

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

2023-08-31 Thread Markus Grönlund
On Wed, 30 Aug 2023 13:56:42 GMT, Alan Bateman wrote: > In the virtual thread implementation, thread identity switches to the carrier > before freezing and switches back to the virtual thread after thawing. This > was a forced move due to issues getting JVMTI to work with virtual threads. > JV

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

2023-08-31 Thread Alan Bateman
On Thu, 31 Aug 2023 10:38:32 GMT, Markus Grönlund wrote: >> In the virtual thread implementation, thread identity switches to the >> carrier before freezing and switches back to the virtual thread after >> thawing. This was a forced move due to issues getting JVMTI to work with >> virtual thre

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v6]

2023-08-31 Thread Dmitry Chuyko
> Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile` diagnostic command-line option and the > Compiler.add_dir

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

2023-08-31 Thread Markus Grönlund
On Thu, 31 Aug 2023 11:41:03 GMT, Alan Bateman wrote: >> src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp line 410: >> >>> 408: } >>> 409: if (JAVA_SAMPLE == type) { >>> 410: if (thread_state_in_java(thread) && >>> !is_vthread_in_transition(thread)) { >> >> I think this che

Re: RFR: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

2023-08-31 Thread Thomas Stuefe
On Thu, 31 Aug 2023 08:40:58 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/thread tests contains 21 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > reason to run these tests exclusively, though: they complete in reasonable

Re: RFR: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

2023-08-31 Thread Leonid Mesnik
On Thu, 31 Aug 2023 08:40:58 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/thread tests contains 21 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > reason to run these tests exclusively, though: they complete in reasonable

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code

2023-08-31 Thread Jiangli Zhou
On Thu, 31 Aug 2023 04:53:26 GMT, David Holmes wrote: > No not namespaces, just by using C++ so it a member function, then C++ name > mangling would mean the symbol would be different to some same-named function > in some other library - in essence the class name part of the symbol would > pro

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code

2023-08-31 Thread Jiangli Zhou
On Thu, 31 Aug 2023 05:00:18 GMT, David Holmes wrote: > Is `normalize` the only function that causes a conflict and the other changes > are just for consistency? If so please just rename normalize to e.g. > `normalize_path` Right, only `normalize` showed up in our testing so far. I suggested @

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code

2023-08-31 Thread Serguei Spitsyn
On Tue, 29 Aug 2023 23:37:06 GMT, Jiangli Zhou wrote: > Please review this simple change from @cjmoon1 for resolving static linking > issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be > found at: > https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_norma

Re: RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code

2023-08-31 Thread cjmoon1
On Tue, 29 Aug 2023 23:37:06 GMT, Jiangli Zhou wrote: > Please review this simple change from @cjmoon1 for resolving static linking > issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be > found at: > https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_norma

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

2023-08-31 Thread Patricio Chilano Mateo
On Wed, 30 Aug 2023 13:56:42 GMT, Alan Bateman wrote: > In the virtual thread implementation, thread identity switches to the carrier > before freezing and switches back to the virtual thread after thawing. This > was a forced move due to issues getting JVMTI to work with virtual threads. > JV

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

2023-08-31 Thread Patricio Chilano Mateo
On Thu, 31 Aug 2023 10:37:26 GMT, Markus Grönlund wrote: >> In the virtual thread implementation, thread identity switches to the >> carrier before freezing and switches back to the virtual thread after >> thawing. This was a forced move due to issues getting JVMTI to work with >> virtual thre

Integrated: JDK-8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions

2023-08-31 Thread Alex Menkov
On Thu, 10 Aug 2023 01:45:47 GMT, Alex Menkov wrote: > The change fixes several issues with capability management: > - handling can_support_virtual_threads capability. > JvmtiExport::can_support_virtual_threads() should be set to true if we have > one or more agent with can_support_virtual_thre

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing

2023-08-31 Thread Alan Bateman
On Thu, 31 Aug 2023 17:31:34 GMT, Patricio Chilano Mateo wrote: >> src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp line 415: >> >>> 413: } else { >>> 414: assert(NATIVE_SAMPLE == type, "invariant"); >>> 415: if (thread_state_in_native(thread) && >>> !is_vthread_in_transi

Re: RFR: 8311775: [TEST] duplicate verifyHeapDump in several tests [v4]

2023-08-31 Thread Chris Plummer
On Thu, 31 Aug 2023 01:53:36 GMT, Yi Yang wrote: >> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several >> tests, this patch tries to consolidate them into one method. > > Yi Yang has updated the pull request incrementally with one additional commit > since the last rev

Re: RFR: 8311775: [TEST] duplicate verifyHeapDump in several tests [v5]

2023-08-31 Thread Yi Yang
> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several > tests, this patch tries to consolidate them into one method. Yi Yang has updated the pull request incrementally with one additional commit since the last revision: Update HprofParser.java - Changes:

Re: RFR: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

2023-08-31 Thread David Holmes
On Thu, 31 Aug 2023 08:40:58 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/thread tests contains 21 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > reason to run these tests exclusively, though: they complete in reasonable